Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73316/?format=api
{ "id": 73316, "url": "https://patches.dpdk.org/api/patches/73316/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200706203743.29416-4-i.dyukov@samsung.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200706203743.29416-4-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200706203743.29416-4-i.dyukov@samsung.com", "date": "2020-07-06T20:37:17", "name": "[v6,03/25] app: UNKNOWN link speed print format", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "70f8568611015eabc86f5192bd578f1a4aa1e143", "submitter": { "id": 783, "url": "https://patches.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200706203743.29416-4-i.dyukov@samsung.com/mbox/", "series": [ { "id": 10825, "url": "https://patches.dpdk.org/api/series/10825/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10825", "date": "2020-07-06T20:37:14", "name": "ethdev: allow unknown link speed", "version": 6, "mbox": "https://patches.dpdk.org/series/10825/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73316/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/73316/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 861BFA00C5;\n\tMon, 6 Jul 2020 22:38:27 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A59501DD43;\n\tMon, 6 Jul 2020 22:38:03 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id E818F1DD2C\n for <dev@dpdk.org>; Mon, 6 Jul 2020 22:38:02 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200706203802euoutp0138ac6abdbee56d26f02cc75dab862232~fREsoTkWW0553305533euoutp01f;\n Mon, 6 Jul 2020 20:38:02 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTP id\n 20200706203801eucas1p11f4722e39a78de870354e407bc480a6c~fRErmgyrR0771107711eucas1p1n;\n Mon, 6 Jul 2020 20:38:01 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id 63.C9.05997.9AB830F5; Mon, 6\n Jul 2020 21:38:01 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200706203800eucas1p2e1cb90a305258ac2a02fb5de8abc03cb~fREqUe9uK2121221212eucas1p2z;\n Mon, 6 Jul 2020 20:38:00 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200706203800eusmtrp2166d799390963ac5a295ca5efce96d76~fREqTdSvK0640206402eusmtrp2p;\n Mon, 6 Jul 2020 20:38:00 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 61.7E.06017.8AB830F5; Mon, 6\n Jul 2020 21:38:00 +0100 (BST)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200706203758eusmtip1b17497f360182a942e58171c8d362d30~fREob5DxL1791017910eusmtip1i;\n Mon, 6 Jul 2020 20:37:58 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200706203802euoutp0138ac6abdbee56d26f02cc75dab862232~fREsoTkWW0553305533euoutp01f", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1594067882;\n bh=xmD2mOfSPYEySXTKCkIqMp30Ohht0MjEUFipNVMWweQ=;\n h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From;\n b=u0yAn/PDAezN5scMI8Hst/BOqBJGMRJDDaapmczWoJBho/RrFnnzJHMB/ycpBr+xB\n Q1nirR6M0bWlZIvvTlvT2RW+XluhK9k6NulJp0e8C54oPeOMjBd+LYyaOxQbwo/m1F\n BB0dTQZSukZSH2TfivtgwEXd4YDtTn2+IhL9sn68=", "X-AuditID": "cbfec7f4-677ff7000000176d-a6-5f038ba9c642", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com,\n thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com,\n arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com,\n beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com,\n mb@smartsharesystems.com, stephen@networkplumber.org,\n nicolas.chautru@intel.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com,\n radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com,\n skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com,\n kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com,\n xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com,\n jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com", "Date": "Mon, 6 Jul 2020 23:37:17 +0300", "Message-Id": "<20200706203743.29416-4-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200706203743.29416-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA0VSa0xbZRj2PV97zqGheOxIeMW5xWaaTSPTqcmrWYa3H0cTM36YeInK6nZk\n U9otPTB3M+IULJeBFpwbk8uKk8tmGNAV6EC2JqOwMubQpWAQyEIkXdnGgE1Btkp7WPz3fM/l\n e558+URmKuWTxW22LMVus2SaeYPO0z3X/2R9IUt/ynftYWrsqwS6MlLDaKzsT54Kp77iaLAh\n lTpaf9CTczSHo2LnTY5a6wp4mhzbr6Pr060cDXcGBCof2C/QtG9CoAMXjwBNLFxldLh6Buhi\n 5Sk9zZ318nRjwaWj4vnLQCXuHiB/0U0dlbW3AeUVSDRVXytQzfAKmh7r0VFgqEWgE7cuMTrV\n dwfoW38j0IW8iP7FR+T56mN6uaYjxMmlRy8xuXvooCAX9VZyctP1Nk6+8ctlXi52N4B8/koh\n k4+P/8OnGd41rN+iZG7bqdjXbthk2NpyLsx2lKXsCg3WQw7cXlUAcSJKz+IXQ3+xAjCIJqkO\n MHwoV4gKJmkW8Oi4rAkzgM3fuYR7ia6KEtCEWsCprhFOO9wCPF3hjbl4aTUGHJUxIVFq4rF1\n IchFhWXSBpxpicSwTnoU/+hojwWM0vM42eXSaxUr8fjJM4ujRDFOegErziVrk1ZgsGo2didK\n v4pYG/59yf8q/jhdxWt4GV71u5emLsdIexWn4b34d3NQ0MIOwBFX7pIpFd3hfiFaxqQ12Ohd\n q9EvYWlvE0RplBJw8NoDUZotQqfne6bRRnTkmTS3Gc/0DizRiHf+jddoGZ2Tc4L2PJ2Ad4Mn\n 2Dewsvz/rmqABkhSslVrhqKusymfpqgWq5pty0jZvN3aDItfNXDXP9sG3oUPfSCJYI43OniW\n btJbdqq7rT5AkZkTjS9fCHxgMm6x7N6j2Len27MzFdUHD4k6c5LxGVfofZOUYclSPlGUHYr9\n nsqJcck5YPh4tNxxrO/1konQpu5Xxu93tNh69iZ8Lbd3DpXtMhnT3KH+I2+dHH1TDf989nDu\n nvmBjLonUuPXee7b+Njpt5e/k7zev+/2RyPVB79kqqd3/idv22/v1UTy82caXxtI21hefH6y\n KN+z742ErNTCA4mRpOecxjWrOqzDXOLqzz97MEibvWadutXy9OPMrlr+A/naeDWmAwAA", "\n H4sIAAAAAAAAAzWSe0hTcRTH+917d++UVpe56IfYw1UQgatNzTPR9YK8f4kWRPTSpbcpOSf3\n bqVCpFJm0zTLgl5mmmVWmDpTwzQNs1omVpZmlo3KSpmvlCx7bEn/fTjf7znnC+dISfk45S2N\n TzTzQqI+QUl7UvbfbX1+Zdlk1KqfHyVQ8aQQgeNtCQn9BX00ZI8cIqC7fA001J6XwIl3aQTk\n nhgloLbMSsNQfwYFzrFaAt7ctTNw9lkGA2MtAwwc6ziHYGD6KwlnisYRdBTWSGCq+Q4Nw9PF\n FOT+6EKQZ3uIoC1nlIKC+joEmVYWRq5dZaDkzUIY639Igb2nmoEbE50k1Dz5hSC/rQJBe+Yf\n yVpf7kdRqYQrafhCcCcvdZLcg57TDJfzqJDgKp11BDfc2EVzubZyxD12ZJPc9Q/f6QjPbaoQ\n wWQx84vjTKI5VLldDRqVWgsqTYBWpfYP2hmsCVSu1IXE8gnx+3hhpS5aFVfdOkgmFaiSv3Rf\n Q2locqkVeUgxG4CbLuQhN8vZUoSr0sKsSOqqYzz4gZyxeOHpl1baijxdlnGEu/ryCbdAs8ux\n PauQcAsKtpfGz4+kU27Bi9Xh8eo//0wUuwy/bqhn3CxjtXioqVgyM3URvn7rHule5sEG4wut\n 3m6Us/H49TdmJs5C/OriN+I4mlOEZpUjBW8RjQajqFGJeqNoSTSoYkzGKuQ6+O0HU7Y6ZHVu\n bkGsFClny7JoMkou0e8TU4wtCEtJpUK2vt2+Sy6L1aek8oIpSrAk8GILCnTFyye958WYXO+T\n aI5SB6qDQKsO8g/yXw3K+bIstnmHnDXozfxenk/ihf99hNTDOw1t0aU6fGKfLt0uO95sWLXR\n YUkXFLVtvhu2bM0jwi7bGgcmfHw3OQ8X8Ytj/MIfV0Z+HpjamHlwd+flT37hi5Z03S+VvpjM\n Xze0v/fG4I4rB0S6IiV0rn5P5Puy2Kqv8SlHiyNsyryG1Mbed1nMqZsLdFXDOsGZvN8jWhFJ\n yUzp5holJcbp1StIQdT/BQ8mMRQGAwAA" ], "X-CMS-MailID": "20200706203800eucas1p2e1cb90a305258ac2a02fb5de8abc03cb", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200706203800eucas1p2e1cb90a305258ac2a02fb5de8abc03cb", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200706203800eucas1p2e1cb90a305258ac2a02fb5de8abc03cb", "References": "<20200427095737.11082-1-i.dyukov@samsung.com>\n <20200706203743.29416-1-i.dyukov@samsung.com>\n <CGME20200706203800eucas1p2e1cb90a305258ac2a02fb5de8abc03cb@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v6 03/25] app: UNKNOWN link speed print format", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "Reply-To": "i.dyukov@samsung.com", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add usage of rte_eth_link_strf function to example\napplications\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n app/proc-info/main.c | 9 +++------\n app/test-pipeline/init.c | 11 +++++------\n app/test-pmd/config.c | 20 ++++++++++++--------\n app/test-pmd/testpmd.c | 9 +--------\n app/test/test_pmd_perf.c | 17 +++++++----------\n 5 files changed, 28 insertions(+), 38 deletions(-)", "diff": "diff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex abeca4aab..4a4c572c3 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -685,12 +685,9 @@ show_port(void)\n \t\t\tprintf(\"Link get failed (port %u): %s\\n\",\n \t\t\t i, rte_strerror(-ret));\n \t\t} else {\n-\t\t\tprintf(\"\\t -- link speed %d duplex %d,\"\n-\t\t\t\t\t\" auto neg %d status %d\\n\",\n-\t\t\t\t\tlink.link_speed,\n-\t\t\t\t\tlink.link_duplex,\n-\t\t\t\t\tlink.link_autoneg,\n-\t\t\t\t\tlink.link_status);\n+\t\t\trte_eth_link_printf(\"\\t -- link speed: %M, duplex: %D,\"\n+\t\t\t\t\t\" auto neg: %A, status: %S\\n\",\n+\t\t\t\t\t&link);\n \t\t}\n \t\tprintf(\"\\t -- promiscuous (%d)\\n\",\n \t\t\t\trte_eth_promiscuous_get(i));\ndiff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c\nindex 67d54ae05..b59064672 100644\n--- a/app/test-pipeline/init.c\n+++ b/app/test-pipeline/init.c\n@@ -155,7 +155,7 @@ static void\n app_ports_check_link(void)\n {\n \tuint32_t all_ports_up, i;\n-\n+\tchar link_status_text[50];\n \tall_ports_up = 1;\n \n \tfor (i = 0; i < app.n_ports; i++) {\n@@ -173,12 +173,11 @@ app_ports_check_link(void)\n \t\t\tall_ports_up = 0;\n \t\t\tcontinue;\n \t\t}\n-\n-\t\tRTE_LOG(INFO, USER1, \"Port %u (%u Gbps) %s\\n\",\n+\t\trte_eth_link_strf(link_status_text, 50, \"(%G Gbps) %S\",\n+\t\t\t\t &link);\n+\t\tRTE_LOG(INFO, USER1, \"Port %u %s\\n\",\n \t\t\tport,\n-\t\t\tlink.link_speed / 1000,\n-\t\t\tlink.link_status ? \"UP\" : \"DOWN\");\n-\n+\t\t\tlink_status_text);\n \t\tif (link.link_status == ETH_LINK_DOWN)\n \t\t\tall_ports_up = 0;\n \t}\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex a7112c998..cb2795a94 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -604,10 +604,9 @@ port_infos_display(portid_t port_id)\n \t} else\n \t\tprintf(\"\\nmemory allocation on the socket: %u\",port->socket_id);\n \n-\tprintf(\"\\nLink status: %s\\n\", (link.link_status) ? (\"up\") : (\"down\"));\n-\tprintf(\"Link speed: %u Mbps\\n\", (unsigned) link.link_speed);\n-\tprintf(\"Link duplex: %s\\n\", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t (\"full-duplex\") : (\"half-duplex\"));\n+\trte_eth_link_printf(\"\\nLink status: %S\\n\"\n+\t\t\t \"Link speed: %M Mbps\\n\"\n+\t\t\t \"Link duplex: %D\\n\", &link);\n \n \tif (!rte_eth_dev_get_mtu(port_id, &mtu))\n \t\tprintf(\"MTU: %u\\n\", mtu);\n@@ -730,6 +729,8 @@ port_summary_display(portid_t port_id)\n \tstruct rte_eth_link link;\n \tstruct rte_eth_dev_info dev_info;\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n+\tchar status_text[6];\n+\tchar speed_text[12];\n \tint ret;\n \n \tif (port_id_is_invalid(port_id, ENABLED_WARN)) {\n@@ -750,12 +751,14 @@ port_summary_display(portid_t port_id)\n \tif (ret != 0)\n \t\treturn;\n \n-\tprintf(\"%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\\n\",\n+\trte_eth_link_strf(status_text, 6, \"%S\", &link);\n+\trte_eth_link_strf(speed_text, 12, \"%M\", &link);\n+\tprintf(\"%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %sMbps\\n\",\n \t\tport_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1],\n \t\tmac_addr.addr_bytes[2], mac_addr.addr_bytes[3],\n \t\tmac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name,\n-\t\tdev_info.driver_name, (link.link_status) ? (\"up\") : (\"down\"),\n-\t\t(unsigned int) link.link_speed);\n+\t\tdev_info.driver_name, status_text,\n+\t\tspeed_text);\n }\n \n void\n@@ -3899,7 +3902,8 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate)\n \tret = eth_link_get_nowait_print_err(port_id, &link);\n \tif (ret < 0)\n \t\treturn 1;\n-\tif (rate > link.link_speed) {\n+\tif (link.link_speed != ETH_SPEED_NUM_UNKNOWN &&\n+\t rate > link.link_speed) {\n \t\tprintf(\"Invalid rate value:%u bigger than link speed: %u\\n\",\n \t\t\trate, link.link_speed);\n \t\treturn 1;\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 4989d22ca..a1b9c1c1c 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -3010,14 +3010,7 @@ check_all_ports_link_status(uint32_t port_mask)\n \t\t\t}\n \t\t\t/* print link status if flag set */\n \t\t\tif (print_flag == 1) {\n-\t\t\t\tif (link.link_status)\n-\t\t\t\t\tprintf(\n-\t\t\t\t\t\"Port%d Link Up. speed %u Mbps- %s\\n\",\n-\t\t\t\t\tportid, link.link_speed,\n-\t\t\t\t(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t\t\t\t\t(\"full-duplex\") : (\"half-duplex\"));\n-\t\t\t\telse\n-\t\t\t\t\tprintf(\"Port %d Link Down\\n\", portid);\n+\t\t\t\trte_eth_link_printf(NULL, &link);\n \t\t\t\tcontinue;\n \t\t\t}\n \t\t\t/* clear all_ports_up flag if any link down */\ndiff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c\nindex 352cd4715..7ebe4efae 100644\n--- a/app/test/test_pmd_perf.c\n+++ b/app/test/test_pmd_perf.c\n@@ -126,6 +126,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)\n \tuint8_t count, all_ports_up, print_flag = 0;\n \tstruct rte_eth_link link;\n \tint ret;\n+\tchar link_status[50];\n \n \tprintf(\"Checking link statuses...\\n\");\n \tfflush(stdout);\n@@ -146,16 +147,12 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)\n \n \t\t\t/* print link status if flag set */\n \t\t\tif (print_flag == 1) {\n-\t\t\t\tif (link.link_status) {\n-\t\t\t\t\tprintf(\n-\t\t\t\t\t\"Port%d Link Up. Speed %u Mbps - %s\\n\",\n-\t\t\t\t\t\tportid, link.link_speed,\n-\t\t\t\t(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t\t\t\t\t(\"full-duplex\") : (\"half-duplex\"));\n-\t\t\t\t\tif (link_mbps == 0)\n-\t\t\t\t\t\tlink_mbps = link.link_speed;\n-\t\t\t\t} else\n-\t\t\t\t\tprintf(\"Port %d Link Down\\n\", portid);\n+\t\t\t\tif (link.link_status && link_mbps == 0)\n+\t\t\t\t\tlink_mbps = link.link_speed;\n+\n+\t\t\t\trte_eth_link_strf(link_status, 50, NULL,\n+\t\t\t\t\t\t &link);\n+\t\t\t\tprintf(\"Port %d %s\\n\", portid, link_status);\n \t\t\t\tcontinue;\n \t\t\t}\n \t\t\t/* clear all_ports_up flag if any link down */\n", "prefixes": [ "v6", "03/25" ] }