Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73213/?format=api
{ "id": 73213, "url": "https://patches.dpdk.org/api/patches/73213/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200706082502.26935-16-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200706082502.26935-16-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200706082502.26935-16-somnath.kotur@broadcom.com", "date": "2020-07-06T08:24:57", "name": "[15/20] net/bnxt: add support for conditional opcodes for mapper result table", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "423191904565cf94e5cd41627fff4c95a1f65ad5", "submitter": { "id": 908, "url": "https://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200706082502.26935-16-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 10805, "url": "https://patches.dpdk.org/api/series/10805/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10805", "date": "2020-07-06T08:24:42", "name": "bnxt patches", "version": 1, "mbox": "https://patches.dpdk.org/series/10805/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73213/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/73213/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 743DFA00C5;\n\tMon, 6 Jul 2020 10:33:22 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 974E91DAE8;\n\tMon, 6 Jul 2020 10:30:25 +0200 (CEST)", "from relay.smtp.broadcom.com (unknown [192.19.211.62])\n by dpdk.org (Postfix) with ESMTP id 7C14B1D9CE\n for <dev@dpdk.org>; Mon, 6 Jul 2020 10:30:07 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 11CF4298598;\n Mon, 6 Jul 2020 01:30:07 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 11CF4298598", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1594024207;\n bh=4yQcfeprYIIWRX09Luoplp4LL98LkzdYm1bEdxHa4gE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=qdGcjoxKuU7Db6P+YuC4xc0hNKFLHBQ2Jn5BGmtaAoZ1L5wC4Y//UcnLAUBhzDOfe\n u/DuQONlkIX9nmNPGynJwDBhws23wyAWUGPa/D6D9yh8WMojWOUBP6irmehbH/Jrye\n nFBuYzx4ricJVoBVznq9X/uC7ItdtEn0JxVkjClM=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Mon, 6 Jul 2020 13:54:57 +0530", "Message-Id": "<20200706082502.26935-16-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200706082502.26935-1-somnath.kotur@broadcom.com>", "References": "<20200706082502.26935-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 15/20] net/bnxt: add support for conditional\n\topcodes for mapper result table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n\nAdded support for conditional mapper result opcodes. The conditional\nopcodes allows to set the action details in hardware based on the\nactions configured for the flow. This allows aggregation of multiple\ntemplates.\n\nSigned-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\nReviewed-by: Michael Baucom <michael.baucom@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n---\n drivers/net/bnxt/tf_ulp/ulp_mapper.c | 69 ++++++++++++++++++++++++++\n drivers/net/bnxt/tf_ulp/ulp_template_db_enum.h | 4 +-\n drivers/net/bnxt/tf_ulp/ulp_template_struct.h | 2 +\n 3 files changed, 74 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\nindex dd99ea3..44fd0ac 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n@@ -841,7 +841,73 @@ ulp_mapper_result_field_process(struct bnxt_ulp_mapper_parms *parms,\n \t\t}\n \n \t\tbreak;\n+\tcase BNXT_ULP_MAPPER_OPC_IF_ACT_BIT_THEN_ACT_PROP_ELSE_CONST:\n+\t\tif (!ulp_operand_read(fld->result_operand,\n+\t\t\t\t (uint8_t *)&act_bit, sizeof(uint64_t))) {\n+\t\t\tBNXT_TF_DBG(ERR, \"%s operand read failed\\n\", name);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\t\tact_bit = tfp_be_to_cpu_64(act_bit);\n+\t\tif (ULP_BITMAP_ISSET(parms->act_bitmap->bits, act_bit)) {\n+\t\t\t/* Action bit is set so consider operand_true */\n+\t\t\tif (!ulp_operand_read(fld->result_operand_true,\n+\t\t\t\t\t (uint8_t *)&idx,\n+\t\t\t\t\t sizeof(uint16_t))) {\n+\t\t\t\tBNXT_TF_DBG(ERR, \"%s operand read failed\\n\",\n+\t\t\t\t\t name);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t\tidx = tfp_be_to_cpu_16(idx);\n+\t\t\tif (idx >= BNXT_ULP_ACT_PROP_IDX_LAST) {\n+\t\t\t\tBNXT_TF_DBG(ERR, \"%s act_prop[%d] oob\\n\",\n+\t\t\t\t\t name, idx);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t\tval = &parms->act_prop->act_details[idx];\n+\t\t\tfield_size = ulp_mapper_act_prop_size_get(idx);\n+\t\t\tif (fld->field_bit_size < ULP_BYTE_2_BITS(field_size)) {\n+\t\t\t\tfield_size = field_size -\n+\t\t\t\t ((fld->field_bit_size + 7) / 8);\n+\t\t\t\tval += field_size;\n+\t\t\t}\n+\t\t\tif (!ulp_blob_push(blob, val, fld->field_bit_size)) {\n+\t\t\t\tBNXT_TF_DBG(ERR, \"%s push field failed\\n\",\n+\t\t\t\t\t name);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t} else {\n+\t\t\t/* action bit is not set, use the operand false */\n+\t\t\tval = fld->result_operand_false;\n+\t\t\tif (!ulp_blob_push(blob, val, fld->field_bit_size)) {\n+\t\t\t\tBNXT_TF_DBG(ERR, \"%s failed to add field\\n\",\n+\t\t\t\t\t name);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t}\n+\t\tbreak;\n+\tcase BNXT_ULP_MAPPER_OPC_IF_ACT_BIT_THEN_CONST_ELSE_CONST:\n+\t\tif (!ulp_operand_read(fld->result_operand,\n+\t\t\t\t (uint8_t *)&act_bit, sizeof(uint64_t))) {\n+\t\t\tBNXT_TF_DBG(ERR, \"%s operand read failed\\n\", name);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\t\tact_bit = tfp_be_to_cpu_64(act_bit);\n+\t\tif (ULP_BITMAP_ISSET(parms->act_bitmap->bits, act_bit)) {\n+\t\t\t/* Action bit is set so consider operand_true */\n+\t\t\tval = fld->result_operand_true;\n+\t\t} else {\n+\t\t\t/* action bit is not set, use the operand false */\n+\t\t\tval = fld->result_operand_false;\n+\t\t}\n+\t\tif (!ulp_blob_push(blob, val, fld->field_bit_size)) {\n+\t\t\tBNXT_TF_DBG(ERR, \"%s failed to add field\\n\",\n+\t\t\t\t name);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\t\tbreak;\n \tdefault:\n+\t\tBNXT_TF_DBG(ERR, \"invalid result mapper opcode 0x%x\\n\",\n+\t\t\t fld->result_opcode);\n \t\treturn -EINVAL;\n \t}\n \treturn 0;\n@@ -973,6 +1039,9 @@ ulp_mapper_keymask_field_process(struct bnxt_ulp_mapper_parms *parms,\n \t\t}\n \t\tbreak;\n \tdefault:\n+\t\tBNXT_TF_DBG(ERR, \"invalid keymask mapper opcode 0x%x\\n\",\n+\t\t\t opcode);\n+\t\treturn -EINVAL;\n \t\tbreak;\n \t}\n \ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db_enum.h b/drivers/net/bnxt/tf_ulp/ulp_template_db_enum.h\nindex 14c77b3..2d73ea3 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_template_db_enum.h\n+++ b/drivers/net/bnxt/tf_ulp/ulp_template_db_enum.h\n@@ -212,7 +212,9 @@ enum bnxt_ulp_mapper_opc {\n \tBNXT_ULP_MAPPER_OPC_SET_TO_ACT_BIT = 6,\n \tBNXT_ULP_MAPPER_OPC_SET_TO_ACT_PROP = 7,\n \tBNXT_ULP_MAPPER_OPC_SET_TO_ENCAP_ACT_PROP_SZ = 8,\n-\tBNXT_ULP_MAPPER_OPC_LAST = 9\n+\tBNXT_ULP_MAPPER_OPC_IF_ACT_BIT_THEN_ACT_PROP_ELSE_CONST = 9,\n+\tBNXT_ULP_MAPPER_OPC_IF_ACT_BIT_THEN_CONST_ELSE_CONST = 10,\n+\tBNXT_ULP_MAPPER_OPC_LAST = 11\n };\n \n enum bnxt_ulp_mark_db_opcode {\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_template_struct.h b/drivers/net/bnxt/tf_ulp/ulp_template_struct.h\nindex ea4f253..2f2f9a2 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_template_struct.h\n+++ b/drivers/net/bnxt/tf_ulp/ulp_template_struct.h\n@@ -213,6 +213,8 @@ struct bnxt_ulp_mapper_result_field_info {\n \tenum bnxt_ulp_mapper_opc\tresult_opcode;\n \tuint16_t\t\t\tfield_bit_size;\n \tuint8_t\t\t\t\tresult_operand[16];\n+\tuint8_t\t\t\t\tresult_operand_true[16];\n+\tuint8_t\t\t\t\tresult_operand_false[16];\n };\n \n struct bnxt_ulp_mapper_ident_info {\n", "prefixes": [ "15/20" ] }