Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 73202,
    "url": "https://patches.dpdk.org/api/patches/73202/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200706082502.26935-5-somnath.kotur@broadcom.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200706082502.26935-5-somnath.kotur@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200706082502.26935-5-somnath.kotur@broadcom.com",
    "date": "2020-07-06T08:24:46",
    "name": "[04/20] net/bnxt: add validations to dpdk port id and phy port parsing",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "c6293524d762ed582e4b2fb2dd898ef88403fe19",
    "submitter": {
        "id": 908,
        "url": "https://patches.dpdk.org/api/people/908/?format=api",
        "name": "Somnath Kotur",
        "email": "somnath.kotur@broadcom.com"
    },
    "delegate": {
        "id": 1766,
        "url": "https://patches.dpdk.org/api/users/1766/?format=api",
        "username": "ajitkhaparde",
        "first_name": "Ajit",
        "last_name": "Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200706082502.26935-5-somnath.kotur@broadcom.com/mbox/",
    "series": [
        {
            "id": 10805,
            "url": "https://patches.dpdk.org/api/series/10805/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10805",
            "date": "2020-07-06T08:24:42",
            "name": "bnxt patches",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/10805/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/73202/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/73202/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 900EBA00C5;\n\tMon,  6 Jul 2020 10:30:50 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4C55A1DA6C;\n\tMon,  6 Jul 2020 10:30:12 +0200 (CEST)",
            "from relay.smtp.broadcom.com (unknown [192.19.211.62])\n by dpdk.org (Postfix) with ESMTP id 0F43E1D70F\n for <dev@dpdk.org>; Mon,  6 Jul 2020 10:30:04 +0200 (CEST)",
            "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 39F7A29848B;\n Mon,  6 Jul 2020 01:30:03 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 39F7A29848B",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1594024203;\n bh=QQkL/K3fVD/7YbY3uhcwEOCmf8QXP3dH1vsLjDf0UeE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=BoL7bxmOfO9v0ErrKwOk92TXNa8aRgYSZf/tRFJXxuog1NXWnBDENVOQOVOWNTNAu\n F03hsuTWWymLZVBAKk2mSybxsLF8WfBeZT/YOSAkrjOsXqHlVDc92ctVoRXjIBvERV\n uasxnETnBmGmMxGbx72cC586vv7qDHYifNLkAPGk=",
        "From": "Somnath Kotur <somnath.kotur@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com",
        "Date": "Mon,  6 Jul 2020 13:54:46 +0530",
        "Message-Id": "<20200706082502.26935-5-somnath.kotur@broadcom.com>",
        "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70",
        "In-Reply-To": "<20200706082502.26935-1-somnath.kotur@broadcom.com>",
        "References": "<20200706082502.26935-1-somnath.kotur@broadcom.com>",
        "Subject": "[dpdk-dev] [PATCH 04/20] net/bnxt: add validations to dpdk port id\n\tand phy port parsing",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n\nAdded validations to the ulp parser to validate the dpdk port id\nand phy port index during the flow creation.\n\nSigned-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\nReviewed-by: Michael Baucom <michael.baucom@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n---\n drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 50 ++++++++++++++++++++++++++++++--\n 1 file changed, 48 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\nindex a4dbd84..b8146c8 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n@@ -297,8 +297,13 @@ ulp_rte_port_id_hdr_handler(const struct rte_flow_item *item,\n \t * Copy the rte_flow_item for Port into hdr_field using port id\n \t * header fields.\n \t */\n-\tif (port_spec)\n+\tif (port_spec) {\n \t\tsvif = (uint16_t)port_spec->id;\n+\t\tif (svif >= RTE_MAX_ETHPORTS) {\n+\t\t\tBNXT_TF_DBG(ERR, \"ParseErr:Portid is not valid\\n\");\n+\t\t\treturn BNXT_TF_RC_PARSE_ERR;\n+\t\t}\n+\t}\n \tif (port_mask)\n \t\tmask = (uint16_t)port_mask->id;\n \n@@ -314,6 +319,8 @@ ulp_rte_phy_port_hdr_handler(const struct rte_flow_item *item,\n \tconst struct rte_flow_item_phy_port *port_spec = item->spec;\n \tconst struct rte_flow_item_phy_port *port_mask = item->mask;\n \tuint32_t svif = 0, mask = 0;\n+\tstruct bnxt_ulp_device_params *dparms;\n+\tuint32_t dev_id;\n \n \t/* Copy the rte_flow_item for phy port into hdr_field */\n \tif (port_spec)\n@@ -321,6 +328,22 @@ ulp_rte_phy_port_hdr_handler(const struct rte_flow_item *item,\n \tif (port_mask)\n \t\tmask = port_mask->index;\n \n+\tif (bnxt_ulp_cntxt_dev_id_get(params->ulp_ctx, &dev_id)) {\n+\t\tBNXT_TF_DBG(DEBUG, \"Failed to get device id\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdparms = bnxt_ulp_device_params_get(dev_id);\n+\tif (!dparms) {\n+\t\tBNXT_TF_DBG(DEBUG, \"Failed to get device parms\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (svif > dparms->num_phy_ports) {\n+\t\tBNXT_TF_DBG(ERR, \"ParseErr:Phy Port is not valid\\n\");\n+\t\treturn BNXT_TF_RC_PARSE_ERR;\n+\t}\n+\n \t/* Update the SVIF details */\n \treturn ulp_rte_parser_svif_set(params, item->type, svif, mask);\n }\n@@ -1330,7 +1353,12 @@ ulp_rte_port_id_act_handler(const struct rte_flow_action *act_item,\n \t\t\t\t    \"ParseErr:Portid Original not supported\\n\");\n \t\t\treturn BNXT_TF_RC_PARSE_ERR;\n \t\t}\n-\t\t/* TBD: Update the computed VNIC using port conversion */\n+\t\t/* Update the computed VNIC using port conversion */\n+\t\tif (port_id->id >= RTE_MAX_ETHPORTS) {\n+\t\t\tBNXT_TF_DBG(ERR,\n+\t\t\t\t    \"ParseErr:Portid is not valid\\n\");\n+\t\t\treturn BNXT_TF_RC_PARSE_ERR;\n+\t\t}\n \t\tpid = bnxt_get_vnic_id(port_id->id, BNXT_ULP_INTF_TYPE_INVALID);\n \t\tpid = rte_cpu_to_be_32(pid);\n \t\tmemcpy(&param->act_prop.act_details[BNXT_ULP_ACT_PROP_IDX_VNIC],\n@@ -1349,6 +1377,8 @@ ulp_rte_phy_port_act_handler(const struct rte_flow_action *action_item,\n {\n \tconst struct rte_flow_action_phy_port *phy_port;\n \tuint32_t vport;\n+\tstruct bnxt_ulp_device_params *dparms;\n+\tuint32_t dev_id;\n \n \tphy_port = action_item->conf;\n \tif (phy_port) {\n@@ -1357,6 +1387,22 @@ ulp_rte_phy_port_act_handler(const struct rte_flow_action *action_item,\n \t\t\t\t    \"Parse Err:Port Original not supported\\n\");\n \t\t\treturn BNXT_TF_RC_PARSE_ERR;\n \t\t}\n+\t\tif (bnxt_ulp_cntxt_dev_id_get(prm->ulp_ctx, &dev_id)) {\n+\t\t\tBNXT_TF_DBG(DEBUG, \"Failed to get device id\\n\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\tdparms = bnxt_ulp_device_params_get(dev_id);\n+\t\tif (!dparms) {\n+\t\t\tBNXT_TF_DBG(DEBUG, \"Failed to get device parms\\n\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\tif (phy_port->index > dparms->num_phy_ports) {\n+\t\t\tBNXT_TF_DBG(ERR, \"ParseErr:Phy Port is not valid\\n\");\n+\t\t\treturn BNXT_TF_RC_PARSE_ERR;\n+\t\t}\n+\n \t\t/* Get the vport of the physical port */\n \t\t/* TBD: shall be changed later to portdb call */\n \t\tvport = 1 << phy_port->index;\n",
    "prefixes": [
        "04/20"
    ]
}