Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73082/?format=api
{ "id": 73082, "url": "https://patches.dpdk.org/api/patches/73082/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200703210210.40568-34-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200703210210.40568-34-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200703210210.40568-34-ajit.khaparde@broadcom.com", "date": "2020-07-03T21:01:52", "name": "[v5,33/51] net/bnxt: add support for internal encap records", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4015c6d87973ee5c6589040364c8133e582d1163", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200703210210.40568-34-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 10785, "url": "https://patches.dpdk.org/api/series/10785/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10785", "date": "2020-07-03T21:01:19", "name": "net/bnxt: add features for host-based flow management", "version": 5, "mbox": "https://patches.dpdk.org/series/10785/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73082/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/73082/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B6A1EA0524;\n\tFri, 3 Jul 2020 23:11:10 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5B75A1DCDE;\n\tFri, 3 Jul 2020 23:05:56 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 952951DC7D\n for <dev@dpdk.org>; Fri, 3 Jul 2020 23:05:08 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id E05A830C075;\n Fri, 3 Jul 2020 14:05:07 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.185.215])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 58ABC1400A3;\n Fri, 3 Jul 2020 14:05:07 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com E05A830C075", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1593810307;\n bh=uyhhlfM1XyK3iZh6oZqvHZZNSFu9EcFQBXqQD8Tr/oU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=AiaMaPUc2W8jk0YZ+p4vOl0FCrk1vnAXsoASESEJ/j3wRagISDIjJty5bgmtbz291\n ijEkWnanZOu56dqbzyYfhFqYlIKCe+LcPC7rPB6vmilp5KROeQGoHIQOA+xaSzJDu7\n FE7F+TOR3iXsRiJ2d+BxOgxAc101t2KN6uWzyllI=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Mike Baucom <michael.baucom@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Fri, 3 Jul 2020 14:01:52 -0700", "Message-Id": "<20200703210210.40568-34-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200703210210.40568-1-ajit.khaparde@broadcom.com>", "References": "<1f5421dc-0453-6dc8-09c2-ddfff6eb4888@intel.com>\n <20200703210210.40568-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 33/51] net/bnxt: add support for internal\n\tencap records", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Mike Baucom <michael.baucom@broadcom.com>\n\nModifications to allow internal encap records to be supported:\n- Modified the mapper index table processing to handle encap without an\n action record\n- Modified the session open code to reserve some 64 Byte internal encap\n records on tx\n- Modified the blob encap swap to support encap without action record\n\nSigned-off-by: Mike Baucom <michael.baucom@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 3 +++\n drivers/net/bnxt/tf_ulp/ulp_mapper.c | 29 +++++++++++++---------------\n drivers/net/bnxt/tf_ulp/ulp_utils.c | 2 +-\n 3 files changed, 17 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\nindex a9ed5d92a..4c1a1c44c 100644\n--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n@@ -113,6 +113,9 @@ ulp_ctx_session_open(struct bnxt *bp,\n \tresources->tbl_cnt[TF_DIR_TX].cnt[TF_TBL_TYPE_FULL_ACT_RECORD] = 16;\n \tresources->tbl_cnt[TF_DIR_TX].cnt[TF_TBL_TYPE_ACT_STATS_64] = 16;\n \n+\t/* ENCAP */\n+\tresources->tbl_cnt[TF_DIR_TX].cnt[TF_TBL_TYPE_ACT_ENCAP_64B] = 16;\n+\n \t/* TCAMs */\n \tresources->tcam_cnt[TF_DIR_TX].cnt[TF_TCAM_TBL_TYPE_L2_CTXT_TCAM] = 8;\n \tresources->tcam_cnt[TF_DIR_TX].cnt[TF_TCAM_TBL_TYPE_PROF_TCAM] = 8;\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\nindex 734db7c6c..a9a625f9f 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n@@ -1473,7 +1473,7 @@ ulp_mapper_index_tbl_process(struct bnxt_ulp_mapper_parms *parms,\n \t\tflds = ulp_mapper_act_result_fields_get(tbl, &num_flds,\n \t\t\t\t\t\t\t&encap_flds);\n \n-\tif (!flds || !num_flds) {\n+\tif (!flds || (!num_flds && !encap_flds)) {\n \t\tBNXT_TF_DBG(ERR, \"template undefined for the index table\\n\");\n \t\treturn -EINVAL;\n \t}\n@@ -1482,7 +1482,7 @@ ulp_mapper_index_tbl_process(struct bnxt_ulp_mapper_parms *parms,\n \tfor (i = 0; i < (num_flds + encap_flds); i++) {\n \t\t/* set the swap index if encap swap bit is enabled */\n \t\tif (parms->device_params->encap_byte_swap && encap_flds &&\n-\t\t ((i + 1) == num_flds))\n+\t\t (i == num_flds))\n \t\t\tulp_blob_encap_swap_idx_set(&data);\n \n \t\t/* Process the result fields */\n@@ -1495,18 +1495,15 @@ ulp_mapper_index_tbl_process(struct bnxt_ulp_mapper_parms *parms,\n \t\t\tBNXT_TF_DBG(ERR, \"data field failed\\n\");\n \t\t\treturn rc;\n \t\t}\n+\t}\n \n-\t\t/* if encap bit swap is enabled perform the bit swap */\n-\t\tif (parms->device_params->encap_byte_swap && encap_flds) {\n-\t\t\tif ((i + 1) == (num_flds + encap_flds))\n-\t\t\t\tulp_blob_perform_encap_swap(&data);\n+\t/* if encap bit swap is enabled perform the bit swap */\n+\tif (parms->device_params->encap_byte_swap && encap_flds) {\n+\t\tulp_blob_perform_encap_swap(&data);\n #ifdef RTE_LIBRTE_BNXT_TRUFLOW_DEBUG\n-\t\t\tif ((i + 1) == (num_flds + encap_flds)) {\n-\t\t\t\tBNXT_TF_DBG(INFO, \"Dump fter encap swap\\n\");\n-\t\t\t\tulp_mapper_blob_dump(&data);\n-\t\t\t}\n+\t\tBNXT_TF_DBG(INFO, \"Dump after encap swap\\n\");\n+\t\tulp_mapper_blob_dump(&data);\n #endif\n-\t\t}\n \t}\n \n \t/* Perform the tf table allocation by filling the alloc params */\n@@ -1817,6 +1814,11 @@ ulp_mapper_action_tbls_process(struct bnxt_ulp_mapper_parms *parms)\n \t\tswitch (tbl->resource_func) {\n \t\tcase BNXT_ULP_RESOURCE_FUNC_INDEX_TABLE:\n \t\t\trc = ulp_mapper_index_tbl_process(parms, tbl, false);\n+\t\t\tif (rc) {\n+\t\t\t\tBNXT_TF_DBG(ERR, \"Resource type %d failed\\n\",\n+\t\t\t\t\t tbl->resource_func);\n+\t\t\t\treturn rc;\n+\t\t\t}\n \t\t\tbreak;\n \t\tdefault:\n \t\t\tBNXT_TF_DBG(ERR, \"Unexpected action resource %d\\n\",\n@@ -1824,11 +1826,6 @@ ulp_mapper_action_tbls_process(struct bnxt_ulp_mapper_parms *parms)\n \t\t\treturn -EINVAL;\n \t\t}\n \t}\n-\tif (rc) {\n-\t\tBNXT_TF_DBG(ERR, \"Resource type %d failed\\n\",\n-\t\t\t tbl->resource_func);\n-\t\treturn rc;\n-\t}\n \n \treturn rc;\n }\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_utils.c b/drivers/net/bnxt/tf_ulp/ulp_utils.c\nindex 3a4157f22..3afaac647 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_utils.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_utils.c\n@@ -478,7 +478,7 @@ ulp_blob_perform_encap_swap(struct ulp_blob *blob)\n \t\tBNXT_TF_DBG(ERR, \"invalid argument\\n\");\n \t\treturn; /* failure */\n \t}\n-\tidx = ULP_BITS_2_BYTE_NR(blob->encap_swap_idx + 1);\n+\tidx = ULP_BITS_2_BYTE_NR(blob->encap_swap_idx);\n \tend_idx = ULP_BITS_2_BYTE(blob->write_idx);\n \n \twhile (idx <= end_idx) {\n", "prefixes": [ "v5", "33/51" ] }