Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73057/?format=api
{ "id": 73057, "url": "https://patches.dpdk.org/api/patches/73057/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200703210210.40568-5-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200703210210.40568-5-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200703210210.40568-5-ajit.khaparde@broadcom.com", "date": "2020-07-03T21:01:23", "name": "[v5,04/51] net/bnxt: initialize parent PF information", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f6e6b762eb8d9fb3308066b2184a7979b3b2c6fe", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200703210210.40568-5-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 10785, "url": "https://patches.dpdk.org/api/series/10785/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10785", "date": "2020-07-03T21:01:19", "name": "net/bnxt: add features for host-based flow management", "version": 5, "mbox": "https://patches.dpdk.org/series/10785/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73057/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/73057/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 87DAAA0524;\n\tFri, 3 Jul 2020 23:06:18 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C80311DC94;\n\tFri, 3 Jul 2020 23:05:13 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 988291DBEB\n for <dev@dpdk.org>; Fri, 3 Jul 2020 23:04:58 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id B016830C065;\n Fri, 3 Jul 2020 14:04:56 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.185.215])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 25FDD14008B;\n Fri, 3 Jul 2020 14:04:56 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com B016830C065", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1593810296;\n bh=YMOYwr+I1AdlD2h1OWd47r7IG3rEpsojaKDSHLWog/o=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=AtKZ/VVsn2IIIYzuSn3iMep2cO9Mj047gOF53nhOyuUDJnvV9W9IJ/YO7EDnZOW9o\n nPMCONYdGLAVTeMz7VOfoNfDIeUDQVkEMcPFINGiHpKmBdjqmBkCb50Lmgh6ZzqUKr\n kYDyVybm0wCaNlSwv9jH18Ii/wFK0Or0Vh180jaE=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Lance Richardson <lance.richardson@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,\n Kishore Padmanabha <kishore.padmanabha@broadcom.com>", "Date": "Fri, 3 Jul 2020 14:01:23 -0700", "Message-Id": "<20200703210210.40568-5-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200703210210.40568-1-ajit.khaparde@broadcom.com>", "References": "<1f5421dc-0453-6dc8-09c2-ddfff6eb4888@intel.com>\n <20200703210210.40568-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 04/51] net/bnxt: initialize parent PF\n\tinformation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Lance Richardson <lance.richardson@broadcom.com>\n\nAdd support to query parent PF information (MAC address,\nfunction ID, port ID and default VNIC) from firmware.\n\nCurrent firmware returns zero for parent default vnic,\na temporary Wh+-specific workaround is included until\nthat can be fixed.\n\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 9 ++++++++\n drivers/net/bnxt/bnxt_ethdev.c | 23 +++++++++++++++++++\n drivers/net/bnxt/bnxt_hwrm.c | 42 ++++++++++++++++++++++++++++++++++\n drivers/net/bnxt/bnxt_hwrm.h | 1 +\n 4 files changed, 75 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 7afbd5cab..2b87899a4 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -217,6 +217,14 @@ struct bnxt_child_vf_info {\n \tbool\t\t\tpersist_stats;\n };\n \n+struct bnxt_parent_info {\n+#define\tBNXT_PF_FID_INVALID\t0xFFFF\n+\tuint16_t\t\tfid;\n+\tuint16_t\t\tvnic;\n+\tuint16_t\t\tport_id;\n+\tuint8_t\t\t\tmac_addr[RTE_ETHER_ADDR_LEN];\n+};\n+\n struct bnxt_pf_info {\n #define BNXT_FIRST_PF_FID\t1\n #define BNXT_MAX_VFS(bp)\t((bp)->pf->max_vfs)\n@@ -738,6 +746,7 @@ struct bnxt {\n #define BNXT_OUTER_TPID_BD_SHFT\t16\n \tuint32_t\t\touter_tpid_bd;\n \tstruct bnxt_pf_info\t*pf;\n+\tstruct bnxt_parent_info\t*parent;\n \tuint8_t\t\t\tvxlan_port_cnt;\n \tuint8_t\t\t\tgeneve_port_cnt;\n \tuint16_t\t\tvxlan_port;\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex cddba17bd..b765cbadb 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -96,6 +96,7 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {\n #define BNXT_DEVARG_TRUFLOW\t\"host-based-truflow\"\n #define BNXT_DEVARG_FLOW_XSTAT\t\"flow-xstat\"\n #define BNXT_DEVARG_MAX_NUM_KFLOWS \"max-num-kflows\"\n+\n static const char *const bnxt_dev_args[] = {\n \tBNXT_DEVARG_TRUFLOW,\n \tBNXT_DEVARG_FLOW_XSTAT,\n@@ -172,6 +173,11 @@ uint16_t bnxt_rss_hash_tbl_size(const struct bnxt *bp)\n \treturn bnxt_rss_ctxts(bp) * BNXT_RSS_ENTRIES_PER_CTX_THOR;\n }\n \n+static void bnxt_free_parent_info(struct bnxt *bp)\n+{\n+\trte_free(bp->parent);\n+}\n+\n static void bnxt_free_pf_info(struct bnxt *bp)\n {\n \trte_free(bp->pf);\n@@ -222,6 +228,16 @@ static void bnxt_free_mem(struct bnxt *bp, bool reconfig)\n \tbp->grp_info = NULL;\n }\n \n+static int bnxt_alloc_parent_info(struct bnxt *bp)\n+{\n+\tbp->parent = rte_zmalloc(\"bnxt_parent_info\",\n+\t\t\t\t sizeof(struct bnxt_parent_info), 0);\n+\tif (bp->parent == NULL)\n+\t\treturn -ENOMEM;\n+\n+\treturn 0;\n+}\n+\n static int bnxt_alloc_pf_info(struct bnxt *bp)\n {\n \tbp->pf = rte_zmalloc(\"bnxt_pf_info\", sizeof(struct bnxt_pf_info), 0);\n@@ -1321,6 +1337,7 @@ static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n \tbnxt_free_cos_queues(bp);\n \tbnxt_free_link_info(bp);\n \tbnxt_free_pf_info(bp);\n+\tbnxt_free_parent_info(bp);\n \n \teth_dev->dev_ops = NULL;\n \teth_dev->rx_pkt_burst = NULL;\n@@ -5209,6 +5226,8 @@ static int bnxt_init_fw(struct bnxt *bp)\n \n \tbnxt_hwrm_port_mac_qcfg(bp);\n \n+\tbnxt_hwrm_parent_pf_qcfg(bp);\n+\n \trc = bnxt_hwrm_cfa_adv_flow_mgmt_qcaps(bp);\n \tif (rc)\n \t\treturn rc;\n@@ -5527,6 +5546,10 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)\n \tif (rc)\n \t\tgoto error_free;\n \n+\trc = bnxt_alloc_parent_info(bp);\n+\tif (rc)\n+\t\tgoto error_free;\n+\n \trc = bnxt_alloc_hwrm_resources(bp);\n \tif (rc) {\n \t\tPMD_DRV_LOG(ERR,\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex ed42e58d4..347e1c71e 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -3094,6 +3094,48 @@ int bnxt_hwrm_func_qcfg(struct bnxt *bp, uint16_t *mtu)\n \treturn rc;\n }\n \n+int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)\n+{\n+\tstruct hwrm_func_qcfg_input req = {0};\n+\tstruct hwrm_func_qcfg_output *resp = bp->hwrm_cmd_resp_addr;\n+\tint rc;\n+\n+\tif (!BNXT_VF_IS_TRUSTED(bp))\n+\t\treturn 0;\n+\n+\tif (!bp->parent)\n+\t\treturn -EINVAL;\n+\n+\tbp->parent->fid = BNXT_PF_FID_INVALID;\n+\n+\tHWRM_PREP(&req, HWRM_FUNC_QCFG, BNXT_USE_CHIMP_MB);\n+\n+\treq.fid = rte_cpu_to_le_16(0xfffe); /* Request parent PF information. */\n+\n+\trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n+\n+\tHWRM_CHECK_RESULT();\n+\n+\tmemcpy(bp->parent->mac_addr, resp->mac_address, RTE_ETHER_ADDR_LEN);\n+\tbp->parent->vnic = rte_le_to_cpu_16(resp->dflt_vnic_id);\n+\tbp->parent->fid = rte_le_to_cpu_16(resp->fid);\n+\tbp->parent->port_id = rte_le_to_cpu_16(resp->port_id);\n+\n+\t/* FIXME: Temporary workaround - remove when firmware issue is fixed. */\n+\tif (bp->parent->vnic == 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Error: parent VNIC unavailable.\\n\");\n+\t\t/* Use hard-coded values appropriate for current Wh+ fw. */\n+\t\tif (bp->parent->fid == 2)\n+\t\t\tbp->parent->vnic = 0x100;\n+\t\telse\n+\t\t\tbp->parent->vnic = 1;\n+\t}\n+\n+\tHWRM_UNLOCK();\n+\n+\treturn 0;\n+}\n+\n int bnxt_hwrm_get_dflt_vnic_svif(struct bnxt *bp, uint16_t fid,\n \t\t\t\t uint16_t *vnic_id, uint16_t *svif)\n {\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h\nindex 8d19998df..ef8997500 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.h\n+++ b/drivers/net/bnxt/bnxt_hwrm.h\n@@ -274,4 +274,5 @@ int bnxt_hwrm_get_dflt_vnic_id(struct bnxt *bp, uint16_t fid,\n \t\t\t uint16_t *vnic_id);\n int bnxt_hwrm_get_dflt_vnic_svif(struct bnxt *bp, uint16_t fid,\n \t\t\t\t uint16_t *vnic_id, uint16_t *svif);\n+int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp);\n #endif\n", "prefixes": [ "v5", "04/51" ] }