Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73044/?format=api
{ "id": 73044, "url": "https://patches.dpdk.org/api/patches/73044/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200703155727.1320821-3-amorenoz@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200703155727.1320821-3-amorenoz@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200703155727.1320821-3-amorenoz@redhat.com", "date": "2020-07-03T15:57:27", "name": "[v4,2/2] net/virtio: add reply-ack support to Virtio-user", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b5bf41d3ca8a9851cdc97cb8e10795d07307a6f1", "submitter": { "id": 1397, "url": "https://patches.dpdk.org/api/people/1397/?format=api", "name": "Adrian Moreno", "email": "amorenoz@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200703155727.1320821-3-amorenoz@redhat.com/mbox/", "series": [ { "id": 10782, "url": "https://patches.dpdk.org/api/series/10782/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10782", "date": "2020-07-03T15:57:25", "name": "net/virtio: add vhost-user protocol features support", "version": 4, "mbox": "https://patches.dpdk.org/series/10782/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73044/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/73044/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0A0B7A0519;\n\tFri, 3 Jul 2020 17:57:59 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E08BE1DC94;\n\tFri, 3 Jul 2020 17:57:46 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 7D3531DC8B\n for <dev@dpdk.org>; Fri, 3 Jul 2020 17:57:44 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-204-IRUhT61FN_ex2rCDaQKVJg-1; Fri, 03 Jul 2020 11:57:39 -0400", "from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com\n [10.5.11.23])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 91C5180183C;\n Fri, 3 Jul 2020 15:57:38 +0000 (UTC)", "from amorenoz.users.ipa.redhat.com (ovpn-112-91.ams2.redhat.com\n [10.36.112.91])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 3A00A1972A;\n Fri, 3 Jul 2020 15:57:37 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1593791864;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=FDKivFeZsgC+dCGpbXrmE5AUguGZqlUoRnYYKxhueqY=;\n b=Eam9mC+CjTshaBgPRJRKkvxvYZXynmRDmYz4hMeKqnn+s0m4BOn7JQD4+kiKiPQ/+c2svB\n lqAY5y36oekLK+YihYBhv2+xBNBmAOAXzwOPzczozOjtWGcHT3EIFxaDnT3BW0eOCAVHB+\n bRb4cDrhEKkh7vcFoUfaIEuHzkoivhs=", "X-MC-Unique": "IRUhT61FN_ex2rCDaQKVJg-1", "From": "Adrian Moreno <amorenoz@redhat.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, zhihong.wang@intel.com, xiao.w.wang@intel.com,\n ferruh.yigit@intel.com, maxime.coquelin@redhat.com", "Date": "Fri, 3 Jul 2020 17:57:27 +0200", "Message-Id": "<20200703155727.1320821-3-amorenoz@redhat.com>", "In-Reply-To": "<20200703155727.1320821-1-amorenoz@redhat.com>", "References": "<20200703155727.1320821-1-amorenoz@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 2/2] net/virtio: add reply-ack support to\n\tVirtio-user", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Maxime Coquelin <maxime.coquelin@redhat.com>\n\nThis patch adds support reply-ack vhost-user protocol\nfeature, which is for now only used to ensure\nVHOST_USER_SET_MEM_TABLE requests are handled by the\nslave, but later will be used for VHOST_USER_SET_STATUS.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/virtio/virtio_user/vhost.h | 6 ++++-\n drivers/net/virtio/virtio_user/vhost_user.c | 24 ++++++++++++++++---\n .../net/virtio/virtio_user/virtio_user_dev.c | 3 ++-\n 3 files changed, 28 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/vhost.h b/drivers/net/virtio/virtio_user/vhost.h\nindex 9ace1a90c..260e1c308 100644\n--- a/drivers/net/virtio/virtio_user/vhost.h\n+++ b/drivers/net/virtio/virtio_user/vhost.h\n@@ -50,7 +50,11 @@ struct vhost_vring_addr {\n \n /** Protocol features. */\n #ifndef VHOST_USER_PROTOCOL_F_MQ\n-#define VHOST_USER_PROTOCOL_F_MQ\t0\n+#define VHOST_USER_PROTOCOL_F_MQ 0\n+#endif\n+\n+#ifndef VHOST_USER_PROTOCOL_F_REPLY_ACK\n+#define VHOST_USER_PROTOCOL_F_REPLY_ACK 3\n #endif\n \n enum vhost_user_request {\ndiff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c\nindex e33067561..631d0e353 100644\n--- a/drivers/net/virtio/virtio_user/vhost_user.c\n+++ b/drivers/net/virtio/virtio_user/vhost_user.c\n@@ -32,6 +32,7 @@ struct vhost_user_msg {\n \n #define VHOST_USER_VERSION_MASK 0x3\n #define VHOST_USER_REPLY_MASK (0x1 << 2)\n+#define VHOST_USER_NEED_REPLY_MASK (0x1 << 3)\n \tuint32_t flags;\n \tuint32_t size; /* the following payload size */\n \tunion {\n@@ -253,6 +254,7 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \tstruct vhost_user_msg msg;\n \tstruct vhost_vring_file *file = 0;\n \tint need_reply = 0;\n+\tint has_reply_ack;\n \tint fds[VHOST_MEMORY_MAX_NREGIONS];\n \tint fd_num = 0;\n \tint len;\n@@ -265,6 +267,9 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \tif (dev->is_server && vhostfd < 0)\n \t\treturn -1;\n \n+\tif (dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK))\n+\t\thas_reply_ack = 1;\n+\n \tmsg.request = req;\n \tmsg.flags = VHOST_USER_VERSION;\n \tmsg.size = 0;\n@@ -293,6 +298,9 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \t\tmsg.size = sizeof(m.payload.memory.nregions);\n \t\tmsg.size += sizeof(m.payload.memory.padding);\n \t\tmsg.size += fd_num * sizeof(struct vhost_memory_region);\n+\n+\t\tif (has_reply_ack)\n+\t\t\tmsg.flags |= VHOST_USER_NEED_REPLY_MASK;\n \t\tbreak;\n \n \tcase VHOST_USER_SET_LOG_FD:\n@@ -341,7 +349,7 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \t\treturn -1;\n \t}\n \n-\tif (need_reply) {\n+\tif (need_reply || msg.flags & VHOST_USER_NEED_REPLY_MASK) {\n \t\tif (vhost_user_read(vhostfd, &msg) < 0) {\n \t\t\tPMD_DRV_LOG(ERR, \"Received msg failed: %s\",\n \t\t\t\t strerror(errno));\n@@ -371,8 +379,18 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \t\t\t sizeof(struct vhost_vring_state));\n \t\t\tbreak;\n \t\tdefault:\n-\t\t\tPMD_DRV_LOG(ERR, \"Received unexpected msg type\");\n-\t\t\treturn -1;\n+\t\t\t/* Reply-ack handling */\n+\t\t\tif (msg.size != sizeof(m.payload.u64)) {\n+\t\t\t\tPMD_DRV_LOG(ERR, \"Received bad msg size\");\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\n+\t\t\tif (msg.payload.u64 != 0) {\n+\t\t\t\tPMD_DRV_LOG(ERR, \"Slave replied NACK\");\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\n+\t\t\tbreak;\n \t\t}\n \t}\n \ndiff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 105536d35..0a6991bcc 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -423,7 +423,8 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)\n \t 1ULL << VHOST_USER_F_PROTOCOL_FEATURES)\n \n #define VIRTIO_USER_SUPPORTED_PROTOCOL_FEATURES\t\t\\\n-\t(1ULL << VHOST_USER_PROTOCOL_F_MQ)\n+\t(1ULL << VHOST_USER_PROTOCOL_F_MQ |\t\t\\\n+\t 1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK)\n \n int\n virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n", "prefixes": [ "v4", "2/2" ] }