Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73031/?format=api
{ "id": 73031, "url": "https://patches.dpdk.org/api/patches/73031/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200703111644.73351-4-gordon.noonan@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200703111644.73351-4-gordon.noonan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200703111644.73351-4-gordon.noonan@intel.com", "date": "2020-07-03T11:16:39", "name": "[RFC,3/8] common/iavf: add large vsi queue config", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2801235a1a07a7a5e17ca347256ed90c6727d5e3", "submitter": { "id": 1810, "url": "https://patches.dpdk.org/api/people/1810/?format=api", "name": null, "email": "Gordon@dpdk.org, Noonan@dpdk.org, gordon.noonan@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200703111644.73351-4-gordon.noonan@intel.com/mbox/", "series": [ { "id": 10779, "url": "https://patches.dpdk.org/api/series/10779/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10779", "date": "2020-07-03T11:16:36", "name": "net/iavf: Enable 256 queues", "version": 1, "mbox": "https://patches.dpdk.org/series/10779/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73031/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/73031/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B712EA0519;\n\tFri, 3 Jul 2020 16:39:38 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8D0C01DC7D;\n\tFri, 3 Jul 2020 16:37:59 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id E31F71D8CF\n for <dev@dpdk.org>; Fri, 3 Jul 2020 13:17:14 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Jul 2020 04:17:14 -0700", "from silpixa00400380.ir.intel.com ([10.237.213.188])\n by FMSMGA003.fm.intel.com with ESMTP; 03 Jul 2020 04:17:13 -0700" ], "IronPort-SDR": [ "\n h1iaqFVc8iUTWnA74MsCFQ6GoJFFfwaEaHZupgyJ6ptJgaA7bWWNGjWqiNipesd4uEm6jp4MSj\n 3aC+qZn9f7Ew==", "\n q/nY6ehPM85UD6vLWO7O1MsEDGzsKIm8/zn3UAjUTIxA/qYftYMSvtNEPp/rMURZnpi1TyC+BT\n 6HJl2dK9NMjg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9670\"; a=\"146220546\"", "E=Sophos;i=\"5.75,308,1589266800\"; d=\"scan'208\";a=\"146220546\"", "E=Sophos;i=\"5.75,308,1589266800\"; d=\"scan'208\";a=\"321780314\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Gordon@dpdk.org, Noonan@dpdk.org, gordon.noonan@intel.com", "To": "dev@dpdk.org", "Cc": "gordon.noonan@intel.com,\n\tQi Zhang <qi.z.zhang@intel.com>", "Date": "Fri, 3 Jul 2020 12:16:39 +0100", "Message-Id": "<20200703111644.73351-4-gordon.noonan@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200703111644.73351-1-gordon.noonan@intel.com>", "References": "<20200703111644.73351-1-gordon.noonan@intel.com>", "X-Mailman-Approved-At": "Fri, 03 Jul 2020 16:37:41 +0200", "Subject": "[dpdk-dev] [PATCH RFC 3/8] common/iavf: add large vsi queue config", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Qi Zhang <qi.z.zhang@intel.com>\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/common/iavf/virtchnl.h | 54 ++++++++++++++++++++++++++++++++++\n drivers/net/iavf/iavf_vchnl.c | 6 ++--\n 2 files changed, 57 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h\nindex 5b0455fb4..caac3468e 100644\n--- a/drivers/common/iavf/virtchnl.h\n+++ b/drivers/common/iavf/virtchnl.h\n@@ -143,6 +143,7 @@ enum virtchnl_ops {\n \tVIRTCHNL_OP_ENABLE_LARGE_QUEUES = 50,\n \tVIRTCHNL_OP_DISABLE_LARGE_QUEUES = 51,\n \tVIRTCHNL_OP_CONFIG_LARGE_IRQ_MAP = 52,\n+\tVIRTCHNL_OP_CONFIG_LARGE_VSI_QUEUES = 53,\n };\n \n /* These macros are used to generate compilation errors if a structure/union\n@@ -303,6 +304,17 @@ struct virtchnl_txq_info {\n \n VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_txq_info);\n \n+struct virtchnl_txq_info_2 {\n+\tu16 vsi_id;\n+\tu16 queue_id;\n+\tu16 ring_len;\t\t/* number of descriptors, multiple of 8 */\n+\tu16 reserved;\n+\tu64 dma_ring_addr;\n+};\n+\n+VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_txq_info_2);\n+\n+\n /* VIRTCHNL_OP_CONFIG_RX_QUEUE\n * VF sends this message to set up parameters for one RX queue.\n * External data buffer contains one instance of virtchnl_rxq_info.\n@@ -353,6 +365,15 @@ struct virtchnl_queue_pair_info {\n \n VIRTCHNL_CHECK_STRUCT_LEN(64, virtchnl_queue_pair_info);\n \n+struct virtchnl_large_queue_pair_info {\n+\t/* NOTE: vsi_id and queue_id should be identical for both queues. */\n+\tstruct virtchnl_txq_info_2 txq;\n+\tstruct virtchnl_rxq_info rxq;\n+};\n+\n+VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_large_queue_pair_info);\n+\n+\n struct virtchnl_vsi_queue_config_info {\n \tu16 vsi_id;\n \tu16 num_queue_pairs;\n@@ -362,6 +383,16 @@ struct virtchnl_vsi_queue_config_info {\n \n VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_vsi_queue_config_info);\n \n+struct virtchnl_large_vsi_queue_config_info {\n+\tu16 vsi_id;\n+\tu16 num_queue_pairs;\n+\tu32 pad;\n+\tstruct virtchnl_large_queue_pair_info qpair[1];\n+};\n+\n+VIRTCHNL_CHECK_STRUCT_LEN(64, virtchnl_large_vsi_queue_config_info);\n+\n+\n /* VIRTCHNL_OP_REQUEST_QUEUES\n * VF sends this message to request the PF to allocate additional queues to\n * this VF. Each VF gets a guaranteed number of queues on init but asking for\n@@ -809,6 +840,11 @@ enum virtchnl_vector_limits {\n \tVIRTCHNL_OP_CONFIG_LARGE_IRQ_MAP_MAX\t\t=\n \t\t((u16)(~0) - sizeof(struct virtchnl_large_irq_map_info)) /\n \t\tsizeof(struct virtchnl_large_vector_map),\n+\n+\tVIRTCHNL_OP_CONFIG_LARGE_VSI_QUEUES_MAX\t=\n+\t\t((u16)(~0) - sizeof(struct virtchnl_large_vsi_queue_config_info)) /\n+\t\tsizeof(struct virtchnl_large_queue_pair_info),\n+\n };\n \n /* VF reset states - these are written into the RSTAT register:\n@@ -1185,6 +1221,24 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,\n \t\t\t\t\t virtchnl_queue_pair_info));\n \t\t}\n \t\tbreak;\n+\tcase VIRTCHNL_OP_CONFIG_LARGE_VSI_QUEUES:\n+\t\tvalid_len = sizeof(struct virtchnl_large_vsi_queue_config_info);\n+\t\tif (msglen >= valid_len) {\n+\t\t\tstruct virtchnl_large_vsi_queue_config_info *vqc =\n+\t\t\t (struct virtchnl_large_vsi_queue_config_info *)msg;\n+\n+\t\t\tif (vqc->num_queue_pairs == 0 || vqc->num_queue_pairs >\n+\t\t\t VIRTCHNL_OP_CONFIG_LARGE_VSI_QUEUES_MAX) {\n+\t\t\t\terr_msg_format = true;\n+\t\t\t\tbreak;\n+\t\t\t}\n+\n+\t\t\tvalid_len += (vqc->num_queue_pairs *\n+\t\t\t\t sizeof(struct\n+\t\t\t\t\t virtchnl_large_queue_pair_info));\n+\t\t}\n+\t\tbreak;\n+\n \tcase VIRTCHNL_OP_CONFIG_IRQ_MAP:\n \t\tvalid_len = sizeof(struct virtchnl_irq_map_info);\n \t\tif (msglen >= valid_len) {\ndiff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c\nindex 2b28d0577..f9db0b3d0 100644\n--- a/drivers/net/iavf/iavf_vchnl.c\n+++ b/drivers/net/iavf/iavf_vchnl.c\n@@ -606,8 +606,8 @@ iavf_configure_queues(struct iavf_adapter *adapter)\n \tstruct iavf_tx_queue **txq =\n \t\t(struct iavf_tx_queue **)adapter->eth_dev->data->tx_queues;\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n-\tstruct virtchnl_vsi_queue_config_info *vc_config;\n-\tstruct virtchnl_queue_pair_info *vc_qp;\n+\tstruct virtchnl_large_vsi_queue_config_info *vc_config;\n+\tstruct virtchnl_large_queue_pair_info *vc_qp;\n \tstruct iavf_cmd_info args;\n \tuint16_t i, size;\n \tint err;\n@@ -668,7 +668,7 @@ iavf_configure_queues(struct iavf_adapter *adapter)\n \t}\n \n \tmemset(&args, 0, sizeof(args));\n-\targs.ops = VIRTCHNL_OP_CONFIG_VSI_QUEUES;\n+\targs.ops = VIRTCHNL_OP_CONFIG_LARGE_VSI_QUEUES;\n \targs.in_args = (uint8_t *)vc_config;\n \targs.in_args_size = size;\n \targs.out_buffer = vf->aq_resp;\n", "prefixes": [ "RFC", "3/8" ] }