Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/72999/?format=api
{ "id": 72999, "url": "https://patches.dpdk.org/api/patches/72999/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200703123933.52351-1-david.coyle@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200703123933.52351-1-david.coyle@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200703123933.52351-1-david.coyle@intel.com", "date": "2020-07-03T12:39:26", "name": "[v4,0/7] add support for DOCSIS protocol", "commit_ref": null, "pull_url": null, "state": null, "archived": false, "hash": null, "submitter": { "id": 961, "url": "https://patches.dpdk.org/api/people/961/?format=api", "name": "Coyle, David", "email": "david.coyle@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200703123933.52351-1-david.coyle@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/72999/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/72999/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 03483A0519;\n\tFri, 3 Jul 2020 15:02:23 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 39D7F1DB77;\n\tFri, 3 Jul 2020 15:02:23 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id BBE821DB5B\n for <dev@dpdk.org>; Fri, 3 Jul 2020 15:02:21 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Jul 2020 06:02:20 -0700", "from silpixa00399912.ir.intel.com (HELO\n silpixa00399912.ger.corp.intel.com) ([10.237.223.64])\n by orsmga007.jf.intel.com with ESMTP; 03 Jul 2020 06:02:15 -0700" ], "IronPort-SDR": [ "\n L6tu7tJS2ylnHrDKZw0BC/v0uAoE2JQFSHv2pjzQSNKsFFPdWhQq2YtOfzElCsC7gqBNKQU90R\n zKTsOVhW52/Q==", "\n zlRJE4y6C+CshIcMag+R6O5t6aRkFBidZ9bN5SDVKSgLhTngBvbo8oq6HXyUNHRUP47RqIpjqQ\n +VpKDAOoOo4A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9670\"; a=\"208655540\"", "E=Sophos;i=\"5.75,308,1589266800\"; d=\"scan'208\";a=\"208655540\"", "E=Sophos;i=\"5.75,308,1589266800\"; d=\"scan'208\";a=\"322412663\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "David Coyle <david.coyle@intel.com>", "To": "akhil.goyal@nxp.com, declan.doherty@intel.com,\n pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com,\n roy.fan.zhang@intel.com, konstantin.ananyev@intel.com", "Cc": "dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com,\n brendan.ryan@intel.com, hemant.agrawal@nxp.com, anoobj@marvell.com,\n ruifeng.wang@arm.com, lironh@marvell.com, rnagadheeraj@marvell.com,\n jsrikanth@marvell.com, G.Singh@nxp.com, jianjay.zhou@huawei.com,\n ravi1.kumar@amd.com, bruce.richardson@intel.com, olivier.matz@6wind.com,\n honnappa.nagarahalli@arm.com, stephen@networkplumber.org,\n alexr@mellanox.com, jerinj@marvell.com, David Coyle <david.coyle@intel.com>", "Date": "Fri, 3 Jul 2020 13:39:26 +0100", "Message-Id": "<20200703123933.52351-1-david.coyle@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200630163049.61900-1-david.coyle@intel.com>", "References": "<20200630163049.61900-1-david.coyle@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 0/7] add support for DOCSIS protocol", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Introduction\n============\n\nThis patchset adds support for the DOCSIS protocol to the DPDK Security\nAPI (rte_security), to be used by the AESNI-MB and QAT crypto devices to\ncombine and accelerate Crypto and CRC functions of the DOCSIS protocol\ninto a single operation.\n\nPerforming these functions in parallel as a single operation can enable a\nsignificant performance improvement in a DPDK-based DOCSIS MAC pipeline.\n\n\nBackground\n==========\n\nA number of approaches to combine DOCSIS Crypto and CRC functions have\nbeen discussed in the DPDK community to date, namely:\n1) adding a new rte_accelerator API, to provide a generic interface for\n combining operations of different types\n2) using rawdev through a multi-function interface, again to provide a\n generic interface for combining operations of different types\n3) adding support for DOCSIS Crypto-CRC to rte_security\n\nThe third option above is the preferred approach for the following\nreasons:\n- it addresses the immediate use case to add DOCSIS Crypto-CRC support to\n DPDK so that it can be consumed easily by cable equipment vendors\n- it uses an already existing framework in DPDK\n- it will mean much less code churn in DOCSIS applications, which already\n use rte_cryptodev for encryption/decryption\n\n\nUse Cases\n=========\n\nThe primary use case for this proposal has already been mentioned, namely\nto add DOCSIS Crypto-CRC support to DPDK:\n\n- DOCSIS MAC: Crypto-CRC\n\t- Order:\n\t\t- Downstream: CRC, Encrypt\n\t\t- Upstream: Decrypt, CRC\n\t- Specifications:\n\t\t- Crypto: 128-bit and 256-bit AES-CFB encryption variant\n\t\t for DOCSIS as described in section 11.1 of DOCSIS 3.1\n\t\t Security Specification\n\t\t (https://apps.cablelabs.com/specification/CM-SP-SECv3.1)\n\t\t- CRC: Ethernet 32-bit CRC as defined in\n\t\t Ethernet/[ISO/IEC 8802-3]\n\nNote that support for these chained operations is already available in\nthe Intel IPSec Multi-Buffer library.\n\nHowever, other DOCSIS protocol functions could be optimized too in the\nfuture using the same rte_security API for DOCSIS (e.g. Header Checksum\n(HCS) calculation).\n\nv4:\n* addressed Akhil's comments regarding documentation\n* made some code fixes\n * fixed possible NULL pointer dereference when allocating security_ctx\n in AESNI-MB and QAT PMDs\n * freed security_ctx memory when exiting AESNI-MB and QAT PMDs\n * added session IOVA verification update when creating security\n sessions in QAT PMD\n\nv3:\n* removed rte_security_op definition\n * now using rte_crypto_sym_op->auth.data fields for CRC offset and\n length as suggested by feedback from Akhil and Konstantin\n* addressed Pablo's comments\n* removed support for out-of-place for DOCSIS protocol from QAT PMD\n* updated dpdk-crypto-perf-test tool for DOCSIS\n* updated documentation\n\nv2:\n* added rte_security and rte_cryptodev code changes\n* added AESNI MB crypto PMD code changes\n* added QAT SYM crypto PMD code changes\n* added crypto unit tests\n* added security unit tests\n\nv1:\n* added proposed API changes\n* added security capabilities to aesni_mb crypto PMD\n\nDavid Coyle (7):\n security: add support for DOCSIS protocol\n cryptodev: add a note regarding DOCSIS protocol support\n crypto/aesni_mb: add support for DOCSIS protocol\n crypto/qat: add support for DOCSIS protocol\n test/crypto: add DOCSIS security test cases\n test/security: add DOCSIS capability check tests\n app/crypto-perf: add support for DOCSIS protocol\n\n app/test-crypto-perf/cperf_ops.c | 82 +-\n app/test-crypto-perf/cperf_options.h | 5 +-\n app/test-crypto-perf/cperf_options_parsing.c | 67 +-\n app/test-crypto-perf/cperf_test_throughput.c | 3 +-\n app/test-crypto-perf/cperf_test_vectors.c | 3 +-\n app/test-crypto-perf/main.c | 5 +-\n app/test-crypto-perf/meson.build | 2 +-\n app/test/test_cryptodev.c | 513 ++++++\n ...t_cryptodev_security_docsis_test_vectors.h | 1544 +++++++++++++++++\n app/test/test_security.c | 88 +\n doc/guides/cryptodevs/aesni_mb.rst | 8 +\n doc/guides/cryptodevs/features/aesni_mb.ini | 1 +\n doc/guides/cryptodevs/features/qat.ini | 1 +\n doc/guides/cryptodevs/qat.rst | 7 +\n doc/guides/prog_guide/rte_security.rst | 114 +-\n doc/guides/rel_notes/release_20_08.rst | 21 +\n doc/guides/tools/cryptoperf.rst | 5 +\n drivers/common/qat/Makefile | 3 +\n .../crypto/aesni_mb/aesni_mb_pmd_private.h | 19 +-\n drivers/crypto/aesni_mb/meson.build | 2 +-\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 301 +++-\n .../crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 125 ++\n drivers/crypto/qat/meson.build | 2 +\n drivers/crypto/qat/qat_sym.c | 71 +-\n drivers/crypto/qat/qat_sym.h | 62 +-\n drivers/crypto/qat/qat_sym_capabilities.h | 42 +\n drivers/crypto/qat/qat_sym_pmd.c | 61 +-\n drivers/crypto/qat/qat_sym_pmd.h | 4 +\n drivers/crypto/qat/qat_sym_session.c | 153 ++\n drivers/crypto/qat/qat_sym_session.h | 11 +\n lib/librte_cryptodev/rte_crypto_sym.h | 14 +\n lib/librte_security/rte_security.c | 5 +\n lib/librte_security/rte_security.h | 38 +\n 33 files changed, 3348 insertions(+), 34 deletions(-)\n create mode 100644 app/test/test_cryptodev_security_docsis_test_vectors.h", "diff": null, "prefixes": [ "v4", "0/7" ] }