Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 7283,
    "url": "https://patches.dpdk.org/api/patches/7283/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/3042915272161B4EB253DA4D77EB373A14DF7CB7@IRSMSX102.ger.corp.intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<3042915272161B4EB253DA4D77EB373A14DF7CB7@IRSMSX102.ger.corp.intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/3042915272161B4EB253DA4D77EB373A14DF7CB7@IRSMSX102.ger.corp.intel.com",
    "date": "2015-09-29T15:06:15",
    "name": "[dpdk-dev,PATCHv4,3/9] null: extend number of virtual queues",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "0a5f54a33e63f76b965e6588839435b68a168dde",
    "submitter": {
        "id": 155,
        "url": "https://patches.dpdk.org/api/people/155/?format=api",
        "name": "Tomasz Kulasek",
        "email": "tomaszx.kulasek@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/3042915272161B4EB253DA4D77EB373A14DF7CB7@IRSMSX102.ger.corp.intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/7283/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/7283/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AE0C7CE7;\n\tTue, 29 Sep 2015 17:09:25 +0200 (CEST)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id EF10BB62\n\tfor <dev@dpdk.org>; Tue, 29 Sep 2015 17:09:23 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 29 Sep 2015 08:07:42 -0700",
            "from irsmsx109.ger.corp.intel.com ([163.33.3.23])\n\tby fmsmga002.fm.intel.com with ESMTP; 29 Sep 2015 08:06:16 -0700",
            "from irsmsx102.ger.corp.intel.com ([169.254.2.84]) by\n\tIRSMSX109.ger.corp.intel.com ([169.254.13.137]) with mapi id\n\t14.03.0248.002; Tue, 29 Sep 2015 16:06:15 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.17,608,1437462000\"; d=\"scan'208\";a=\"815371243\"",
        "From": "\"Kulasek, TomaszX\" <tomaszx.kulasek@intel.com>",
        "To": "\"Kulasek, TomaszX\" <tomaszx.kulasek@intel.com>, Tetsuya Mukawa\n\t<mukawa@igel.co.jp>, \"dev@dpdk.org\" <dev@dpdk.org>",
        "Thread-Topic": "[dpdk-dev] [PATCHv4 3/9] null: extend number of virtual queues",
        "Thread-Index": "AQHQ+l4B9r5vX1CDhEWG0x+26AjzXZ5TQSQw///+MgCAACaB0IAAM9jw",
        "Date": "Tue, 29 Sep 2015 15:06:15 +0000",
        "Message-ID": "<3042915272161B4EB253DA4D77EB373A14DF7CB7@IRSMSX102.ger.corp.intel.com>",
        "References": "<1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com>\n\t<1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com>\n\t<1436981189-3320-4-git-send-email-tomaszx.kulasek@intel.com>\n\t<5609F667.2010800@igel.co.jp>\n\t<3042915272161B4EB253DA4D77EB373A14DF7A5F@IRSMSX102.ger.corp.intel.com>\n\t<560A6934.6010904@igel.co.jp>\n\t<3042915272161B4EB253DA4D77EB373A14DF7B06@IRSMSX102.ger.corp.intel.com>",
        "In-Reply-To": "<3042915272161B4EB253DA4D77EB373A14DF7B06@IRSMSX102.ger.corp.intel.com>",
        "Accept-Language": "en-US",
        "Content-Language": "en-US",
        "X-MS-Has-Attach": "",
        "X-MS-TNEF-Correlator": "",
        "x-originating-ip": "[163.33.239.181]",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "Content-Transfer-Encoding": "base64",
        "MIME-Version": "1.0",
        "Subject": "Re: [dpdk-dev] [PATCHv4 3/9] null: extend number of virtual queues",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Hi Tetsuya,\r\n\r\nCan you check patch below?\r\n\r\nThanks,\r\nTomasz.\r\n---\r\n\r\nFrom d50b0594fa34a576602c457b51cac80e7d462eed Mon Sep 17 00:00:00 2001\r\nFrom: Tomasz Kulasek <tomaszx.kulasek@intel.com>\r\nDate: Tue, 29 Sep 2015 16:52:12 +0200\r\nSubject: [PATCH 2/4] null: extend number of virtual queues\r\n\r\n---\r\n drivers/net/null/rte_eth_null.c |   28 +++++++++++++++++++---------\r\n 1 file changed, 19 insertions(+), 9 deletions(-)\r\n\r\n--",
    "diff": "diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\r\nindex b498ef1..68cb723 100644\r\n--- a/drivers/net/null/rte_eth_null.c\r\n+++ b/drivers/net/null/rte_eth_null.c\r\n@@ -71,8 +71,8 @@ struct pmd_internals {\r\n \tunsigned nb_rx_queues;\r\n \tunsigned nb_tx_queues;\r\n \r\n-\tstruct null_queue rx_null_queues[1];\r\n-\tstruct null_queue tx_null_queues[1];\r\n+\tstruct null_queue rx_null_queues[RTE_MAX_QUEUES_PER_PORT];\r\n+\tstruct null_queue tx_null_queues[RTE_MAX_QUEUES_PER_PORT];\r\n };\r\n \r\n \r\n@@ -178,7 +178,15 @@ eth_null_copy_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\r\n }\r\n \r\n static int\r\n-eth_dev_configure(struct rte_eth_dev *dev __rte_unused) { return 0; }\r\n+eth_dev_configure(struct rte_eth_dev *dev) {\r\n+\tstruct pmd_internals *internals;\r\n+\r\n+\tinternals = dev->data->dev_private;\r\n+\tinternals->nb_rx_queues = dev->data->nb_rx_queues;\r\n+\tinternals->nb_tx_queues = dev->data->nb_tx_queues;\r\n+\r\n+\treturn 0;\r\n+}\r\n \r\n static int\r\n eth_dev_start(struct rte_eth_dev *dev)\r\n@@ -213,10 +221,11 @@ eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,\r\n \tif ((dev == NULL) || (mb_pool == NULL))\r\n \t\treturn -EINVAL;\r\n \r\n-\tif (rx_queue_id != 0)\r\n+\tinternals = dev->data->dev_private;\r\n+\r\n+\tif (rx_queue_id >= internals->nb_rx_queues)\r\n \t\treturn -ENODEV;\r\n \r\n-\tinternals = dev->data->dev_private;\r\n \tpacket_size = internals->packet_size;\r\n \r\n \tinternals->rx_null_queues[rx_queue_id].mb_pool = mb_pool;\r\n@@ -246,10 +255,11 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\r\n \tif (dev == NULL)\r\n \t\treturn -EINVAL;\r\n \r\n-\tif (tx_queue_id != 0)\r\n+\tinternals = dev->data->dev_private;\r\n+\r\n+\tif (tx_queue_id >= internals->nb_tx_queues)\r\n \t\treturn -ENODEV;\r\n \r\n-\tinternals = dev->data->dev_private;\r\n \tpacket_size = internals->packet_size;\r\n \r\n \tdev->data->tx_queues[tx_queue_id] =\r\n@@ -279,8 +289,8 @@ eth_dev_info(struct rte_eth_dev *dev,\r\n \tdev_info->driver_name = drivername;\r\n \tdev_info->max_mac_addrs = 1;\r\n \tdev_info->max_rx_pktlen = (uint32_t)-1;\r\n-\tdev_info->max_rx_queues = (uint16_t)internals->nb_rx_queues;\r\n-\tdev_info->max_tx_queues = (uint16_t)internals->nb_tx_queues;\r\n+\tdev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues);\r\n+\tdev_info->max_tx_queues = RTE_DIM(internals->tx_null_queues);\r\n \tdev_info->min_rx_bufsize = 0;\r\n \tdev_info->pci_dev = NULL;\r\n }\r\n",
    "prefixes": [
        "dpdk-dev",
        "PATCHv4",
        "3/9"
    ]
}