Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/72619/?format=api
{ "id": 72619, "url": "https://patches.dpdk.org/api/patches/72619/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200701123347.51144-8-jerinj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200701123347.51144-8-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200701123347.51144-8-jerinj@marvell.com", "date": "2020-07-01T12:33:41", "name": "[v5,07/13] drivers/event: use log register macro", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "12b50eee371e4d0d3194f25986de9c076e4503a8", "submitter": { "id": 1188, "url": "https://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200701123347.51144-8-jerinj@marvell.com/mbox/", "series": [ { "id": 10711, "url": "https://patches.dpdk.org/api/series/10711/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10711", "date": "2020-07-01T12:33:34", "name": "rte_log registration usage improvement", "version": 5, "mbox": "https://patches.dpdk.org/series/10711/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/72619/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/72619/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 55DF0A0523;\n\tWed, 1 Jul 2020 14:35:02 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 96F821D160;\n\tWed, 1 Jul 2020 14:34:48 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id E3F2F1C238\n for <dev@dpdk.org>; Wed, 1 Jul 2020 14:34:46 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 061CVsZC003288; Wed, 1 Jul 2020 05:34:45 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 31y0ws4mha-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 01 Jul 2020 05:34:45 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 1 Jul 2020 05:34:44 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 1 Jul 2020 05:34:44 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 1 Jul 2020 05:34:44 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id 4CD293F703F;\n Wed, 1 Jul 2020 05:34:40 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=Wl+pkcddwQFrSuTGKaV8VwEzj0Zzz9mqkb0uFh7Q7VQ=;\n b=SozQL6nWYsBsMnOhZ7ODHNgTRWXHEcKPMYUzK9li7wyp/b5FnRCbWtrGW6oP6xDkXKcG\n kM9owvYZAiP62eadtS171Uol2QaYRqWvju7ITp1aChMkDdiOxG6W+S3JefE9ySJtBFEl\n wLJrC1whi5rIIvP3v2VXKALN5TCu5Zxu3OSxlWO8OgSJ7HTM3uzZ1qUo268Ih5bI0oW7\n mnLHci6w1b23mDEQIhPsP3QD3W7xP6W/sVJiEE89vo+tp95ACU8mxw0WCbJrZkyoIEhu\n KLhzxUaogvexvgndxWpQSdIR+CiBKcdfiB+XJLJeiiIOd4KtjFg/HBP6KXiqC+i7S5rE Cw==", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>, Nipun Gupta\n <nipun.gupta@nxp.com>, Jerin Jacob <jerinj@marvell.com>, Pavan Nikhilesh\n <pbhagavatula@marvell.com>, Liang Ma <liang.j.ma@intel.com>, Peter Mccarthy\n <peter.mccarthy@intel.com>, Harry van Haaren <harry.van.haaren@intel.com>", "CC": "<thomas@monjalon.net>, <olivier.matz@6wind.com>,\n <david.marchand@redhat.com>, <sachin.saxena@oss.nxp.com>,\n <adamx.dybkowski@intel.com>", "Date": "Wed, 1 Jul 2020 18:03:41 +0530", "Message-ID": "<20200701123347.51144-8-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200701123347.51144-1-jerinj@marvell.com>", "References": "<20200701104428.4149689-1-jerinj@marvell.com>\n <20200701123347.51144-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687\n definitions=2020-07-01_08:2020-07-01,\n 2020-07-01 signatures=0", "Subject": "[dpdk-dev] [PATCH v5 07/13] drivers/event: use log register macro", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nUse log register macro to avoid the code duplication\nin the log registration process.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\nAcked-by: Adam Dybkowski <adamx.dybkowski@intel.com>\n---\n drivers/event/dpaa/dpaa_eventdev.c | 8 +-------\n drivers/event/dpaa2/dpaa2_eventdev.c | 10 +---------\n drivers/event/octeontx/ssovf_evdev.c | 8 +-------\n drivers/event/octeontx/timvf_evdev.c | 9 +--------\n drivers/event/opdl/opdl_evdev.c | 8 +-------\n drivers/event/opdl/opdl_ring.c | 2 --\n drivers/event/sw/sw_evdev.c | 11 +----------\n 7 files changed, 6 insertions(+), 50 deletions(-)", "diff": "diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c\nindex 5a018d487..e78728b7e 100644\n--- a/drivers/event/dpaa/dpaa_eventdev.c\n+++ b/drivers/event/dpaa/dpaa_eventdev.c\n@@ -46,7 +46,7 @@\n * Eventqueue = Channel Instance\n * 1 Eventdev can have N Eventqueue\n */\n-int dpaa_logtype_eventdev;\n+RTE_LOG_REGISTER(dpaa_logtype_eventdev, pmd.event.dpaa, NOTICE);\n \n #define DISABLE_INTR_MODE \"disable_intr\"\n \n@@ -1069,9 +1069,3 @@ static struct rte_vdev_driver vdev_eventdev_dpaa_pmd = {\n RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_DPAA_PMD, vdev_eventdev_dpaa_pmd);\n RTE_PMD_REGISTER_PARAM_STRING(EVENTDEV_NAME_DPAA_PMD,\n \t\tDISABLE_INTR_MODE \"=<int>\");\n-RTE_INIT(dpaa_event_init_log)\n-{\n-\tdpaa_logtype_eventdev = rte_log_register(\"pmd.event.dpaa\");\n-\tif (dpaa_logtype_eventdev >= 0)\n-\t\trte_log_set_level(dpaa_logtype_eventdev, RTE_LOG_NOTICE);\n-}\ndiff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c\nindex a196ad4c6..a545baf34 100644\n--- a/drivers/event/dpaa2/dpaa2_eventdev.c\n+++ b/drivers/event/dpaa2/dpaa2_eventdev.c\n@@ -48,8 +48,6 @@\n * Soft Event Flow is DPCI Instance\n */\n \n-/* Dynamic logging identified for mempool */\n-int dpaa2_logtype_event;\n #define DPAA2_EV_TX_RETRY_COUNT 10000\n \n static uint16_t\n@@ -1205,10 +1203,4 @@ static struct rte_vdev_driver vdev_eventdev_dpaa2_pmd = {\n };\n \n RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_DPAA2_PMD, vdev_eventdev_dpaa2_pmd);\n-\n-RTE_INIT(dpaa2_eventdev_init_log)\n-{\n-\tdpaa2_logtype_event = rte_log_register(\"pmd.event.dpaa2\");\n-\tif (dpaa2_logtype_event >= 0)\n-\t\trte_log_set_level(dpaa2_logtype_event, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(dpaa2_logtype_event, pmd.event.dpaa2, NOTICE);\ndiff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c\nindex 1b1a5d939..4fc4e8f7e 100644\n--- a/drivers/event/octeontx/ssovf_evdev.c\n+++ b/drivers/event/octeontx/ssovf_evdev.c\n@@ -20,15 +20,9 @@\n #include \"ssovf_evdev.h\"\n #include \"timvf_evdev.h\"\n \n-int otx_logtype_ssovf;\n static uint8_t timvf_enable_stats;\n \n-RTE_INIT(otx_ssovf_init_log)\n-{\n-\totx_logtype_ssovf = rte_log_register(\"pmd.event.octeontx\");\n-\tif (otx_logtype_ssovf >= 0)\n-\t\trte_log_set_level(otx_logtype_ssovf, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(otx_logtype_ssovf, pmd.event.octeontx, NOTICE);\n \n /* SSOPF Mailbox messages */\n \ndiff --git a/drivers/event/octeontx/timvf_evdev.c b/drivers/event/octeontx/timvf_evdev.c\nindex caa129087..c61aacacc 100644\n--- a/drivers/event/octeontx/timvf_evdev.c\n+++ b/drivers/event/octeontx/timvf_evdev.c\n@@ -4,14 +4,7 @@\n \n #include \"timvf_evdev.h\"\n \n-int otx_logtype_timvf;\n-\n-RTE_INIT(otx_timvf_init_log)\n-{\n-\totx_logtype_timvf = rte_log_register(\"pmd.event.octeontx.timer\");\n-\tif (otx_logtype_timvf >= 0)\n-\t\trte_log_set_level(otx_logtype_timvf, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(otx_logtype_timvf, pmd.event.octeontx.timer, NOTICE);\n \n struct __rte_packed timvf_mbox_dev_info {\n \tuint64_t ring_active[4];\ndiff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c\nindex 3beca8957..9b2f75fe3 100644\n--- a/drivers/event/opdl/opdl_evdev.c\n+++ b/drivers/event/opdl/opdl_evdev.c\n@@ -754,13 +754,7 @@ static struct rte_vdev_driver evdev_opdl_pmd_drv = {\n \t.remove = opdl_remove\n };\n \n-RTE_INIT(opdl_init_log)\n-{\n-\topdl_logtype_driver = rte_log_register(\"pmd.event.opdl.driver\");\n-\tif (opdl_logtype_driver >= 0)\n-\t\trte_log_set_level(opdl_logtype_driver, RTE_LOG_INFO);\n-}\n-\n+RTE_LOG_REGISTER(opdl_logtype_driver, pmd.event.opdl.driver, INFO);\n \n RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_OPDL_PMD, evdev_opdl_pmd_drv);\n RTE_PMD_REGISTER_PARAM_STRING(event_opdl, NUMA_NODE_ARG \"=<int>\"\ndiff --git a/drivers/event/opdl/opdl_ring.c b/drivers/event/opdl/opdl_ring.c\nindex c8d19fef5..69392b56b 100644\n--- a/drivers/event/opdl/opdl_ring.c\n+++ b/drivers/event/opdl/opdl_ring.c\n@@ -31,8 +31,6 @@\n #define OPDL_OPA_MASK (0xFF)\n #define OPDL_OPA_OFFSET (0x38)\n \n-int opdl_logtype_driver;\n-\n /* Types of dependency between stages */\n enum dep_type {\n \tDEP_NONE = 0, /* no dependency */\ndiff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c\nindex fb8e8bebb..98dae7164 100644\n--- a/drivers/event/sw/sw_evdev.c\n+++ b/drivers/event/sw/sw_evdev.c\n@@ -1083,13 +1083,4 @@ static struct rte_vdev_driver evdev_sw_pmd_drv = {\n RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_SW_PMD, evdev_sw_pmd_drv);\n RTE_PMD_REGISTER_PARAM_STRING(event_sw, NUMA_NODE_ARG \"=<int> \"\n \t\tSCHED_QUANTA_ARG \"=<int>\" CREDIT_QUANTA_ARG \"=<int>\");\n-\n-/* declared extern in header, for access from other .c files */\n-int eventdev_sw_log_level;\n-\n-RTE_INIT(evdev_sw_init_log)\n-{\n-\teventdev_sw_log_level = rte_log_register(\"pmd.event.sw\");\n-\tif (eventdev_sw_log_level >= 0)\n-\t\trte_log_set_level(eventdev_sw_log_level, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(eventdev_sw_log_level, pmd.event.sw, NOTICE);\n", "prefixes": [ "v5", "07/13" ] }