Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/72570/?format=api
https://patches.dpdk.org/api/patches/72570/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200701065212.41391-49-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200701065212.41391-49-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200701065212.41391-49-ajit.khaparde@broadcom.com", "date": "2020-07-01T06:52:09", "name": "[v2,48/51] net/bnxt: fill cfa action in the Tx descriptor", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5121979f4c7a3d800d0bf94030ea6690eec94ee8", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200701065212.41391-49-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 10703, "url": "https://patches.dpdk.org/api/series/10703/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10703", "date": "2020-07-01T06:51:22", "name": "add features for host-based flow management", "version": 2, "mbox": "https://patches.dpdk.org/series/10703/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/72570/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/72570/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DE214A0350;\n\tWed, 1 Jul 2020 09:03:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 657D51D56C;\n\tWed, 1 Jul 2020 08:53:23 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 73AB81C1B1\n for <dev@dpdk.org>; Wed, 1 Jul 2020 08:52:33 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 7689530C35D;\n Tue, 30 Jun 2020 23:52:32 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.185.215])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id EB0DB14008C;\n Tue, 30 Jun 2020 23:52:31 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 7689530C35D", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1593586352;\n bh=//+iAZ20jFABTeYpKr2yrNUdSbcAf100ns+h7xEX7Ok=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=gqUE0p3N/Fl9jaWRDpcfuT+EnNctGkYbCmrayqeUpGZeIMeHcJeuwqrAZ4R4wHT5F\n qVPXPa12wFV6OTY0IGYxJMvt4CQPeDCPMHdIsUeoucCZPf3Vx9KJaGLGQaLKNRc/NV\n 5Q9reHlvOuo3SoExjbI0l9aMVrTkd/AFBfvthrBQ=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Tue, 30 Jun 2020 23:52:09 -0700", "Message-Id": "<20200701065212.41391-49-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200701065212.41391-1-ajit.khaparde@broadcom.com>", "References": "<20200612132934.16488-1-somnath.kotur@broadcom.com>\n <20200701065212.41391-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 48/51] net/bnxt: fill cfa action in the Tx\n\tdescriptor", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n\nCurrently, only vfrep transmit requires cfa_action to be filled\nin the tx buffer descriptor. However with truflow, dpdk(non vfrep)\nto port also requires cfa_action to be filled in the tx buffer\ndescriptor.\n\nThis patch uses the correct cfa_action pointer while transmitting\nthe packet. Based on whether the packet is transmitted on non-vfrep\nor vfrep, tx_cfa_action or vfr_tx_cfa_action inside txq will be\nfilled in the tx buffer descriptor.\n\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_txr.c | 18 +++++++++++++++---\n 1 file changed, 15 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex d7e193d38..f5884268e 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -131,7 +131,9 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\t\t\tPKT_TX_VLAN_PKT | PKT_TX_OUTER_IP_CKSUM |\n \t\t\t\tPKT_TX_TUNNEL_GRE | PKT_TX_TUNNEL_VXLAN |\n \t\t\t\tPKT_TX_TUNNEL_GENEVE | PKT_TX_IEEE1588_TMST |\n-\t\t\t\tPKT_TX_QINQ_PKT) || txq->tx_cfa_action)\n+\t\t\t\tPKT_TX_QINQ_PKT) ||\n+\t txq->bp->ulp_ctx->cfg_data->tx_cfa_action ||\n+\t txq->vfr_tx_cfa_action)\n \t\tlong_bd = true;\n \n \tnr_bds = long_bd + tx_pkt->nb_segs;\n@@ -184,7 +186,15 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \tif (long_bd) {\n \t\ttxbd->flags_type |= TX_BD_LONG_TYPE_TX_BD_LONG;\n \t\tvlan_tag_flags = 0;\n-\t\tcfa_action = txq->tx_cfa_action;\n+\n+\t\tif (BNXT_TRUFLOW_EN(txq->bp)) {\n+\t\t\tif (txq->vfr_tx_cfa_action)\n+\t\t\t\tcfa_action = txq->vfr_tx_cfa_action;\n+\t\t\telse\n+\t\t\t\tcfa_action =\n+\t\t\t\t txq->bp->ulp_ctx->cfg_data->tx_cfa_action;\n+\t\t}\n+\n \t\t/* HW can accelerate only outer vlan in QinQ mode */\n \t\tif (tx_buf->mbuf->ol_flags & PKT_TX_QINQ_PKT) {\n \t\t\tvlan_tag_flags = TX_BD_LONG_CFA_META_KEY_VLAN_TAG |\n@@ -212,7 +222,9 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\t\t\t\t&txr->tx_desc_ring[txr->tx_prod];\n \t\ttxbd1->lflags = 0;\n \t\ttxbd1->cfa_meta = vlan_tag_flags;\n-\t\ttxbd1->cfa_action = cfa_action;\n+\n+\t\tif (BNXT_TRUFLOW_EN(txq->bp))\n+\t\t\ttxbd1->cfa_action = cfa_action;\n \n \t\tif (tx_pkt->ol_flags & PKT_TX_TCP_SEG) {\n \t\t\tuint16_t hdr_size;\n", "prefixes": [ "v2", "48/51" ] }{ "id": 72570, "url": "