Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7252/?format=api
{ "id": 7252, "url": "https://patches.dpdk.org/api/patches/7252/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1443531824-22767-11-git-send-email-jing.d.chen@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1443531824-22767-11-git-send-email-jing.d.chen@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1443531824-22767-11-git-send-email-jing.d.chen@intel.com", "date": "2015-09-29T13:03:40", "name": "[dpdk-dev,10/14] fm10k: add func to release mbuf in case Vector RX applied", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "612d9941a20cb5eedde35bfb9a970c8dc9f37e8b", "submitter": { "id": 40, "url": "https://patches.dpdk.org/api/people/40/?format=api", "name": "Chen, Jing D", "email": "jing.d.chen@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1443531824-22767-11-git-send-email-jing.d.chen@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7252/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7252/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2D0B98DA1;\n\tTue, 29 Sep 2015 15:04:33 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 487013787\n\tfor <dev@dpdk.org>; Tue, 29 Sep 2015 15:04:31 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP; 29 Sep 2015 06:04:26 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga002.jf.intel.com with ESMTP; 29 Sep 2015 06:04:26 -0700", "from shecgisg003.sh.intel.com (shecgisg003.sh.intel.com\n\t[10.239.29.90])\n\tby shvmail01.sh.intel.com with ESMTP id t8TD4Nit005568;\n\tTue, 29 Sep 2015 21:04:23 +0800", "from shecgisg003.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t8TD4KO5022872; Tue, 29 Sep 2015 21:04:22 +0800", "(from jingche2@localhost)\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/Submit) id t8TD4KOL022868; \n\tTue, 29 Sep 2015 21:04:20 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,608,1437462000\"; d=\"scan'208\";a=\"815431191\"", "From": "\"Chen Jing D(Mark)\" <jing.d.chen@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 29 Sep 2015 21:03:40 +0800", "Message-Id": "<1443531824-22767-11-git-send-email-jing.d.chen@intel.com>", "X-Mailer": "git-send-email 1.7.12.2", "In-Reply-To": "<1443531824-22767-1-git-send-email-jing.d.chen@intel.com>", "References": "<1443531824-22767-1-git-send-email-jing.d.chen@intel.com>", "Subject": "[dpdk-dev] [PATCH 10/14] fm10k: add func to release mbuf in case\n\tVector RX applied", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Chen Jing D(Mark)\" <jing.d.chen@intel.com>\n\nSince Vector RX use different variables to trace RX HW ring, it\nleads to need different func to release mbuf properly.\n\nSigned-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>\n---\n drivers/net/fm10k/fm10k.h | 1 +\n drivers/net/fm10k/fm10k_ethdev.c | 6 ++++++\n drivers/net/fm10k/fm10k_rxtx_vec.c | 18 ++++++++++++++++++\n 3 files changed, 25 insertions(+), 0 deletions(-)", "diff": "diff --git a/drivers/net/fm10k/fm10k.h b/drivers/net/fm10k/fm10k.h\nindex d22debe..b7f3cc5 100644\n--- a/drivers/net/fm10k/fm10k.h\n+++ b/drivers/net/fm10k/fm10k.h\n@@ -329,6 +329,7 @@ uint16_t fm10k_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \n int fm10k_rxq_vec_setup(struct fm10k_rx_queue *rxq);\n int fm10k_rx_vec_condition_check(struct rte_eth_dev *);\n+void fm10k_rx_queue_release_mbufs_vec(struct fm10k_rx_queue *rxq);\n uint16_t fm10k_recv_pkts_vec(void *, struct rte_mbuf **, uint16_t);\n uint16_t fm10k_recv_scattered_pkts_vec(void *, struct rte_mbuf **,\n \t\t\t\t\tuint16_t);\ndiff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 53c4ef1..2c3d8be 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -143,6 +143,12 @@ rx_queue_clean(struct fm10k_rx_queue *q)\n \tfor (i = 0; i < q->nb_desc; ++i)\n \t\tq->hw_ring[i] = zero;\n \n+\t/* vPMD driver has a different way of releasing mbufs. */\n+\tif (q->rx_using_sse) {\n+\t\tfm10k_rx_queue_release_mbufs_vec(q);\n+\t\treturn;\n+\t}\n+\n \t/* free software buffers */\n \tfor (i = 0; i < q->nb_desc; ++i) {\n \t\tif (q->sw_ring[i]) {\ndiff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c b/drivers/net/fm10k/fm10k_rxtx_vec.c\nindex afeca50..d0b0141 100644\n--- a/drivers/net/fm10k/fm10k_rxtx_vec.c\n+++ b/drivers/net/fm10k/fm10k_rxtx_vec.c\n@@ -313,6 +313,24 @@ fm10k_rxq_rearm(struct fm10k_rx_queue *rxq)\n \tFM10K_PCI_REG_WRITE(rxq->tail_ptr, rx_id);\n }\n \n+void __attribute__((cold))\n+fm10k_rx_queue_release_mbufs_vec(struct fm10k_rx_queue *rxq)\n+{\n+\tconst unsigned mask = rxq->nb_desc - 1;\n+\tunsigned i;\n+\n+\tif (rxq->sw_ring == NULL || rxq->rxrearm_nb >= rxq->nb_desc)\n+\t\treturn;\n+\n+\t/* free all mbufs that are valid in the ring */\n+\tfor (i = rxq->next_dd; i != rxq->rxrearm_start; i = (i + 1) & mask)\n+\t\trte_pktmbuf_free_seg(rxq->sw_ring[i]);\n+\trxq->rxrearm_nb = rxq->nb_desc;\n+\n+\t/* set all entries to NULL */\n+\tmemset(rxq->sw_ring, 0, sizeof(rxq->sw_ring[0]) * rxq->nb_desc);\n+}\n+\n /*\n * vPMD receive routine, now only accept (nb_pkts == RTE_IXGBE_VPMD_RX_BURST)\n * in one loop\n", "prefixes": [ "dpdk-dev", "10/14" ] }