Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/72489/?format=api
{ "id": 72489, "url": "https://patches.dpdk.org/api/patches/72489/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200701035840.4028056-12-jerinj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200701035840.4028056-12-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200701035840.4028056-12-jerinj@marvell.com", "date": "2020-07-01T03:58:38", "name": "[v2,11/13] drivers/bus: use log register macro", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a7438a274b9219388126a7ff8d2da4723cea9e72", "submitter": { "id": 1188, "url": "https://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200701035840.4028056-12-jerinj@marvell.com/mbox/", "series": [ { "id": 10697, "url": "https://patches.dpdk.org/api/series/10697/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10697", "date": "2020-07-01T03:58:27", "name": "rte_log registration usage improvement", "version": 2, "mbox": "https://patches.dpdk.org/series/10697/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/72489/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/72489/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 37D5AA0350;\n\tWed, 1 Jul 2020 06:01:03 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 290971BFC0;\n\tWed, 1 Jul 2020 06:00:26 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 9886D1BFC0\n for <dev@dpdk.org>; Wed, 1 Jul 2020 06:00:23 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 0613tWfd001239; Tue, 30 Jun 2020 21:00:22 -0700", "from sc-exch03.marvell.com ([199.233.58.183])\n by mx0a-0016f401.pphosted.com with ESMTP id 31y0ws2wqb-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 30 Jun 2020 21:00:22 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Tue, 30 Jun 2020 21:00:21 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Tue, 30 Jun 2020 21:00:21 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id 148893F7043;\n Tue, 30 Jun 2020 21:00:17 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=i5PoeEqgA2mcueehtVVrLl6zLqxuxA9NXFsMMHmSJXo=;\n b=fFta8xrgBDpNdC09Ks0cYrtRbkvqeWLvDrn2w3Tf5RijYVfIpV1cYuOnAcdxvbmS3PA2\n e81VxI5thu8RiJlvkI8iasuJscOCrH7XIdgVSWfZirstfuRFc6RpEkqVYRQ7gFqJz2do\n /BtCpne7H7Zd++069TdXhKQkeF5LkJ5uuMJy4luRJGywdyARZR69qLvatjpvzQSoTqJr\n 6PVNphULGsed71b578RXGMAarNwiT9Js+ixgiES7id73jQ+HrbMawesZG9iaaRqKw1VH\n hIJ5xNMUR0CBkkCJ/rcOqhNJctfQsGrPZA+QWXep3AvX5rt3sKopx1HyqS1f6Fjo+UDm sw==", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena\n <sachin.saxena@nxp.com>, Rosen Xu <rosen.xu@intel.com>, Stephen Hemminger\n <sthemmin@microsoft.com>", "CC": "<thomas@monjalon.net>, <olivier.matz@6wind.com>,\n <david.marchand@redhat.com>, <sachin.saxena@oss.nxp.com>,\n <adamx.dybkowski@intel.com>, Jerin Jacob <jerinj@marvell.com>", "Date": "Wed, 1 Jul 2020 09:28:38 +0530", "Message-ID": "<20200701035840.4028056-12-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200701035840.4028056-1-jerinj@marvell.com>", "References": "<20200617063047.1555518-1-jerinj@marvell.com>\n <20200701035840.4028056-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687\n definitions=2020-07-01_01:2020-07-01,\n 2020-06-30 signatures=0", "Subject": "[dpdk-dev] [PATCH v2 11/13] drivers/bus: use log register macro", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nUse log register macro to avoid the code duplication\nin the log registration process.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\nAcked-by: Sachin Saxena <sachin.saxena@oss.nxp.com>\nAcked-by: Adam Dybkowski <adamx.dybkowski@intel.com>\n---\n drivers/bus/dpaa/dpaa_bus.c | 10 +---------\n drivers/bus/fslmc/fslmc_bus.c | 11 +----------\n drivers/bus/ifpga/ifpga_bus.c | 9 +--------\n drivers/bus/vdev/vdev.c | 10 +---------\n drivers/bus/vmbus/vmbus_common.c | 9 +--------\n 5 files changed, 5 insertions(+), 44 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c\nindex d53fe6083..0d8b13e5f 100644\n--- a/drivers/bus/dpaa/dpaa_bus.c\n+++ b/drivers/bus/dpaa/dpaa_bus.c\n@@ -42,8 +42,6 @@\n #include <fsl_bman.h>\n #include <netcfg.h>\n \n-int dpaa_logtype_bus;\n-\n static struct rte_dpaa_bus rte_dpaa_bus;\n struct netcfg_info *dpaa_netcfg;\n \n@@ -749,10 +747,4 @@ static struct rte_dpaa_bus rte_dpaa_bus = {\n };\n \n RTE_REGISTER_BUS(FSL_DPAA_BUS_NAME, rte_dpaa_bus.bus);\n-\n-RTE_INIT(dpaa_init_log)\n-{\n-\tdpaa_logtype_bus = rte_log_register(\"bus.dpaa\");\n-\tif (dpaa_logtype_bus >= 0)\n-\t\trte_log_set_level(dpaa_logtype_bus, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(dpaa_logtype_bus, bus.dpaa, NOTICE);\ndiff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c\nindex afbd82e8d..d9f403bd9 100644\n--- a/drivers/bus/fslmc/fslmc_bus.c\n+++ b/drivers/bus/fslmc/fslmc_bus.c\n@@ -21,8 +21,6 @@\n \n #include <dpaax_iova_table.h>\n \n-int dpaa2_logtype_bus;\n-\n #define VFIO_IOMMU_GROUP_PATH \"/sys/kernel/iommu_groups\"\n #define FSLMC_BUS_NAME\tfslmc\n \n@@ -649,11 +647,4 @@ struct rte_fslmc_bus rte_fslmc_bus = {\n };\n \n RTE_REGISTER_BUS(FSLMC_BUS_NAME, rte_fslmc_bus.bus);\n-\n-RTE_INIT(fslmc_init_log)\n-{\n-\t/* Bus level logs */\n-\tdpaa2_logtype_bus = rte_log_register(\"bus.fslmc\");\n-\tif (dpaa2_logtype_bus >= 0)\n-\t\trte_log_set_level(dpaa2_logtype_bus, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(dpaa2_logtype_bus, bus.fslmc, NOTICE);\ndiff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c\nindex addbc3e86..103915d43 100644\n--- a/drivers/bus/ifpga/ifpga_bus.c\n+++ b/drivers/bus/ifpga/ifpga_bus.c\n@@ -32,7 +32,6 @@\n #include \"ifpga_logs.h\"\n #include \"ifpga_common.h\"\n \n-int ifpga_bus_logtype;\n \n /* Forward declaration to access Intel FPGA bus\n * on which iFPGA devices are connected\n@@ -474,10 +473,4 @@ static struct rte_bus rte_ifpga_bus = {\n };\n \n RTE_REGISTER_BUS(IFPGA_BUS_NAME, rte_ifpga_bus);\n-\n-RTE_INIT(ifpga_init_log)\n-{\n-\tifpga_bus_logtype = rte_log_register(\"bus.ifpga\");\n-\tif (ifpga_bus_logtype >= 0)\n-\t\trte_log_set_level(ifpga_bus_logtype, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(ifpga_bus_logtype, bus.ifpga, NOTICE);\ndiff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex a89ea2353..d746149a2 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -27,8 +27,6 @@\n \n #define VDEV_MP_KEY\t\"bus_vdev_mp\"\n \n-int vdev_logtype_bus;\n-\n /* Forward declare to access virtual bus name */\n static struct rte_bus rte_vdev_bus;\n \n@@ -557,10 +555,4 @@ static struct rte_bus rte_vdev_bus = {\n };\n \n RTE_REGISTER_BUS(vdev, rte_vdev_bus);\n-\n-RTE_INIT(vdev_init_log)\n-{\n-\tvdev_logtype_bus = rte_log_register(\"bus.vdev\");\n-\tif (vdev_logtype_bus >= 0)\n-\t\trte_log_set_level(vdev_logtype_bus, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(vdev_logtype_bus, bus.vdev, NOTICE);\ndiff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c\nindex 3adef01c9..4c9ac33ac 100644\n--- a/drivers/bus/vmbus/vmbus_common.c\n+++ b/drivers/bus/vmbus/vmbus_common.c\n@@ -22,7 +22,6 @@\n \n #include \"private.h\"\n \n-int vmbus_logtype_bus;\n extern struct rte_vmbus_bus rte_vmbus_bus;\n \n /* map a particular resource from a file */\n@@ -298,10 +297,4 @@ struct rte_vmbus_bus rte_vmbus_bus = {\n };\n \n RTE_REGISTER_BUS(vmbus, rte_vmbus_bus.bus);\n-\n-RTE_INIT(vmbus_init_log)\n-{\n-\tvmbus_logtype_bus = rte_log_register(\"bus.vmbus\");\n-\tif (vmbus_logtype_bus >= 0)\n-\t\trte_log_set_level(vmbus_logtype_bus, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(vmbus_logtype_bus, bus.vmbus, NOTICE);\n", "prefixes": [ "v2", "11/13" ] }