Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/72463/?format=api
{ "id": 72463, "url": "https://patches.dpdk.org/api/patches/72463/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200630141433.818517-8-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200630141433.818517-8-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200630141433.818517-8-bruce.richardson@intel.com", "date": "2020-06-30T14:14:33", "name": "[v3,7/7] build/pkg-config: prevent overlinking", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5614a94a66efb8766e05ad82266a3179ba480da7", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200630141433.818517-8-bruce.richardson@intel.com/mbox/", "series": [ { "id": 10690, "url": "https://patches.dpdk.org/api/series/10690/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10690", "date": "2020-06-30T14:14:26", "name": "improve DPDK static builds with meson", "version": 3, "mbox": "https://patches.dpdk.org/series/10690/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/72463/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/72463/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B9D1DA0350;\n\tTue, 30 Jun 2020 16:16:40 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1EAC61C030;\n\tTue, 30 Jun 2020 16:15:32 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 3E6511C025\n for <dev@dpdk.org>; Tue, 30 Jun 2020 16:15:31 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Jun 2020 07:15:30 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.84])\n by fmsmga004.fm.intel.com with ESMTP; 30 Jun 2020 07:15:29 -0700" ], "IronPort-SDR": [ "\n KrWQ7NaOtVGEKplNIE6rvhpDEHJD6H2Coqmg3uNIbFUo0Y9u2z/HLHb5z8mul08Jr92tYKYvww\n f6HBDSh4MpFg==", "\n 7mqCNbYDcmOR4wCv+ZdcGawMN/owd0jYplvXw7B+jYwU9CACQT3n4f517mYOkBa3L/qbwLkyg4\n 9YdGRKI1ticw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9666\"; a=\"147784799\"", "E=Sophos;i=\"5.75,297,1589266800\"; d=\"scan'208\";a=\"147784799\"", "E=Sophos;i=\"5.75,297,1589266800\"; d=\"scan'208\";a=\"303471600\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, david.marchand@redhat.com, ktraynor@redhat.com,\n bluca@debian.org, sunil.pai.g@intel.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 30 Jun 2020 15:14:33 +0100", "Message-Id": "<20200630141433.818517-8-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200630141433.818517-1-bruce.richardson@intel.com>", "References": "<20200429100831.398-1-bruce.richardson@intel.com>\n <20200630141433.818517-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 7/7] build/pkg-config: prevent overlinking", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add the --as-needed linker flag to the DPDK library list in the pkg-config\nfile so as to prevent overlinking. Without this flag, when linking\nstatically using flags from $(pkg-config --static --libs libdpdk), all DPDK\ndrivers and libs were statically linked in, but the binary was also\nrequiring all the shared versions be present to run.\n\nThe real root-cause of this issue is that the DPDK libraries need to be\nduplicated in the linker command when doing static linking, due to the\nbehaviour of pkg-config, but since that behaviour cannot be easily changed,\nthis is a simple workaround to avoid problems.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Luca Boccassi <bluca@debian.org>\nAcked-by: Sunil Pai G <sunil.pai.g@intel.com>\n---\n buildtools/pkg-config/meson.build | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/buildtools/pkg-config/meson.build b/buildtools/pkg-config/meson.build\nindex e043c5ee1..5c1e31c4d 100644\n--- a/buildtools/pkg-config/meson.build\n+++ b/buildtools/pkg-config/meson.build\n@@ -23,7 +23,7 @@ Use libdpdk.pc instead of this file to query DPDK compile/link arguments''',\n \tversion: meson.project_version(),\n \tsubdirs: [get_option('include_subdir_arch'), '.'],\n \textra_cflags: pkg_extra_cflags,\n-\tlibraries: dpdk_libraries,\n+\tlibraries: ['-Wl,--as-needed'] + dpdk_libraries,\n \tlibraries_private: dpdk_extra_ldflags)\n \n pkg.generate(name: 'DPDK', # main DPDK pkgconfig file\n", "prefixes": [ "v3", "7/7" ] }