Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7180/?format=api
https://patches.dpdk.org/api/patches/7180/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1443169692-4709-3-git-send-email-yong.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1443169692-4709-3-git-send-email-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1443169692-4709-3-git-send-email-yong.liu@intel.com", "date": "2015-09-25T08:28:07", "name": "[dpdk-dev,v1,2/7] e1000: separate lsc and rxq interrupt function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dfe08178fb5dc5d709ee1bcd8516ce1d48f25569", "submitter": { "id": 17, "url": "https://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1443169692-4709-3-git-send-email-yong.liu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7180/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7180/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5B7188E7E;\n\tFri, 25 Sep 2015 10:28:28 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id A0A2F8E71\n\tfor <dev@dpdk.org>; Fri, 25 Sep 2015 10:28:25 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga103.fm.intel.com with ESMTP; 25 Sep 2015 01:28:24 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 25 Sep 2015 01:28:25 -0700", "from shecgisg003.sh.intel.com (shecgisg003.sh.intel.com\n\t[10.239.29.90])\n\tby shvmail01.sh.intel.com with ESMTP id t8P8SLSA027753;\n\tFri, 25 Sep 2015 16:28:21 +0800", "from shecgisg003.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t8P8SJKS004760; Fri, 25 Sep 2015 16:28:21 +0800", "(from yliu84x@localhost)\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/Submit) id t8P8SJTG004756; \n\tFri, 25 Sep 2015 16:28:19 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,585,1437462000\"; d=\"scan'208\";a=\"776814705\"", "From": "Yong Liu <yong.liu@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 25 Sep 2015 16:28:07 +0800", "Message-Id": "<1443169692-4709-3-git-send-email-yong.liu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1443169692-4709-1-git-send-email-yong.liu@intel.com>", "References": "<1443169692-4709-1-git-send-email-yong.liu@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 2/7] e1000: separate lsc and rxq interrupt\n\tfunction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Marvin Liu <yong.liu@intel.com>\n\nSeparate lsc and rxq interrupt for they have different interrupt handlers.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>", "diff": "diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c\nindex 99beb9c..e86c039 100644\n--- a/drivers/net/e1000/em_ethdev.c\n+++ b/drivers/net/e1000/em_ethdev.c\n@@ -108,11 +108,13 @@ static void em_vlan_hw_strip_disable(struct rte_eth_dev *dev);\n static void eth_em_vlan_filter_set(struct rte_eth_dev *dev,\n \t\t\t\t\tuint16_t vlan_id, int on);\n */\n+static void em_lsc_intr_disable(struct e1000_hw *hw);\n static void em_rxq_intr_enable(struct e1000_hw *hw);\n+static void em_rxq_intr_disable(struct e1000_hw *hw);\n+\n static int eth_em_led_on(struct rte_eth_dev *dev);\n static int eth_em_led_off(struct rte_eth_dev *dev);\n \n-static void em_intr_disable(struct e1000_hw *hw);\n static int em_get_rx_buffer_size(struct e1000_hw *hw);\n static void eth_em_rar_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr,\n \t\tuint32_t index, uint32_t pool);\n@@ -640,7 +642,9 @@ eth_em_stop(struct rte_eth_dev *dev)\n \tstruct rte_eth_link link;\n \tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n-\tem_intr_disable(hw);\n+\tem_rxq_intr_disable(hw);\n+\tem_lsc_intr_disable(hw);\n+\n \te1000_reset_hw(hw);\n \tif (hw->mac.type >= e1000_82544)\n \t\tE1000_WRITE_REG(hw, E1000_WUC, 0);\n@@ -1254,12 +1258,6 @@ eth_em_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n \t}\n }\n \n-static void\n-em_intr_disable(struct e1000_hw *hw)\n-{\n-\tE1000_WRITE_REG(hw, E1000_IMC, ~0);\n-}\n-\n /**\n * It enables the interrupt mask and then enable the interrupt.\n *\n@@ -1302,6 +1300,31 @@ eth_em_rxq_interrupt_setup(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+/* It disabled lsc interrupt.\n+ * @param hw\n+ * Pointer to struct e1000_hw\n+ *\n+ * @return\n+ */\n+static void\n+em_lsc_intr_disable(struct e1000_hw *hw)\n+{\n+\tE1000_WRITE_REG(hw, E1000_IMC, E1000_IMS_LSC);\n+}\n+\n+/* It disabled receive packet interrupt.\n+ * @param hw\n+ * Pointer to struct e1000_hw\n+ *\n+ * @return\n+ */\n+static void\n+em_rxq_intr_disable(struct e1000_hw *hw)\n+{\n+\tE1000_READ_REG(hw, E1000_ICR);\n+\tE1000_WRITE_REG(hw, E1000_IMC, E1000_IMS_RXT0);\n+}\n+\n /* It enable receive packet interrupt.\n * @param hw\n * Pointer to struct e1000_hw\n", "prefixes": [ "dpdk-dev", "v1", "2/7" ] }{ "id": 7180, "url": "