Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71487/?format=api
{ "id": 71487, "url": "https://patches.dpdk.org/api/patches/71487/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/fee723ea666a7d525dec05a9bd7ee42d239dd18d.1591998771.git.rahul.lakkireddy@chelsio.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<fee723ea666a7d525dec05a9bd7ee42d239dd18d.1591998771.git.rahul.lakkireddy@chelsio.com>", "list_archive_url": "https://inbox.dpdk.org/dev/fee723ea666a7d525dec05a9bd7ee42d239dd18d.1591998771.git.rahul.lakkireddy@chelsio.com", "date": "2020-06-12T22:07:26", "name": "[4/5] net/cxgbe: fix SMT leak in filter error and free path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4ac4e28e88c3c49d441339ca6f965bbfc5c75899", "submitter": { "id": 241, "url": "https://patches.dpdk.org/api/people/241/?format=api", "name": "Rahul Lakkireddy", "email": "rahul.lakkireddy@chelsio.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/fee723ea666a7d525dec05a9bd7ee42d239dd18d.1591998771.git.rahul.lakkireddy@chelsio.com/mbox/", "series": [ { "id": 10446, "url": "https://patches.dpdk.org/api/series/10446/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10446", "date": "2020-06-12T22:07:22", "name": "net/cxgbe: fix rte_flow related hardware resource leaks", "version": 1, "mbox": "https://patches.dpdk.org/series/10446/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/71487/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/71487/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DCCDDA00BE;\n\tSat, 13 Jun 2020 00:20:42 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8E0CF1BF86;\n\tSat, 13 Jun 2020 00:20:30 +0200 (CEST)", "from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])\n by dpdk.org (Postfix) with ESMTP id A20E71BF86;\n Sat, 13 Jun 2020 00:20:28 +0200 (CEST)", "from localhost (scalar.blr.asicdesigners.com [10.193.185.94])\n by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 05CMKQlK009578;\n Fri, 12 Jun 2020 15:20:27 -0700" ], "From": "Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, nirranjan@chelsio.com", "Date": "Sat, 13 Jun 2020 03:37:26 +0530", "Message-Id": "\n <fee723ea666a7d525dec05a9bd7ee42d239dd18d.1591998771.git.rahul.lakkireddy@chelsio.com>", "X-Mailer": "git-send-email 2.5.3", "In-Reply-To": [ "<cover.1591998771.git.rahul.lakkireddy@chelsio.com>", "<cover.1591998771.git.rahul.lakkireddy@chelsio.com>" ], "References": [ "<cover.1591998771.git.rahul.lakkireddy@chelsio.com>", "<cover.1591998771.git.rahul.lakkireddy@chelsio.com>" ], "Subject": "[dpdk-dev] [PATCH 4/5] net/cxgbe: fix SMT leak in filter error and\n\tfree path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Free up Source MAC Table (SMT) entry properly during filter create\nfailure and filter delete.\n\nFixes: 993541b2fa4f (\"net/cxgbe: support flow API for source MAC rewrite\")\nCc: stable@dpdk.org\n\nSigned-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>\n---\n drivers/net/cxgbe/cxgbe_filter.c | 28 ++++++++++++++--------------\n drivers/net/cxgbe/smt.c | 6 ++++++\n drivers/net/cxgbe/smt.h | 1 +\n 3 files changed, 21 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/cxgbe/cxgbe_filter.c b/drivers/net/cxgbe/cxgbe_filter.c\nindex 317830f58..6066da7db 100644\n--- a/drivers/net/cxgbe/cxgbe_filter.c\n+++ b/drivers/net/cxgbe/cxgbe_filter.c\n@@ -302,6 +302,9 @@ static void clear_filter(struct filter_entry *f)\n \tif (f->fs.mask.macidx)\n \t\tcxgbe_mpstcam_remove(pi, f->fs.val.macidx);\n \n+\tif (f->smt)\n+\t\tcxgbe_smt_release(f->smt);\n+\n \t/* The zeroing of the filter rule below clears the filter valid,\n \t * pending, locked flags etc. so it's all we need for\n \t * this operation.\n@@ -777,20 +780,6 @@ static int set_filter_wr(struct rte_eth_dev *dev, unsigned int fidx)\n \tunsigned int port_id = ethdev2pinfo(dev)->port_id;\n \tint ret;\n \n-\t/* If the new filter requires Source MAC rewriting then we need to\n-\t * allocate a SMT entry for the filter\n-\t */\n-\tif (f->fs.newsmac) {\n-\t\tf->smt = cxgbe_smt_alloc_switching(f->dev, f->fs.smac);\n-\t\tif (!f->smt) {\n-\t\t\tif (f->l2t) {\n-\t\t\t\tcxgbe_l2t_release(f->l2t);\n-\t\t\t\tf->l2t = NULL;\n-\t\t\t}\n-\t\t\treturn -ENOMEM;\n-\t\t}\n-\t}\n-\n \tctrlq = &adapter->sge.ctrlq[port_id];\n \tmbuf = rte_pktmbuf_alloc(ctrlq->mb_pool);\n \tif (!mbuf) {\n@@ -1122,6 +1111,17 @@ int cxgbe_set_filter(struct rte_eth_dev *dev, unsigned int filter_id,\n \t\t}\n \t}\n \n+\t/* If the new filter requires Source MAC rewriting then we need to\n+\t * allocate a SMT entry for the filter\n+\t */\n+\tif (f->fs.newsmac) {\n+\t\tf->smt = cxgbe_smt_alloc_switching(f->dev, f->fs.smac);\n+\t\tif (!f->smt) {\n+\t\t\tret = -ENOMEM;\n+\t\t\tgoto free_tid;\n+\t\t}\n+\t}\n+\n \ticonf = adapter->params.tp.ingress_config;\n \n \t/* Either PFVF or OVLAN can be active, but not both\ndiff --git a/drivers/net/cxgbe/smt.c b/drivers/net/cxgbe/smt.c\nindex e8f38676e..b7b5a4a02 100644\n--- a/drivers/net/cxgbe/smt.c\n+++ b/drivers/net/cxgbe/smt.c\n@@ -193,6 +193,12 @@ struct smt_entry *cxgbe_smt_alloc_switching(struct rte_eth_dev *dev, u8 *smac)\n \treturn t4_smt_alloc_switching(dev, 0x0, smac);\n }\n \n+void cxgbe_smt_release(struct smt_entry *e)\n+{\n+\tif (rte_atomic32_read(&e->refcnt))\n+\t\trte_atomic32_dec(&e->refcnt);\n+}\n+\n /**\n * Initialize Source MAC Table\n */\ndiff --git a/drivers/net/cxgbe/smt.h b/drivers/net/cxgbe/smt.h\nindex be1fab8ba..92c63c876 100644\n--- a/drivers/net/cxgbe/smt.h\n+++ b/drivers/net/cxgbe/smt.h\n@@ -39,6 +39,7 @@ void t4_cleanup_smt(struct adapter *adap);\n void cxgbe_do_smt_write_rpl(struct adapter *adap,\n \t\t\t const struct cpl_smt_write_rpl *rpl);\n struct smt_entry *cxgbe_smt_alloc_switching(struct rte_eth_dev *dev, u8 *smac);\n+void cxgbe_smt_release(struct smt_entry *e);\n \n #endif /* __CXGBE_SMT_H_ */\n \n", "prefixes": [ "4/5" ] }