Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71344/?format=api
{ "id": 71344, "url": "https://patches.dpdk.org/api/patches/71344/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200612032410.20864-21-guinanx.sun@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200612032410.20864-21-guinanx.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200612032410.20864-21-guinanx.sun@intel.com", "date": "2020-06-12T03:24:09", "name": "[20/21] net/ixgbe/base: check Host Interface Return Status", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9ce12d337e7c1b4d2b144d683b932cb03f2ac15c", "submitter": { "id": 1476, "url": "https://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200612032410.20864-21-guinanx.sun@intel.com/mbox/", "series": [ { "id": 10428, "url": "https://patches.dpdk.org/api/series/10428/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10428", "date": "2020-06-12T03:23:49", "name": "update ixgbe base code", "version": 1, "mbox": "https://patches.dpdk.org/series/10428/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/71344/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/71344/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 47379A00BE;\n\tFri, 12 Jun 2020 05:49:13 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 475F21BF83;\n\tFri, 12 Jun 2020 05:46:43 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 371201BF80\n for <dev@dpdk.org>; Fri, 12 Jun 2020 05:46:41 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Jun 2020 20:46:40 -0700", "from intel.sh.intel.com ([10.239.255.18])\n by orsmga002.jf.intel.com with ESMTP; 11 Jun 2020 20:46:39 -0700" ], "IronPort-SDR": [ "\n XQhmOH8kPxHgLXqQkn8grGMMMVpqRZhI+r2PJMYzSOj4MzbZiwZICVM7WamJC4cgQOo1bk0jCs\n AR98ZS3VLoGQ==", "\n LMPOxHyBk6yWhiyk4vp1yS4Kz6nAt6byV6BU375mbM+a96bq1gp4jq976tjtVXWiLQtRhSBhAU\n sj5rl1EFXlBQ==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,501,1583222400\"; d=\"scan'208\";a=\"289759604\"", "From": "Guinan Sun <guinanx.sun@intel.com>", "To": "dev@dpdk.org", "Cc": "Guinan Sun <guinanx.sun@intel.com>,\n =?utf-8?q?Stanis=C5=82aw_Grzeszczak?= <stanislaw.a.grzeszczak@intel.com>", "Date": "Fri, 12 Jun 2020 03:24:09 +0000", "Message-Id": "<20200612032410.20864-21-guinanx.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200612032410.20864-1-guinanx.sun@intel.com>", "References": "<20200612032410.20864-1-guinanx.sun@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 20/21] net/ixgbe/base: check Host Interface\n\tReturn Status", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Writing to read-only fields returns a non-OK Return Status\nfor shadow RAM write command for X550.\nThis information was previously discarded.\n\nTesting Hints: check if write to a read-only field,\ne.g. PHY Module Pointer, returns an error.\n\nSigned-off-by: Stanisław Grzeszczak <stanislaw.a.grzeszczak@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_x550.c | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c\nindex 8343efbc2..05199abb8 100644\n--- a/drivers/net/ixgbe/base/ixgbe_x550.c\n+++ b/drivers/net/ixgbe/base/ixgbe_x550.c\n@@ -3248,7 +3248,18 @@ s32 ixgbe_write_ee_hostif_data_X550(struct ixgbe_hw *hw, u16 offset,\n \n \tstatus = ixgbe_host_interface_command(hw, (u32 *)&buffer,\n \t\t\t\t\t sizeof(buffer),\n-\t\t\t\t\t IXGBE_HI_COMMAND_TIMEOUT, false);\n+\t\t\t\t\t IXGBE_HI_COMMAND_TIMEOUT, true);\n+\tif (status != IXGBE_SUCCESS) {\n+\t\tDEBUGOUT2(\"for offset %04x failed with status %d\\n\",\n+\t\t\t offset, status);\n+\t\treturn status;\n+\t}\n+\n+\tif (buffer.hdr.rsp.buf_lenh_status != FW_CEM_RESP_STATUS_SUCCESS) {\n+\t\tDEBUGOUT2(\"for offset %04x host interface return status %02x\\n\",\n+\t\t\t offset, buffer.hdr.rsp.buf_lenh_status);\n+\t\treturn IXGBE_ERR_HOST_INTERFACE_COMMAND;\n+\t}\n \n \treturn status;\n }\n", "prefixes": [ "20/21" ] }