Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71341/?format=api
https://patches.dpdk.org/api/patches/71341/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200612032410.20864-18-guinanx.sun@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200612032410.20864-18-guinanx.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200612032410.20864-18-guinanx.sun@intel.com", "date": "2020-06-12T03:24:06", "name": "[17/21] net/ixgbe/base: improve log about autonego being disabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2620e129fc429c6564074660c9899ebb8a4f7d4c", "submitter": { "id": 1476, "url": "https://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200612032410.20864-18-guinanx.sun@intel.com/mbox/", "series": [ { "id": 10428, "url": "https://patches.dpdk.org/api/series/10428/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10428", "date": "2020-06-12T03:23:49", "name": "update ixgbe base code", "version": 1, "mbox": "https://patches.dpdk.org/series/10428/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/71341/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/71341/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 445C8A00BE;\n\tFri, 12 Jun 2020 05:48:49 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B1BA91BF74;\n\tFri, 12 Jun 2020 05:46:38 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 533A51BF44\n for <dev@dpdk.org>; Fri, 12 Jun 2020 05:46:36 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Jun 2020 20:46:36 -0700", "from intel.sh.intel.com ([10.239.255.18])\n by orsmga002.jf.intel.com with ESMTP; 11 Jun 2020 20:46:34 -0700" ], "IronPort-SDR": [ "\n lAXGXn1JF1+FZAjtGusNVgZoljyU4yg0Q0VBb1zz1fhtOyabe+Tx9gBt945QWllNXA+RG6us6I\n Q+hlQgdyWCOg==", "\n oDUEXy3N4Nd9UimeJYqD8Ij+iTKY5dg4ohjkuj2DXCHJ2epHxMqsMdciDEyjoyxE/pJ1hWhol7\n OqIxnufcqn7w==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,501,1583222400\"; d=\"scan'208\";a=\"289759590\"", "From": "Guinan Sun <guinanx.sun@intel.com>", "To": "dev@dpdk.org", "Cc": "Guinan Sun <guinanx.sun@intel.com>,\n Jakub Chylkowski <jakubx.chylkowski@intel.com>", "Date": "Fri, 12 Jun 2020 03:24:06 +0000", "Message-Id": "<20200612032410.20864-18-guinanx.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200612032410.20864-1-guinanx.sun@intel.com>", "References": "<20200612032410.20864-1-guinanx.sun@intel.com>", "Subject": "[dpdk-dev] [PATCH 17/21] net/ixgbe/base: improve log about autonego\n\tbeing disabled", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On ESXi OS, when user disables auto negotiation, the following log\nappears: \"(unsupported) Flow control autoneg is disabled\".\nIt is true that AN is disabled but it is not necessarily true that it is\nnot supported.\n\nSigned-off-by: Jakub Chylkowski <jakubx.chylkowski@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_common.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex 4a3b48b39..bc9584ae0 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -3077,8 +3077,9 @@ void ixgbe_fc_autoneg(struct ixgbe_hw *hw)\n \t * - link is not up.\n \t */\n \tif (hw->fc.disable_fc_autoneg) {\n-\t\tERROR_REPORT1(IXGBE_ERROR_UNSUPPORTED,\n-\t\t\t \"Flow control autoneg is disabled\");\n+\t\t/* TODO: This should be just an informative log */\n+\t\tERROR_REPORT1(IXGBE_ERROR_CAUTION,\n+\t\t\t \"Flow control autoneg is disabled\");\n \t\tgoto out;\n \t}\n \n", "prefixes": [ "17/21" ] }{ "id": 71341, "url": "