Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71148/?format=api
{ "id": 71148, "url": "https://patches.dpdk.org/api/patches/71148/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200610114427.22146-13-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200610114427.22146-13-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200610114427.22146-13-somnath.kotur@broadcom.com", "date": "2020-06-10T11:44:03", "name": "[12/36] net/bnxt: remove cache tbl id from the mapper class table", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f3f43532831828af8f6f83ba4b53eed5de7ed040", "submitter": { "id": 908, "url": "https://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200610114427.22146-13-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 10380, "url": "https://patches.dpdk.org/api/series/10380/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10380", "date": "2020-06-10T11:43:51", "name": "bnxt patches", "version": 1, "mbox": "https://patches.dpdk.org/series/10380/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/71148/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/71148/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3E499A051A;\n\tWed, 10 Jun 2020 13:51:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A2B011BEB2;\n\tWed, 10 Jun 2020 13:49:14 +0200 (CEST)", "from relay.smtp.broadcom.com (unknown [192.19.232.149])\n by dpdk.org (Postfix) with ESMTP id 17DC31BE9B\n for <dev@dpdk.org>; Wed, 10 Jun 2020 13:49:11 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 6B6A01BD56E;\n Wed, 10 Jun 2020 04:49:10 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 6B6A01BD56E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1591789751;\n bh=bvUWHRzjdtdMrxzOxQMQsnEGjpdbaLSn24XoHYWPR7A=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=RlhjoZmHD9AgkrbE/jgpQ11k7LGhdWQEX6B/X1Sjckm5cQwQDO9VNj1/xRw3gPNb7\n /NCELZ9CDfe8Aj8tfHGbnOCy4cB4WILf/qDLzc3vM3D7o4n57fft/errLieCrKulKp\n ghgEVHJG8IqfaOrtOvu0puSyXr4lMZFPVz5lAc24=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Wed, 10 Jun 2020 17:14:03 +0530", "Message-Id": "<20200610114427.22146-13-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200610114427.22146-1-somnath.kotur@broadcom.com>", "References": "<20200610114427.22146-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 12/36] net/bnxt: remove cache tbl id from the\n\tmapper class table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n\nThe cache table id is not needed anymore since the value can\nbe calculated from resource sub type and direction.\n\nSigned-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\nReviewed-by: Michael Baucom <michael.baucom@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/tf_ulp/ulp_mapper.c | 21 +++++++++++++++------\n drivers/net/bnxt/tf_ulp/ulp_template_db.c | 5 -----\n drivers/net/bnxt/tf_ulp/ulp_template_struct.h | 2 --\n 3 files changed, 15 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\nindex 35b5d72..5db0da7 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n@@ -324,13 +324,14 @@ ulp_mapper_ident_fields_get(struct bnxt_ulp_mapper_class_tbl_info *tbl,\n \n static struct bnxt_ulp_mapper_cache_entry *\n ulp_mapper_cache_entry_get(struct bnxt_ulp_context *ulp,\n-\t\t\t enum bnxt_ulp_cache_tbl_id id,\n+\t\t\t uint32_t id,\n \t\t\t uint16_t key)\n {\n \tstruct bnxt_ulp_mapper_data *mapper_data;\n \n \tmapper_data = bnxt_ulp_cntxt_ptr2_mapper_data_get(ulp);\n-\tif (!mapper_data || !mapper_data->cache_tbl[id]) {\n+\tif (!mapper_data || id >= BNXT_ULP_CACHE_TBL_MAX_SZ ||\n+\t !mapper_data->cache_tbl[id]) {\n \t\tBNXT_TF_DBG(ERR, \"Unable to acquire the cache tbl (%d)\\n\", id);\n \t\treturn NULL;\n \t}\n@@ -1691,8 +1692,15 @@ ulp_mapper_cache_tbl_process(struct bnxt_ulp_mapper_parms *parms,\n \t */\n \tcache_key = ulp_blob_data_get(&key, &tmplen);\n \tckey = (uint16_t *)cache_key;\n+\n+\t/*\n+\t * The id computed based on resource sub type and direction where\n+\t * dir is the bit0 and rest of the bits come from resource\n+\t * sub type.\n+\t */\n \tcache_entry = ulp_mapper_cache_entry_get(parms->ulp_ctx,\n-\t\t\t\t\t\t tbl->cache_tbl_id,\n+\t\t\t\t\t\t (tbl->resource_sub_type << 1 |\n+\t\t\t\t\t\t (tbl->direction & 0x1)),\n \t\t\t\t\t\t *ckey);\n \n \t/*\n@@ -1756,12 +1764,13 @@ ulp_mapper_cache_tbl_process(struct bnxt_ulp_mapper_parms *parms,\n \tfid_parms.resource_func\t= tbl->resource_func;\n \n \t/*\n-\t * Cache resource type is composed of both table_type and cache_tbl_id\n-\t * need to set it appropriately via setter.\n+\t * Cache resource type is composed of table_type, resource\n+\t * sub type and direction, it needs to set appropriately via setter.\n \t */\n \tulp_mapper_cache_res_type_set(&fid_parms,\n \t\t\t\t tbl->resource_type,\n-\t\t\t\t tbl->cache_tbl_id);\n+\t\t\t\t (tbl->resource_sub_type << 1 |\n+\t\t\t\t (tbl->direction & 0x1)));\n \tfid_parms.resource_hndl\t= (uint64_t)*ckey;\n \tfid_parms.critical_resource = tbl->critical_resource;\n \trc = ulp_flow_db_resource_add(parms->ulp_ctx,\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db.c b/drivers/net/bnxt/tf_ulp/ulp_template_db.c\nindex 9b793a2..140f96a 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_template_db.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_template_db.c\n@@ -606,7 +606,6 @@ struct bnxt_ulp_mapper_class_tbl_info ulp_class_tbl_list[] = {\n \t.ident_nums = 1,\n \t.mark_enable = BNXT_ULP_MARK_ENABLE_NO,\n \t.critical_resource = 0,\n-\t.cache_tbl_id = BNXT_ULP_CACHE_TBL_ID_L2_CNTXT_TCAM_INGRESS,\n \t.regfile_wr_idx = BNXT_ULP_REGFILE_INDEX_NOT_USED\n \t},\n \t{\n@@ -627,7 +626,6 @@ struct bnxt_ulp_mapper_class_tbl_info ulp_class_tbl_list[] = {\n \t.ident_nums = 0,\n \t.mark_enable = BNXT_ULP_MARK_ENABLE_NO,\n \t.critical_resource = 0,\n-\t.cache_tbl_id = 0,\n \t.regfile_wr_idx = BNXT_ULP_REGFILE_INDEX_NOT_USED\n \t},\n \t{\n@@ -648,7 +646,6 @@ struct bnxt_ulp_mapper_class_tbl_info ulp_class_tbl_list[] = {\n \t.ident_nums = 1,\n \t.mark_enable = BNXT_ULP_MARK_ENABLE_NO,\n \t.critical_resource = 0,\n-\t.cache_tbl_id = BNXT_ULP_CACHE_TBL_ID_PROFILE_TCAM_INGRESS,\n \t.regfile_wr_idx = BNXT_ULP_REGFILE_INDEX_NOT_USED\n \t},\n \t{\n@@ -669,7 +666,6 @@ struct bnxt_ulp_mapper_class_tbl_info ulp_class_tbl_list[] = {\n \t.ident_nums = 0,\n \t.mark_enable = BNXT_ULP_MARK_ENABLE_NO,\n \t.critical_resource = 0,\n-\t.cache_tbl_id = 0,\n \t.regfile_wr_idx = BNXT_ULP_REGFILE_INDEX_NOT_USED\n \t},\n \t{\n@@ -690,7 +686,6 @@ struct bnxt_ulp_mapper_class_tbl_info ulp_class_tbl_list[] = {\n \t.ident_nums = 0,\n \t.mark_enable = BNXT_ULP_MARK_ENABLE_YES,\n \t.critical_resource = 1,\n-\t.cache_tbl_id = 0,\n \t.regfile_wr_idx = BNXT_ULP_REGFILE_INDEX_NOT_USED\n \t}\n };\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_template_struct.h b/drivers/net/bnxt/tf_ulp/ulp_template_struct.h\nindex ce449d0..eebe035 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_template_struct.h\n+++ b/drivers/net/bnxt/tf_ulp/ulp_template_struct.h\n@@ -182,8 +182,6 @@ struct bnxt_ulp_mapper_class_tbl_info {\n \n \tuint8_t\t\tmark_enable;\n \tenum bnxt_ulp_regfile_index\tregfile_wr_idx;\n-\n-\tenum bnxt_ulp_cache_tbl_id cache_tbl_id;\n };\n \n struct bnxt_ulp_mapper_act_tbl_info {\n", "prefixes": [ "12/36" ] }