Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71062/?format=api
{ "id": 71062, "url": "https://patches.dpdk.org/api/patches/71062/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200609141713.11614-2-patrick.keroulas@radio-canada.ca/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200609141713.11614-2-patrick.keroulas@radio-canada.ca>", "list_archive_url": "https://inbox.dpdk.org/dev/20200609141713.11614-2-patrick.keroulas@radio-canada.ca", "date": "2020-06-09T14:17:11", "name": "[RFC,v1,1/3] net/mlx5: add timestamp-to-ns converter from libibverbs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "950ca5d6fd76d3912fc6c3b5faac67ae92ce79c2", "submitter": { "id": 1776, "url": "https://patches.dpdk.org/api/people/1776/?format=api", "name": "Patrick Keroulas", "email": "patrick.keroulas@radio-canada.ca" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200609141713.11614-2-patrick.keroulas@radio-canada.ca/mbox/", "series": [ { "id": 10361, "url": "https://patches.dpdk.org/api/series/10361/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10361", "date": "2020-06-09T14:17:10", "name": "pdump HW timestamps for mlx5", "version": 1, "mbox": "https://patches.dpdk.org/series/10361/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/71062/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/71062/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CCEBCA04FE;\n\tTue, 9 Jun 2020 16:17:54 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B24D21BEAF;\n\tTue, 9 Jun 2020 16:17:54 +0200 (CEST)", "from mail-qv1-f65.google.com (mail-qv1-f65.google.com\n [209.85.219.65]) by dpdk.org (Postfix) with ESMTP id 21BC91F28\n for <dev@dpdk.org>; Tue, 9 Jun 2020 16:17:53 +0200 (CEST)", "by mail-qv1-f65.google.com with SMTP id g11so3667018qvs.2\n for <dev@dpdk.org>; Tue, 09 Jun 2020 07:17:53 -0700 (PDT)", "from localhost.localdomain (104-163-142-249.qc.dsl.ebox.net.\n [104.163.142.249])\n by smtp.gmail.com with ESMTPSA id a82sm10287148qkb.29.2020.06.09.07.17.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 09 Jun 2020 07:17:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=radio-canada-ca.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=54vla9QLYsaLV2JqWIlKmKS5YgRmg4HzDGUmjeGuaWg=;\n b=kqDRI+k9tkAOF5hMujDEbtR5dvKwLjxDmo9t/FFfEIA9w3nI8Y7Q17elBiGtkOyaUo\n AOcQtG9IJtM/OFIuF6rMtk1znljcRvpy352rgMumQQCABcJRAlwTldePJoautV3u8Mg5\n 29fLUhSVTFjtEWU6RpCDDO2uJLw27a7NSAADyv4uqxpZwjSYq/mOXGsDT/zfPX4BgV4T\n zxQagLX2KXUIZ+qcKLoxYFsHVTnCI0PxwWJBWK0XhM5WLjsBHushsaBDuq+7E6F2UGVQ\n xA4V7nCwGy/FMseoA76QfeeVMqB6VDzFCZk938s0vYYlyA4MmQ0zIEZC/Osp2SwqTFLM\n e0Hg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=54vla9QLYsaLV2JqWIlKmKS5YgRmg4HzDGUmjeGuaWg=;\n b=cIBHrlEIJIxAQN5HiXRbg2kSFZ38Q3H9vMiG7BUne0ze3LpOI6/LT9f8JjwZsM2fWC\n +1mxDcFWzL1+EHOLoVmBlORixKANrRgdjivOQLeNpFss6NA5TGL5h4cwXEcSYU/QREP1\n x99Onvbl977yDkbZtXL5ll+EEK5l28p8tO4oA+/6UNFI8jC7f9iq+9Q+TLOQOQQdSpZ6\n oURsKZxZ90HoSGAbDZo8ZPt40M5zpztNKobJIbugpaWqZgycpIyY83SkAlGWA9vHsOJx\n xJKQlmtqyBDNsqnLUsoKBpghaW6oHg1p6XdOxWtGqWsT0uMtwpfJXCwXQGQvpxVi+xgV\n AJHw==", "X-Gm-Message-State": "AOAM53284gxLA6BaOErEoFzbQeVu/XxwcxXnlM6MNNc49A6a/WOtnWDO\n ojMtSryVcEg9fDUeKTo2LtwITPmTh5B1pw==", "X-Google-Smtp-Source": "\n ABdhPJywhmaL21V74ZIpIRHk5nka7ymvrErfVfUdtZ1I++a5e9U0brPmiSoerho/zJWpjikYzMpFPA==", "X-Received": "by 2002:ad4:47b1:: with SMTP id a17mr4126074qvz.16.1591712268886;\n Tue, 09 Jun 2020 07:17:48 -0700 (PDT)", "From": "Patrick Keroulas <patrick.keroulas@radio-canada.ca>", "To": "dev@dpdk.org", "Cc": "Patrick Keroulas <patrick.keroulas@radio-canada.ca>", "Date": "Tue, 9 Jun 2020 10:17:11 -0400", "Message-Id": "<20200609141713.11614-2-patrick.keroulas@radio-canada.ca>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200609141713.11614-1-patrick.keroulas@radio-canada.ca>", "References": "<20200609141713.11614-1-patrick.keroulas@radio-canada.ca>", "Subject": "[dpdk-dev] [RFC] [PATCH v1 1/3] net/mlx5: add timestamp-to-ns\n\tconverter from libibverbs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "While some devices update their own clock info to provide current time,\nmlx5dv part of libibverbs already handles this and also converts any raw\ncounter cycle to nanoseconds.\n\nSigned-off-by: Patrick Keroulas <patrick.keroulas@radio-canada.ca>\n---\n drivers/common/mlx5/mlx5_glue.c | 16 ++++++++++++++++\n drivers/common/mlx5/mlx5_glue.h | 4 ++++\n drivers/net/mlx5/mlx5.c | 1 +\n drivers/net/mlx5/mlx5.h | 1 +\n drivers/net/mlx5/mlx5_ethdev.c | 30 ++++++++++++++++++++++++++++++\n 5 files changed, 52 insertions(+)", "diff": "diff --git a/drivers/common/mlx5/mlx5_glue.c b/drivers/common/mlx5/mlx5_glue.c\nindex f270f677b..756f24b8b 100644\n--- a/drivers/common/mlx5/mlx5_glue.c\n+++ b/drivers/common/mlx5/mlx5_glue.c\n@@ -80,6 +80,20 @@ mlx5_glue_query_rt_values_ex(struct ibv_context *context,\n \treturn ibv_query_rt_values_ex(context, values);\n }\n \n+static int\n+mlx5_glue_get_clock_info(struct ibv_context *context,\n+\t\t\t struct mlx5dv_clock_info *clock_info)\n+{\n+\treturn mlx5dv_get_clock_info(context, clock_info);\n+}\n+\n+static uint64_t\n+mlx5_glue_mlx5dv_ts_to_ns(struct mlx5dv_clock_info *clock_info,\n+\t\t\t uint64_t device_timestamp)\n+{\n+\treturn mlx5dv_ts_to_ns(clock_info, device_timestamp);\n+}\n+\n static int\n mlx5_glue_query_port(struct ibv_context *context, uint8_t port_num,\n \t\t struct ibv_port_attr *port_attr)\n@@ -1195,6 +1209,8 @@ const struct mlx5_glue *mlx5_glue = &(const struct mlx5_glue) {\n \t.query_device = mlx5_glue_query_device,\n \t.query_device_ex = mlx5_glue_query_device_ex,\n \t.query_rt_values_ex = mlx5_glue_query_rt_values_ex,\n+\t.get_clock_info = mlx5_glue_get_clock_info,\n+\t.convert_ts_to_ns = mlx5_glue_mlx5dv_ts_to_ns,\n \t.query_port = mlx5_glue_query_port,\n \t.create_comp_channel = mlx5_glue_create_comp_channel,\n \t.destroy_comp_channel = mlx5_glue_destroy_comp_channel,\ndiff --git a/drivers/common/mlx5/mlx5_glue.h b/drivers/common/mlx5/mlx5_glue.h\nindex 81d6a2267..d4b3bd793 100644\n--- a/drivers/common/mlx5/mlx5_glue.h\n+++ b/drivers/common/mlx5/mlx5_glue.h\n@@ -123,6 +123,10 @@ struct mlx5_glue {\n \t\t\t struct ibv_port_attr *port_attr);\n \tstruct ibv_comp_channel *(*create_comp_channel)\n \t\t(struct ibv_context *context);\n+\tint (*get_clock_info)(struct ibv_context *context,\n+\t\t\t struct mlx5dv_clock_info *clock_info);\n+\tuint64_t (*convert_ts_to_ns)(struct mlx5dv_clock_info *clock_info,\n+\t\t\t uint64_t device_timestamp);\n \tint (*destroy_comp_channel)(struct ibv_comp_channel *channel);\n \tstruct ibv_cq *(*create_cq)(struct ibv_context *context, int cqe,\n \t\t\t\t void *cq_context,\ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 5589772eb..7b201844c 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -1569,6 +1569,7 @@ const struct eth_dev_ops mlx5_dev_ops = {\n \t.xstats_get_names = mlx5_xstats_get_names,\n \t.fw_version_get = mlx5_fw_version_get,\n \t.dev_infos_get = mlx5_dev_infos_get,\n+\t.convert_ts_to_ns = mlx5_convert_ts_to_ns,\n \t.read_clock = mlx5_read_clock,\n \t.dev_supported_ptypes_get = mlx5_dev_supported_ptypes_get,\n \t.vlan_filter_set = mlx5_vlan_filter_set,\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex d9f5d816f..905e24487 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -656,6 +656,7 @@ int mlx5_set_flags(struct rte_eth_dev *dev, unsigned int keep,\n \t\t unsigned int flags);\n int mlx5_dev_configure(struct rte_eth_dev *dev);\n int mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info);\n+int mlx5_convert_ts_to_ns(struct rte_eth_dev *dev, uint64_t *timestamp);\n int mlx5_read_clock(struct rte_eth_dev *dev, uint64_t *clock);\n int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size);\n const uint32_t *mlx5_dev_supported_ptypes_get(struct rte_eth_dev *dev);\ndiff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex 47f11b963..1d0411f6b 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -690,6 +690,36 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)\n \treturn 0;\n }\n \n+/**\n+ * Convert raw clock counter to nanoseconds\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device structure.\n+ * @param[in&out] timestamp\n+ * Pointer to the timestamp to be converted.\n+ *\n+ * @return\n+ * 0 if the clock has correctly been read\n+ * The value of errno in case of error\n+ */\n+int\n+mlx5_convert_ts_to_ns(struct rte_eth_dev *dev, uint64_t *timestamp)\n+{\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\tstruct ibv_context *ctx = priv->sh->ctx;\n+\tstruct mlx5dv_clock_info clock_info;\n+\n+\tint err = mlx5_glue->get_clock_info(ctx, &clock_info);\n+\tif (err != 0) {\n+\t\tDRV_LOG(WARNING, \"Could not get the clock info!\");\n+\t\treturn err;\n+\t}\n+\n+\t*timestamp = mlx5_glue->convert_ts_to_ns(&clock_info, *timestamp);\n+\n+\treturn err;\n+}\n+\n /**\n * Get device current raw clock counter\n *\n", "prefixes": [ "RFC", "v1", "1/3" ] }