Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 70824,
    "url": "https://patches.dpdk.org/api/patches/70824/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/ab1667c0330312ed4c4d590048994031d6aebdee.1591186247.git.wangyunjian@huawei.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<ab1667c0330312ed4c4d590048994031d6aebdee.1591186247.git.wangyunjian@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/ab1667c0330312ed4c4d590048994031d6aebdee.1591186247.git.wangyunjian@huawei.com",
    "date": "2020-06-03T12:54:55",
    "name": "[1/3] eal: fix memory leak when removing event_cb",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "2079778922f5e1716f8f0edfd2a7f0d1c534a4d5",
    "submitter": {
        "id": 551,
        "url": "https://patches.dpdk.org/api/people/551/?format=api",
        "name": "Yunjian Wang",
        "email": "wangyunjian@huawei.com"
    },
    "delegate": {
        "id": 24651,
        "url": "https://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/ab1667c0330312ed4c4d590048994031d6aebdee.1591186247.git.wangyunjian@huawei.com/mbox/",
    "series": [
        {
            "id": 10304,
            "url": "https://patches.dpdk.org/api/series/10304/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10304",
            "date": "2020-06-03T12:33:27",
            "name": "fixes for device event",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/10304/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/70824/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/70824/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7F6FEA04A2;\n\tWed,  3 Jun 2020 14:55:10 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 25F621D450;\n\tWed,  3 Jun 2020 14:55:10 +0200 (CEST)",
            "from huawei.com (szxga06-in.huawei.com [45.249.212.32])\n by dpdk.org (Postfix) with ESMTP id 6E8501D15A;\n Wed,  3 Jun 2020 14:55:08 +0200 (CEST)",
            "from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58])\n by Forcepoint Email with ESMTP id 9725BDB7EE407B995336;\n Wed,  3 Jun 2020 20:55:06 +0800 (CST)",
            "from localhost (10.173.251.152) by DGGEMS411-HUB.china.huawei.com\n (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Wed, 3 Jun 2020\n 20:54:56 +0800"
        ],
        "From": "wangyunjian <wangyunjian@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<jia.guo@intel.com>, <jerry.lilijun@huawei.com>, <xudingke@huawei.com>,\n Yunjian Wang <wangyunjian@huawei.com>, <stable@dpdk.org>",
        "Date": "Wed, 3 Jun 2020 20:54:55 +0800",
        "Message-ID": "\n <ab1667c0330312ed4c4d590048994031d6aebdee.1591186247.git.wangyunjian@huawei.com>",
        "X-Mailer": "git-send-email 1.9.5.msysgit.1",
        "In-Reply-To": "<cover.1591186247.git.wangyunjian@huawei.com>",
        "References": "<cover.1591186247.git.wangyunjian@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.173.251.152]",
        "X-CFilter-Loop": "Reflected",
        "Subject": "[dpdk-dev] [PATCH 1/3] eal: fix memory leak when removing event_cb",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Yunjian Wang <wangyunjian@huawei.com>\n\nThe event_cb->dev_name is not freed when freeing event_cb,\nand this causes a memory leak.\n\nFixes: a753e53d517b (\"eal: add device event monitor framework\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n lib/librte_eal/common/eal_common_dev.c | 2 ++\n 1 file changed, 2 insertions(+)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c\nindex 9e4f09d..4cfdb80 100644\n--- a/lib/librte_eal/common/eal_common_dev.c\n+++ b/lib/librte_eal/common/eal_common_dev.c\n@@ -526,6 +526,8 @@ static int cmp_dev_name(const struct rte_device *dev, const void *_name)\n \t\t */\n \t\tif (event_cb->active == 0) {\n \t\t\tTAILQ_REMOVE(&dev_event_cbs, event_cb, next);\n+\t\t\tif (event_cb->dev_name)\n+\t\t\t\tfree(event_cb->dev_name);\n \t\t\tfree(event_cb);\n \t\t\tret++;\n \t\t} else {\n",
    "prefixes": [
        "1/3"
    ]
}