Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70540/?format=api
{ "id": 70540, "url": "https://patches.dpdk.org/api/patches/70540/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200522212731.94269-1-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200522212731.94269-1-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200522212731.94269-1-ajit.khaparde@broadcom.com", "date": "2020-05-22T21:27:31", "name": "net/bnxt: fix a segfault during close", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "02f9722eac1a9b1a5f64ffa270a3d389bcda4154", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200522212731.94269-1-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 10212, "url": "https://patches.dpdk.org/api/series/10212/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10212", "date": "2020-05-22T21:27:31", "name": "net/bnxt: fix a segfault during close", "version": 1, "mbox": "https://patches.dpdk.org/series/10212/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/70540/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/70540/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 93799A0350;\n\tFri, 22 May 2020 23:27:38 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6B5571D9BD;\n\tFri, 22 May 2020 23:27:37 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id B9BF01D9BC\n for <dev@dpdk.org>; Fri, 22 May 2020 23:27:35 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id AC55130C007;\n Fri, 22 May 2020 14:27:34 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.185.215])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 5FCD3140069;\n Fri, 22 May 2020 14:27:33 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com AC55130C007", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1590182854;\n bh=XUf4Rqus0ry00vn5RZQ76B2W1ho7iPikGGNfMf/PXRI=;\n h=From:To:Cc:Subject:Date:From;\n b=rsCclxmw0gUpYPWitRGxSIsXB/DemwYH0t5/kso3SVN3ZaeEC9clPWYrrh86e9SLg\n LpQQsIx59/qwYT8lKCWe/XcyZehkqTdeMLFRFLKSdBb+c/ZQWG+Z8YbQ031lSkJ7C3\n dh6adI6sC6lxiXRmPM5eSa/Ac2ksnDgTrJZxUeHg=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Fri, 22 May 2020 14:27:31 -0700", "Message-Id": "<20200522212731.94269-1-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/bnxt: fix a segfault during close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We are freeing flow_stats a little early. This results in a\nsegfault when the driver accesses the members during cleanup.\nMove the call to bnxt_free_flow_stats_info() to prevent this.\n\nFixes: 02a95625fe9c (\"net/bnxt: add flow stats in extended stats\")\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex e63578109..e8b4c058a 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -221,8 +221,6 @@ static void bnxt_free_cos_queues(struct bnxt *bp)\n \n static void bnxt_free_mem(struct bnxt *bp, bool reconfig)\n {\n-\tbnxt_free_flow_stats_info(bp);\n-\n \tbnxt_free_filter_mem(bp);\n \tbnxt_free_vnic_attributes(bp);\n \tbnxt_free_vnic_mem(bp);\n@@ -5613,6 +5611,7 @@ bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev)\n \tbnxt_uninit_ctx_mem(bp);\n \n \tbnxt_uninit_locks(bp);\n+\tbnxt_free_flow_stats_info(bp);\n \trte_free(bp->ptp_cfg);\n \tbp->ptp_cfg = NULL;\n \treturn rc;\n", "prefixes": [] }