Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 70509,
    "url": "https://patches.dpdk.org/api/patches/70509/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200522065855.31056-2-david.marchand@redhat.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200522065855.31056-2-david.marchand@redhat.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200522065855.31056-2-david.marchand@redhat.com",
    "date": "2020-05-22T06:58:53",
    "name": "[1/3] build: remove special versioning for non stable libraries",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "5d92ca4072db32efb252a311582326276e716831",
    "submitter": {
        "id": 1173,
        "url": "https://patches.dpdk.org/api/people/1173/?format=api",
        "name": "David Marchand",
        "email": "david.marchand@redhat.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200522065855.31056-2-david.marchand@redhat.com/mbox/",
    "series": [
        {
            "id": 10201,
            "url": "https://patches.dpdk.org/api/series/10201/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10201",
            "date": "2020-05-22T06:58:52",
            "name": "Experimental/internal libraries cleanup",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/10201/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/70509/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/70509/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 669D3A0093;\n\tFri, 22 May 2020 08:59:22 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 37A481D904;\n\tFri, 22 May 2020 08:59:22 +0200 (CEST)",
            "from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com\n [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 71D0A1D905\n for <dev@dpdk.org>; Fri, 22 May 2020 08:59:20 +0200 (CEST)",
            "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-408-SSnLzlHtOVmmZcqfBuxBRA-1; Fri, 22 May 2020 02:59:15 -0400",
            "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76E411005510;\n Fri, 22 May 2020 06:59:14 +0000 (UTC)",
            "from dmarchan.remote.csb (unknown [10.40.192.247])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 1430B82EF6;\n Fri, 22 May 2020 06:59:10 +0000 (UTC)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1590130759;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=YXCbs1B2/btWgVtwUVHDrHucSqLhTO4AowEU9LK2xSk=;\n b=Qxz+sri51Acd+79+MumhHzCQqmrP0UaXMcV8gTZ8SNiXotZV+kYEE3173rG8TBXM7jxZl5\n Q2iWfCngl74uhKF5B6KWi0ESkxfJf9We7UNtwFPe9ZAMz+Oh976AfYf2j3tS/ay13t7vIU\n cDgrURCxA/J22SwYNNK3aVPfsEWdMaU=",
        "X-MC-Unique": "SSnLzlHtOVmmZcqfBuxBRA-1",
        "From": "David Marchand <david.marchand@redhat.com>",
        "To": "dev@dpdk.org",
        "Cc": "thomas@monjalon.net, techboard@dpdk.org, Ray Kinsella <mdr@ashroe.eu>,\n Neil Horman <nhorman@tuxdriver.com>",
        "Date": "Fri, 22 May 2020 08:58:53 +0200",
        "Message-Id": "<20200522065855.31056-2-david.marchand@redhat.com>",
        "In-Reply-To": "<20200522065855.31056-1-david.marchand@redhat.com>",
        "References": "<20200522065855.31056-1-david.marchand@redhat.com>",
        "MIME-Version": "1.0",
        "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13",
        "X-Mimecast-Spam-Score": "0",
        "X-Mimecast-Originator": "redhat.com",
        "Content-Type": "text/plain; charset=US-ASCII",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 1/3] build: remove special versioning for non\n\tstable libraries",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Having a special versioning for experimental/internal libraries put a\nadditional maintenance cost while this status is already announced in\nMAINTAINERS and the library headers/documentation.\nFollowing discussions and vote at 05/20 TB meeting [1], use a single\nversioning for all libraries in DPDK.\n\nNote: for the ABI check, an exception [2] had been added when tweaking\nthis special versioning [3].\nPrefer explicit libabigail rules (which will be dropped in 20.11).\n\n1: https://mails.dpdk.org/archives/dev/2020-May/168450.html\n2: https://git.dpdk.org/dpdk/commit/?id=23d7ad5db41c\n3: https://git.dpdk.org/dpdk/commit/?id=ec2b8cd7ed69\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n buildtools/meson.build       |  3 ---\n config/meson.build           | 16 ++++++----------\n devtools/check-abi.sh        |  5 -----\n devtools/libabigail.abignore | 26 ++++++++++++++++++++++++--\n drivers/meson.build          | 13 +------------\n lib/meson.build              | 13 +------------\n mk/rte.lib.mk                |  5 -----\n 7 files changed, 32 insertions(+), 49 deletions(-)",
    "diff": "diff --git a/buildtools/meson.build b/buildtools/meson.build\nindex d5f8291beb..79703b6f93 100644\n--- a/buildtools/meson.build\n+++ b/buildtools/meson.build\n@@ -18,6 +18,3 @@ else\n endif\n map_to_def_cmd = py3 + files('map_to_def.py')\n sphinx_wrapper = py3 + files('call-sphinx-build.py')\n-\n-# stable ABI always starts with \"DPDK_\"\n-is_stable_cmd = [find_program('grep', 'findstr'), '^DPDK_']\ndiff --git a/config/meson.build b/config/meson.build\nindex 43ab113106..35975f1030 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -25,18 +25,14 @@ major_version = '@0@.@1@'.format(pver.get(0), pver.get(1))\n abi_version = run_command(find_program('cat', 'more'),\n \tabi_version_file).stdout().strip()\n \n-# Regular libraries have the abi_version as the filename extension\n+# Libraries have the abi_version as the filename extension\n # and have the soname be all but the final part of the abi_version.\n-# Experimental libraries have soname with '0.major'\n-# and the filename suffix as 0.majorminor versions,\n-# e.g. v20.1 => librte_stable.so.20.1, librte_experimental.so.0.201\n-#    sonames => librte_stable.so.20, librte_experimental.so.0.20\n-# e.g. v20.0.1 => librte_stable.so.20.0.1, librte_experimental.so.0.2001\n-#      sonames => librte_stable.so.20.0, librte_experimental.so.0.200\n+# e.g. v20.1 => librte_foo.so.20.1\n+#    sonames => librte_foo.so.20\n+# e.g. v20.0.1 => librte_foo.so.20.0.1\n+#      sonames => librte_foo.so.20.0\n abi_va = abi_version.split('.')\n-stable_so_version = abi_va.length() == 2 ? abi_va[0] : abi_va[0] + '.' + abi_va[1]\n-experimental_abi_version = '0.' + abi_va[0] + abi_va[1] + '.' + abi_va[2]\n-experimental_so_version = experimental_abi_version\n+so_version = abi_va.length() == 2 ? abi_va[0] : abi_va[0] + '.' + abi_va[1]\n \n # extract all version information into the build configuration\n dpdk_conf.set('RTE_VER_YEAR', pver.get(0).to_int())\ndiff --git a/devtools/check-abi.sh b/devtools/check-abi.sh\nindex dd9120e69e..e17fedbd9f 100755\n--- a/devtools/check-abi.sh\n+++ b/devtools/check-abi.sh\n@@ -44,11 +44,6 @@ for dump in $(find $refdir -name \"*.dump\"); do\n \t\techo \"Skipped glue library $name.\"\n \t\tcontinue\n \tfi\n-\t# skip experimental libraries, with a sover starting with 0.\n-\tif grep -qE \"\\<soname='[^']*\\.so\\.0\\.[^']*'\" $dump; then\n-\t\techo \"Skipped experimental library $name.\"\n-\t\tcontinue\n-\tfi\n \tdump2=$(find $newdir -name $name)\n \tif [ -z \"$dump2\" ] || [ ! -e \"$dump2\" ]; then\n \t\techo \"Error: can't find $name in $newdir\"\ndiff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore\nindex becbf842a5..02b290b08f 100644\n--- a/devtools/libabigail.abignore\n+++ b/devtools/libabigail.abignore\n@@ -50,9 +50,10 @@\n         name = rte_crypto_aead_algorithm_strings\n \n ;;;;;;;;;;;;;;;;;;;;;;\n-; Temporary exceptions for new __rte_internal marking till DPDK 20.11\n+; Temporary exceptions for new __rte_internal marking and experimental\n+; libraries soname changes till DPDK 20.11\n ;;;;;;;;;;;;;;;;;;;;;;\n-; Ignore moving OCTEONTX2 stable functions to INTERNAL tag\n+; Ignore moving OCTEONTX2 stable functions to INTERNAL\n [suppress_file]\n \tfile_name_regexp = ^librte_common_octeontx2\\.\n [suppress_file]\n@@ -77,3 +78,24 @@\n         name = rte_dpaa2_mbuf_alloc_bulk\n [suppress_function]\n         name_regexp = ^dpaa2?_.*tach$\n+; Ignore soname changes for experimental libraries\n+[suppress_file]\n+\tfile_name_regexp = ^librte_bbdev\\.\n+[suppress_file]\n+\tfile_name_regexp = ^librte_bpf\\.\n+[suppress_file]\n+\tfile_name_regexp = ^librte_compressdev\\.\n+[suppress_file]\n+\tfile_name_regexp = ^librte_fib\\.\n+[suppress_file]\n+\tfile_name_regexp = ^librte_flow_classify\\.\n+[suppress_file]\n+\tfile_name_regexp = ^librte_ipsec\\.\n+[suppress_file]\n+\tfile_name_regexp = ^librte_rcu\\.\n+[suppress_file]\n+\tfile_name_regexp = ^librte_rib\\.\n+[suppress_file]\n+\tfile_name_regexp = ^librte_telemetry\\.\n+[suppress_file]\n+\tfile_name_regexp = ^librte_stack\\.\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex cfb6a833c9..4e5713bb27 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -128,17 +128,6 @@ foreach class:dpdk_driver_classes\n \t\t\t\t\tmeson.current_source_dir(),\n \t\t\t\t\tdrv_path, lib_name)\n \n-\t\t\tis_stable = run_command(is_stable_cmd,\n-\t\t\t\tfiles(version_map)).returncode() == 0\n-\n-\t\t\tif is_stable\n-\t\t\t\tlib_version = abi_version\n-\t\t\t\tso_version = stable_so_version\n-\t\t\telse\n-\t\t\t\tlib_version = experimental_abi_version\n-\t\t\t\tso_version = experimental_so_version\n-\t\t\tendif\n-\n \t\t\t# now build the static driver\n \t\t\tstatic_lib = static_library(lib_name,\n \t\t\t\tsources,\n@@ -183,7 +172,7 @@ foreach class:dpdk_driver_classes\n \t\t\t\tc_args: cflags,\n \t\t\t\tlink_args: lk_args,\n \t\t\t\tlink_depends: lk_deps,\n-\t\t\t\tversion: lib_version,\n+\t\t\t\tversion: abi_version,\n \t\t\t\tsoversion: so_version,\n \t\t\t\tinstall: true,\n \t\t\t\tinstall_dir: driver_install_path)\ndiff --git a/lib/meson.build b/lib/meson.build\nindex d190d84eff..13b330396c 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -110,17 +110,6 @@ foreach l:libraries\n \t\t\tversion_map = '@0@/@1@/rte_@2@_version.map'.format(\n \t\t\t\t\tmeson.current_source_dir(), dir_name, name)\n \n-\t\t\tis_stable = run_command(is_stable_cmd,\n-\t\t\t\t\tfiles(version_map)).returncode() == 0\n-\n-\t\t\tif is_stable\n-\t\t\t\tlib_version = abi_version\n-\t\t\t\tso_version = stable_so_version\n-\t\t\telse\n-\t\t\t\tlib_version = experimental_abi_version\n-\t\t\t\tso_version = experimental_so_version\n-\t\t\tendif\n-\n \t\t\t# first build static lib\n \t\t\tstatic_lib = static_library(libname,\n \t\t\t\t\tsources,\n@@ -179,7 +168,7 @@ foreach l:libraries\n \t\t\t\t\tinclude_directories: includes,\n \t\t\t\t\tlink_args: lk_args,\n \t\t\t\t\tlink_depends: lk_deps,\n-\t\t\t\t\tversion: lib_version,\n+\t\t\t\t\tversion: abi_version,\n \t\t\t\t\tsoversion: so_version,\n \t\t\t\t\tinstall: true)\n \t\t\tshared_dep = declare_dependency(link_with: shared_lib,\ndiff --git a/mk/rte.lib.mk b/mk/rte.lib.mk\nindex 682b590dba..229ae16814 100644\n--- a/mk/rte.lib.mk\n+++ b/mk/rte.lib.mk\n@@ -13,11 +13,6 @@ VPATH += $(SRCDIR)\n \n LIBABIVER ?= $(shell cat $(RTE_SRCDIR)/ABI_VERSION)\n SOVER := $(basename $(LIBABIVER))\n-ifeq ($(shell grep -s \"^DPDK_\" $(SRCDIR)/$(EXPORT_MAP)),)\n-# EXPERIMENTAL ABI is versioned as 0.major+minor, e.g. 0.201 for 20.1 ABI\n-LIBABIVER := 0.$(shell echo $(LIBABIVER) | awk 'BEGIN { FS=\".\" }; { print $$1$$2\".\"$$3 }')\n-SOVER := $(LIBABIVER)\n-endif\n \n ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n SONAME := $(patsubst %.a,%.so.$(SOVER),$(LIB))\n",
    "prefixes": [
        "1/3"
    ]
}