Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70476/?format=api
{ "id": 70476, "url": "https://patches.dpdk.org/api/patches/70476/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/0617122502f0d9fc8e7513df4b2d8156efe03ec8.1589977874.git.dekelp@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<0617122502f0d9fc8e7513df4b2d8156efe03ec8.1589977874.git.dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/0617122502f0d9fc8e7513df4b2d8156efe03ec8.1589977874.git.dekelp@mellanox.com", "date": "2020-05-20T12:37:31", "name": "net/mlx5: revert DevX API preferred for Rx objects", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "99407892525a76510a6e42aa169f0942c217761c", "submitter": { "id": 1082, "url": "https://patches.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/0617122502f0d9fc8e7513df4b2d8156efe03ec8.1589977874.git.dekelp@mellanox.com/mbox/", "series": [ { "id": 10175, "url": "https://patches.dpdk.org/api/series/10175/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10175", "date": "2020-05-20T12:37:31", "name": "net/mlx5: revert DevX API preferred for Rx objects", "version": 1, "mbox": "https://patches.dpdk.org/series/10175/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/70476/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/70476/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E5AF3A0093;\n\tWed, 20 May 2020 14:38:02 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B96101C1E7;\n\tWed, 20 May 2020 14:38:01 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 427AD1C1D3\n for <dev@dpdk.org>; Wed, 20 May 2020 14:38:00 +0200 (CEST)", "from Internal Mail-Server by MTLPINE2 (envelope-from\n dekelp@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 20 May 2020 15:37:58 +0300", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n [10.228.134.250])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 04KCbwQM012467;\n Wed, 20 May 2020 15:37:58 +0300" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "ferruh.yigit@intel.com, thomas@monjalon.net, matan@mellanox.com,\n viacheslavo@mellanox.com, rasland@mellanox.com", "Cc": "dev@dpdk.org", "Date": "Wed, 20 May 2020 15:37:31 +0300", "Message-Id": "\n <0617122502f0d9fc8e7513df4b2d8156efe03ec8.1589977874.git.dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "Subject": "[dpdk-dev] [PATCH] net/mlx5: revert DevX API preferred for Rx\n\tobjects", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Recent patch [1] exposed a minor performance issue.\nIn order to properly test it, this patch reverts commit [1].\n\n[1] commit d237d22fbe62 (\"net/mlx5: prefer DevX API to create Rx objects\")\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/mlx5_trigger.c | 15 ++++++++++-----\n 1 file changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c\nindex 8d53648..8106598 100644\n--- a/drivers/net/mlx5/mlx5_trigger.c\n+++ b/drivers/net/mlx5/mlx5_trigger.c\n@@ -107,11 +107,16 @@\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tunsigned int i;\n \tint ret = 0;\n-\tenum mlx5_rxq_obj_type obj_type =\n-\t\t\tpriv->config.dv_flow_en && priv->config.devx &&\n-\t\t\tpriv->config.dest_tir ?\n-\t\t\tMLX5_RXQ_OBJ_TYPE_DEVX_RQ : MLX5_RXQ_OBJ_TYPE_IBV;\n-\n+\tenum mlx5_rxq_obj_type obj_type = MLX5_RXQ_OBJ_TYPE_IBV;\n+\tstruct mlx5_rxq_data *rxq = NULL;\n+\n+\tfor (i = 0; i < priv->rxqs_n; ++i) {\n+\t\trxq = (*priv->rxqs)[i];\n+\t\tif (rxq && rxq->lro) {\n+\t\t\tobj_type = MLX5_RXQ_OBJ_TYPE_DEVX_RQ;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n \t/* Allocate/reuse/resize mempool for Multi-Packet RQ. */\n \tif (mlx5_mprq_alloc_mp(dev)) {\n \t\t/* Should not release Rx queues but return immediately. */\n", "prefixes": [] }