Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70385/?format=api
{ "id": 70385, "url": "https://patches.dpdk.org/api/patches/70385/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200518131704.715877-5-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200518131704.715877-5-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200518131704.715877-5-ferruh.yigit@intel.com", "date": "2020-05-18T13:17:02", "name": "[4/6] vhost: fix translated address not checked", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fad60f9c6c01f60109b99931b2166f4a99e94cf7", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200518131704.715877-5-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 10129, "url": "https://patches.dpdk.org/api/series/10129/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10129", "date": "2020-05-18T13:16:58", "name": "Fix vhost security issues", "version": 1, "mbox": "https://patches.dpdk.org/series/10129/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/70385/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/70385/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 66EABA0093;\n\tMon, 18 May 2020 15:17:50 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 981C51D52A;\n\tMon, 18 May 2020 15:17:22 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 71FA21D529;\n Mon, 18 May 2020 15:17:20 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 May 2020 06:17:20 -0700", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.180])\n by orsmga003.jf.intel.com with ESMTP; 18 May 2020 06:17:18 -0700" ], "IronPort-SDR": [ "\n fjh6UyfgxGGAzkOZ4aJM3FCyKFPW7KgkHUr9aCMdHNDJ2iOaDOlsyLoh1Znvlc0X2LS7vAGXH4\n Qs4HkwmAojeA==", "\n X3xpz//fxCcwgKG4SA9S9/J2R3GgQuCQ9HHhwYVt1ihsJ08SRoYmTbh61QPaQmndULoZXcJZLV\n WcwhwnhMwWKg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,407,1583222400\"; d=\"scan'208\";a=\"263950737\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>, Marvin Liu <yong.liu@intel.com>,\n stable@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Mon, 18 May 2020 14:17:02 +0100", "Message-Id": "<20200518131704.715877-5-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.25.4", "In-Reply-To": "<20200518131704.715877-1-ferruh.yigit@intel.com>", "References": "<20200518131704.715877-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 4/6] vhost: fix translated address not checked", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Marvin Liu <yong.liu@intel.com>\n\nMalicious guest can construct desc with invalid address and zero buffer\nlength. That will request vhost to check both translated address and\ntranslated data length. This patch will add missed address check.\n\nCVE-2020-10725\nFixes: 75ed51697820 (\"vhost: add packed ring batch dequeue\")\nFixes: ef861692c398 (\"vhost: add packed ring batch enqueue\")\nCc: stable@dpdk.org\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/virtio_net.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 1fc30c6819..8504897e7a 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -1072,6 +1072,8 @@ virtio_dev_rx_batch_packed(struct virtio_net *dev,\n \t\t\t\t\t\t VHOST_ACCESS_RW);\n \n \tvhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {\n+\t\tif (unlikely(!desc_addrs[i]))\n+\t\t\treturn -1;\n \t\tif (unlikely(lens[i] != descs[avail_idx + i].len))\n \t\t\treturn -1;\n \t}\n@@ -1827,6 +1829,8 @@ vhost_reserve_avail_batch_packed(struct virtio_net *dev,\n \t}\n \n \tvhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {\n+\t\tif (unlikely(!desc_addrs[i]))\n+\t\t\treturn -1;\n \t\tif (unlikely((lens[i] != descs[avail_idx + i].len)))\n \t\t\treturn -1;\n \t}\n", "prefixes": [ "4/6" ] }