Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70344/?format=api
{ "id": 70344, "url": "https://patches.dpdk.org/api/patches/70344/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200515184542.89318-8-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200515184542.89318-8-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200515184542.89318-8-ajit.khaparde@broadcom.com", "date": "2020-05-15T18:45:40", "name": "[v1,7/9] net/bnxt: fix to use RSS config from eth dev struct", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9917350a1bda18e39222a95805ad86adaf904bb8", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200515184542.89318-8-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 10105, "url": "https://patches.dpdk.org/api/series/10105/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10105", "date": "2020-05-15T18:45:33", "name": "bug fixes for bnxt PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/10105/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/70344/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/70344/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 59A1FA00C3;\n\tFri, 15 May 2020 20:47:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8995C1DB48;\n\tFri, 15 May 2020 20:46:02 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 9AD191DABA;\n Fri, 15 May 2020 20:45:52 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 195C691EB7;\n Fri, 15 May 2020 11:44:45 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.185.215])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 2D6BF140069;\n Fri, 15 May 2020 11:45:51 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 195C691EB7", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1589568285;\n bh=e23xP41rqrAZpnb+dtL92qi5sTnQ028f1X3m0U4KTdc=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=oLQ0LeLCLnuQetlYrE1BO9hU3lrq4nHXCkIFWbxYXgJIsEUmP24mSJYz+lQv1Nwq8\n 8LQ4q2ylJerd8+avtTXgTcULr3gx0hZc6ijRYL050Nl6/MrFWVVQOuu1I38IAkXEab\n YqOxTt+O+Htt/Qi/G0AJI4r3vVj/Wth557ZA51s8=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, stable@dpdk.org,\n Kalesh AP <kalesh-anakkur.purayil@broadcom.com>", "Date": "Fri, 15 May 2020 11:45:40 -0700", "Message-Id": "<20200515184542.89318-8-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200515184542.89318-1-ajit.khaparde@broadcom.com>", "References": "<20200515184542.89318-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 7/9] net/bnxt: fix to use RSS config from eth\n\tdev struct", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is no need to maintain local copy.\nThis helps reduce the size of the bnxt structure.\n\nFixes: fcc0aa1edc10 (\"net/bnxt: add RSS hash configuration\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 -\n drivers/net/bnxt/bnxt_ethdev.c | 4 +++-\n drivers/net/bnxt/bnxt_rxq.c | 4 +---\n 3 files changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 7410db5e4..4093a2f01 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -530,7 +530,6 @@ struct bnxt {\n \tvoid\t\t\t\t*bar0;\n \n \tstruct rte_eth_dev\t\t*eth_dev;\n-\tstruct rte_eth_rss_conf\t\trss_conf;\n \tstruct rte_pci_device\t\t*pdev;\n \tvoid\t\t\t\t*doorbell_base;\n \ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex b64745003..4d64a9835 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1796,7 +1796,9 @@ static int bnxt_rss_hash_update_op(struct rte_eth_dev *eth_dev,\n \t}\n \n \tbp->flags |= BNXT_FLAG_UPDATE_HASH;\n-\tmemcpy(&bp->rss_conf, rss_conf, sizeof(*rss_conf));\n+\tmemcpy(ð_dev->data->dev_conf.rx_adv_conf.rss_conf,\n+\t rss_conf,\n+\t sizeof(*rss_conf));\n \n \t/* Update the default RSS VNIC(s) */\n \tvnic = BNXT_GET_DEFAULT_VNIC(bp);\ndiff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex 457ebede0..e42308a97 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -168,10 +168,8 @@ int bnxt_mq_rx_configure(struct bnxt *bp)\n \tif (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {\n \t\tstruct rte_eth_rss_conf *rss = &dev_conf->rx_adv_conf.rss_conf;\n \n-\t\tif (bp->flags & BNXT_FLAG_UPDATE_HASH) {\n-\t\t\trss = &bp->rss_conf;\n+\t\tif (bp->flags & BNXT_FLAG_UPDATE_HASH)\n \t\t\tbp->flags &= ~BNXT_FLAG_UPDATE_HASH;\n-\t\t}\n \n \t\tfor (i = 0; i < bp->nr_vnics; i++) {\n \t\t\tvnic = &bp->vnic_info[i];\n", "prefixes": [ "v1", "7/9" ] }