Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70203/?format=api
{ "id": 70203, "url": "https://patches.dpdk.org/api/patches/70203/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200514040902.25341-1-rmody@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200514040902.25341-1-rmody@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200514040902.25341-1-rmody@marvell.com", "date": "2020-05-14T04:09:02", "name": "[v2] net/qede: fix link state configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "037a4f6376b8c5c4c37b539c4c8f9b11abf18911", "submitter": { "id": 1211, "url": "https://patches.dpdk.org/api/people/1211/?format=api", "name": "Rasesh Mody", "email": "rmody@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200514040902.25341-1-rmody@marvell.com/mbox/", "series": [ { "id": 10050, "url": "https://patches.dpdk.org/api/series/10050/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10050", "date": "2020-05-14T04:09:02", "name": "[v2] net/qede: fix link state configuration", "version": 2, "mbox": "https://patches.dpdk.org/series/10050/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/70203/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/70203/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0E8C8A00C3;\n\tThu, 14 May 2020 06:09:11 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9BA791D626;\n\tThu, 14 May 2020 06:09:10 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id A913B1D5FF;\n Thu, 14 May 2020 06:09:08 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 04E3xrcD012253; Wed, 13 May 2020 21:09:07 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 3100xk0ekb-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 13 May 2020 21:09:06 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 13 May 2020 21:09:04 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 13 May 2020 21:09:05 -0700", "from irv1user08.caveonetworks.com (unknown [10.104.116.105])\n by maili.marvell.com (Postfix) with ESMTP id 18AFA3F703F;\n Wed, 13 May 2020 21:09:05 -0700 (PDT)", "(from rmody@localhost)\n by irv1user08.caveonetworks.com (8.14.4/8.14.4/Submit) id 04E494l7025406;\n Wed, 13 May 2020 21:09:04 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0818; bh=51+kuWt+AmB1TNmAKerlVBiSqItWK+us9UGQVDAP8WA=;\n b=KVc0cCu2MYmuDyBH09YsrILHpMlI3rf8gejTzJms7wAspDS3EZ/YlF7xpa514tzDmutg\n 7ASWmAzOPP/hrleIvvCYN3M3MnbTu6EV5HHZX6PP7AMxEEQuIZ/trsUvvl+nlTdZm7Ah\n vk9zfZB+1P3ca2y8x3lEl2cvceaqkqFrzN6q9WrtXUtNKUKTiUgQ1FgmEXxTMBLGQPtk\n BohDkdlbKxabcFnBHmWCGfe/ujk+DUb7A6dnt4IfYZdmoZNDLfCGFjPgy/tKmPoX2397\n j5Uu9SHPk9U8lb+kEQYv5brQsG2PzdKwgk+irm9pyraOLvTsCZSXy+M7AxkSTQEelrRB Zg==", "X-Authentication-Warning": "irv1user08.caveonetworks.com: rmody set sender to\n rmody@marvell.com using -f", "From": "Rasesh Mody <rmody@marvell.com>", "To": "<dev@dpdk.org>, <jerinj@marvell.com>, <ferruh.yigit@intel.com>", "CC": "Rasesh Mody <rmody@marvell.com>, <GR-Everest-DPDK-Dev@marvell.com>,\n <stable@dpdk.org>, Shahed Shaikh <shshaikh@marvell.com>, Igor Russkikh\n <irusskikh@marvell.com>", "Date": "Wed, 13 May 2020 21:09:02 -0700", "Message-ID": "<20200514040902.25341-1-rmody@marvell.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20200512004624.11114-1-rmody@marvell.com>", "References": "<20200512004624.11114-1-rmody@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676\n definitions=2020-05-13_09:2020-05-13,\n 2020-05-13 signatures=0", "Subject": "[dpdk-dev] [PATCH v2] net/qede: fix link state configuration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Move link state enable/disable to dev_start() and dev_stop()\nrespectively. This will ensure when devices are stopped,\nlink status will be appropriately shown as down.\n\nFixes: dd28bc8c6ef4 (\"net/qede: fix VF port creation sequence\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shahed Shaikh <shshaikh@marvell.com>\nSigned-off-by: Rasesh Mody <rmody@marvell.com>\nSigned-off-by: Igor Russkikh <irusskikh@marvell.com>\n---\n drivers/net/qede/qede_ethdev.c | 14 +++++++++-----\n 1 file changed, 9 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex e71fa1e6a..0b1fca9ac 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -1144,6 +1144,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev)\n \tif (qede_activate_vport(eth_dev, true))\n \t\tgoto err;\n \n+\t/* Bring-up the link */\n+\tqede_dev_set_link_state(eth_dev, true);\n+\n \t/* Update link status */\n \tqede_link_update(eth_dev, 0);\n \n@@ -1166,6 +1169,12 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)\n \n \tPMD_INIT_FUNC_TRACE(edev);\n \n+\t/* Bring the link down */\n+\tqede_dev_set_link_state(eth_dev, false);\n+\n+\t/* Update link status */\n+\tqede_link_update(eth_dev, 0);\n+\n \t/* Disable vport */\n \tif (qede_activate_vport(eth_dev, false))\n \t\treturn;\n@@ -1550,8 +1559,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)\n \teth_dev->data->nb_rx_queues = 0;\n \teth_dev->data->nb_tx_queues = 0;\n \n-\t/* Bring the link down */\n-\tqede_dev_set_link_state(eth_dev, false);\n \tqdev->ops->common->slowpath_stop(edev);\n \tqdev->ops->common->remove(edev);\n \trte_intr_disable(&pci_dev->intr_handle);\n@@ -2672,9 +2679,6 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)\n \n \teth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops;\n \n-\t/* Bring-up the link */\n-\tqede_dev_set_link_state(eth_dev, true);\n-\n \tadapter->num_tx_queues = 0;\n \tadapter->num_rx_queues = 0;\n \tSLIST_INIT(&adapter->arfs_info.arfs_list_head);\n", "prefixes": [ "v2" ] }