Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70078/?format=api
{ "id": 70078, "url": "https://patches.dpdk.org/api/patches/70078/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200511110912.11535-4-wisamm@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200511110912.11535-4-wisamm@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200511110912.11535-4-wisamm@mellanox.com", "date": "2020-05-11T11:09:10", "name": "[v6,3/5] app/flow-perf: add deletion rate calculation", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "656bfab3bb4df19a092c9956424962ab4ae71a60", "submitter": { "id": 938, "url": "https://patches.dpdk.org/api/people/938/?format=api", "name": "Wisam Jaddo", "email": "wisamm@mellanox.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200511110912.11535-4-wisamm@mellanox.com/mbox/", "series": [ { "id": 9980, "url": "https://patches.dpdk.org/api/series/9980/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9980", "date": "2020-05-11T11:09:08", "name": "[v6,1/5] app/flow-perf: add flow performance skeleton", "version": 6, "mbox": "https://patches.dpdk.org/series/9980/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/70078/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/70078/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8FB56A00C5;\n\tMon, 11 May 2020 13:10:44 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1FB621C2F6;\n\tMon, 11 May 2020 13:09:37 +0200 (CEST)", "from EUR05-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur05on2072.outbound.protection.outlook.com [40.107.21.72])\n by dpdk.org (Postfix) with ESMTP id 5ECCB1C43E\n for <dev@dpdk.org>; Mon, 11 May 2020 13:09:33 +0200 (CEST)", "from AM0PR05MB6610.eurprd05.prod.outlook.com (2603:10a6:208:12f::18)\n by AM0PR05MB5891.eurprd05.prod.outlook.com (2603:10a6:208:133::28)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.33; Mon, 11 May\n 2020 11:09:32 +0000", "from AM0PR05MB6610.eurprd05.prod.outlook.com\n ([fe80::900:c0ac:78bd:18fc]) by AM0PR05MB6610.eurprd05.prod.outlook.com\n ([fe80::900:c0ac:78bd:18fc%6]) with mapi id 15.20.2958.035; Mon, 11 May 2020\n 11:09:32 +0000", "from mellanox.com (37.142.13.130) by\n PR3P192CA0058.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:57::33) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.2979.29 via Frontend Transport; Mon, 11 May 2020 11:09:31 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=WFsfowNqhuEk0L04Y41m3xn/kkav9FsF4d3QuR436pstRnkhACsGNQk/NkqKTdan4VQ7T11Nh3tB41VPfeErK251hwT3NabG2lt7sGnCtlDwS32GLPaqIsxuNXztfW+MAKm3mapcYcEMhzbI4mp7zozdTqrdRW7zgLYwHCQBIfdUCpy/FMZyixTnSYVf2EdbVc2FKDMFk8tcdq8no7ACoTs2VV1/6P5+oeC6dqERwYg5OAMktoFun8NZjx3Y04WTJw3Au1XwSQYXi6FR+a7BWXVETgay1DWuRMOshJJ8FUECWzizBI1iM2dbOgwvOZJUojJYnSuS+TUwSmgHg6Le3w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=LVoddsExgJluQtnT0d+Klwyre2vejkcQz54MUosVMFY=;\n b=jJ7sXntj0rYcZHEPadO7qsaN3GxJK3XYOaBlvweQ+T8h7dVjdy7G0DzPucqhlkKmc1U8uOB9vlRoSIRHfm29JVWlxkA4OTwRvb5AEus0l4t7epjIU6tGZUDiQ1uUiviSfAUtiGhfeOLvdnNp4qK+j383W3Q/gkI9Nk/BXcc8n1JK+ZG+ctlYOECHsjKHYMPcDfv7ml7FAd/cd5qhTBMTk0znyHJGt1ZxT2ze17ziiVl0OU6J16N4y2wqTlysHvIthuoqOy5OcJK1SEZnP4HKkWasg/0Qq2KN04EM06OydONLNepcmuvwY5RYOzWHBlGupiXhuiF2gaijSEnm+U1EpA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=LVoddsExgJluQtnT0d+Klwyre2vejkcQz54MUosVMFY=;\n b=XkBdr3D/K/VhKq+9W3ChOkfAygseKC/P/lQNkcEG2W8A54X9aft6kIbDr0Szt/RQp8jWoJUgXoTtUwu8J634koQZ1olDX5egk7rKXNJ5mCHplP/SRJZe5KMX7QADIGau4BzqjPW/Key/Jtdq7wrRTXmkK22Kpdc4h611CjyEXXI=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Wisam Jaddo <wisamm@mellanox.com>", "To": "dev@dpdk.org, jackmin@mellanox.com, thomas@monjalon.net,\n jerinjacobk@gmail.com, ajit.khaparde@broadcom.com,\n arybchenko@solarflare.com", "Date": "Mon, 11 May 2020 11:09:10 +0000", "Message-Id": "<20200511110912.11535-4-wisamm@mellanox.com>", "X-Mailer": [ "git-send-email 2.17.1", "git-send-email 2.17.1" ], "In-Reply-To": "<20200511110912.11535-1-wisamm@mellanox.com>", "References": "<20200506123627.22340-2-wisamm@mellanox.com>\n <20200511110912.11535-1-wisamm@mellanox.com>", "Content-Type": "text/plain", "X-ClientProxiedBy": "PR3P192CA0058.EURP192.PROD.OUTLOOK.COM\n (2603:10a6:102:57::33) To AM0PR05MB6610.eurprd05.prod.outlook.com\n (2603:10a6:208:12f::18)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[37.142.13.130]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "5185bd7c-b6ed-4241-3cf6-08d7f59bc829", "X-MS-TrafficTypeDiagnostic": "AM0PR05MB5891:|AM0PR05MB5891:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM0PR05MB589176A293BB67B7B1733D7AA9A10@AM0PR05MB5891.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:1388;", "X-Forefront-PRVS": "04004D94E2", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n eY0GXgjThRngSasiyORK5GBxol/c2hvEQuZrJTZYd3x7AU7/Lm5VRKRcRFmYnONcJgop42/IAwM+zV0QFDz8ZHExS/+xby1vX2Hv4mVyC3YBizQ0wNCoGO8/0IjuW9GkDVrP9baZ6QY/QT9eCfcW0sSWeJ7r6aALisJ6fk3utLOJKuy/4Z+vYEG0rX1ZJ2cMERvQlsel1mLS53/R3fYVuCoO1xU/dXR0XuJTNb5vMTiy7dNhdDccVbBjlDBCtwZsgWcn+kwaUlFo49vuzxy9T1+hf1wdJeAA2RI+9k12R2dKvWRHBzYG1CNdIZtklpfvx72z1+5DmWvaohaR5glAVLgxFd69YcEDyFQgZFLU1iVyOiCsN+Uskbhw+UO9UA+252zagmZJ8nQ4LorxELscfA/iLMHSFlAWyHAy7BZQMtsWbYRK6YvBNDCWKSFYBjEADrGWcjZ6SjwpY6jiO+Qmw/OhcNUOUkBYqX1cdjBrdYXtcVy+COARFojGPdaYAEEeNOM+QWpjkIDHbZ9mvD4THQ==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6610.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(376002)(136003)(39860400002)(396003)(366004)(346002)(33430700001)(66556008)(36756003)(478600001)(5660300002)(1076003)(33440700001)(316002)(6666004)(8886007)(2906002)(8936002)(55016002)(86362001)(66476007)(8676002)(66946007)(52116002)(26005)(2616005)(956004)(16526019)(186003)(7696005);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n qi8H/wEoVBIcVJjCAzBTyRvfpLytUvJUfppjSyLjBs/fF+LiWJqpUURFGP2MY6VL/P4hn/NhOQgs60B3c226szL2F21ssqzaXQc9jOefltNt5h/Umq4zoVTTwAGmAlC06LqUgjo583KMZ7aFNPVxYm0AOMaRA1AN2qmWwKJb1FVc0TH00d6GxNIAeveUls5UIQXeanxanZmqLzhqzRURVB5FPX2sYas9ZXJrrYJyh7y/5NU0GxkNc8yJ0Aae6wG7o055w0ehikyg1Vl1AZz7awz0nBy4p5NPWRBZLQXSlnOwe9CB5Eg6VFPUY54jg5ZF3qXEOUbDgT4pArRxAqkNSNJodKSjSXbm8lIePAzPEoV20eqJkrRmljGDBkEM30v6GSaFAxQ3QBWmcUE0Mw7cjT9VJxYVE7ZX38sEFycksZiyW9aJTpJ9CeRARAWZsWtk0Dnzl5oACOeFfps6etCHeCt6ZYORHDF07wz6+pDG+P8=", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 5185bd7c-b6ed-4241-3cf6-08d7f59bc829", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "11 May 2020 11:09:32.5045 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 9FizYK1Fe6ZZ4n0qcx1FrleZxVdBZKBCSU/fyVBd83gIEHgHX+dQlwwou2sDZBVgFNsz2mm9IHSJQj0qfQI+7g==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB5891", "Subject": "[dpdk-dev] [PATCH v6 3/5] app/flow-perf: add deletion rate\n\tcalculation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add the ability to test deletion rate for flow performance\napplication.\n\nThis feature is disabled by default, and can be enabled by\nadd \"--deletion-rate\" in the application command line options.\n\nSigned-off-by: Wisam Jaddo <wisamm@mellanox.com>\n---\n app/test-flow-perf/main.c | 87 ++++++++++++++++++++++++++\n doc/guides/rel_notes/release_20_05.rst | 1 +\n doc/guides/tools/flow-perf.rst | 4 ++\n 3 files changed, 92 insertions(+)", "diff": "diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c\nindex 1feb73e6f..b177025fa 100644\n--- a/app/test-flow-perf/main.c\n+++ b/app/test-flow-perf/main.c\n@@ -49,6 +49,7 @@ static uint32_t flow_actions;\n static uint32_t flow_attrs;\n static volatile bool force_quit;\n static bool dump_iterations;\n+static bool delete_flag;\n static struct rte_mempool *mbuf_mp;\n static uint32_t nb_lcores;\n static uint32_t flows_count;\n@@ -64,6 +65,8 @@ usage(char *progname)\n \t\t\" flows to insert, default is 4,000,000\\n\");\n \tprintf(\" --dump-iterations: To print rates for each\"\n \t\t\" iteration\\n\");\n+\tprintf(\" --deletion-rate: Enable deletion rate\"\n+\t\t\" calculations\\n\");\n \n \tprintf(\"To set flow attributes:\\n\");\n \tprintf(\" --ingress: set ingress attribute in flows\\n\");\n@@ -246,6 +249,7 @@ args_parse(int argc, char **argv)\n \t\t{ \"help\", 0, 0, 0 },\n \t\t{ \"flows-count\", 1, 0, 0 },\n \t\t{ \"dump-iterations\", 0, 0, 0 },\n+\t\t{ \"deletion-rate\", 0, 0, 0 },\n \t\t/* Attributes */\n \t\t{ \"ingress\", 0, 0, 0 },\n \t\t{ \"egress\", 0, 0, 0 },\n@@ -353,6 +357,9 @@ args_parse(int argc, char **argv)\n \t\t\tif (strcmp(lgopts[opt_idx].name,\n \t\t\t\t\t\"dump-iterations\") == 0)\n \t\t\t\tdump_iterations = true;\n+\t\t\tif (strcmp(lgopts[opt_idx].name,\n+\t\t\t\t\t\"deletion-rate\") == 0)\n+\t\t\t\tdelete_flag = true;\n \t\t\tbreak;\n \t\tdefault:\n \t\t\tfprintf(stderr, \"Invalid option: %s\\n\", argv[optind]);\n@@ -372,9 +379,75 @@ print_flow_error(struct rte_flow_error error)\n \t\terror.message ? error.message : \"(no stated reason)\");\n }\n \n+static inline void\n+destroy_flows(int port_id, struct rte_flow **flow_list)\n+{\n+\tstruct rte_flow_error error;\n+\tclock_t start_iter, end_iter;\n+\tdouble cpu_time_used = 0;\n+\tdouble flows_rate;\n+\tdouble cpu_time_per_iter[MAX_ITERATIONS];\n+\tdouble delta;\n+\tuint32_t i;\n+\tint iter_id;\n+\n+\tfor (i = 0; i < MAX_ITERATIONS; i++)\n+\t\tcpu_time_per_iter[i] = -1;\n+\n+\tif (iterations_number > flows_count)\n+\t\titerations_number = flows_count;\n+\n+\t/* Deletion Rate */\n+\tprintf(\"Flows Deletion on port = %d\\n\", port_id);\n+\tstart_iter = clock();\n+\tfor (i = 0; i < flows_count; i++) {\n+\t\tif (flow_list[i] == 0)\n+\t\t\tbreak;\n+\n+\t\tmemset(&error, 0x33, sizeof(error));\n+\t\tif (rte_flow_destroy(port_id, flow_list[i], &error)) {\n+\t\t\tprint_flow_error(error);\n+\t\t\trte_exit(EXIT_FAILURE, \"Error in deleting flow\");\n+\t\t}\n+\n+\t\tif (i && !((i + 1) % iterations_number)) {\n+\t\t\t/* Save the deletion rate of each iter */\n+\t\t\tend_iter = clock();\n+\t\t\tdelta = (double) (end_iter - start_iter);\n+\t\t\titer_id = ((i + 1) / iterations_number) - 1;\n+\t\t\tcpu_time_per_iter[iter_id] =\n+\t\t\t\tdelta / CLOCKS_PER_SEC;\n+\t\t\tcpu_time_used += cpu_time_per_iter[iter_id];\n+\t\t\tstart_iter = clock();\n+\t\t}\n+\t}\n+\n+\t/* Deletion rate per iteration */\n+\tif (dump_iterations)\n+\t\tfor (i = 0; i < MAX_ITERATIONS; i++) {\n+\t\t\tif (cpu_time_per_iter[i] == -1)\n+\t\t\t\tcontinue;\n+\t\t\tdelta = (double)(iterations_number /\n+\t\t\t\tcpu_time_per_iter[i]);\n+\t\t\tflows_rate = delta / 1000;\n+\t\t\tprintf(\":: Iteration #%d: %d flows \"\n+\t\t\t\t\"in %f sec[ Rate = %f K/Sec ]\\n\",\n+\t\t\t\ti, iterations_number,\n+\t\t\t\tcpu_time_per_iter[i], flows_rate);\n+\t\t}\n+\n+\t/* Deletion rate for all flows */\n+\tflows_rate = ((double) (flows_count / cpu_time_used) / 1000);\n+\tprintf(\"\\n:: Total flow deletion rate -> %f K/Sec\\n\",\n+\t\tflows_rate);\n+\tprintf(\":: The time for deleting %d in flows %f seconds\\n\",\n+\t\tflows_count, cpu_time_used);\n+}\n+\n static inline void\n flows_handler(void)\n {\n+\tstruct rte_flow **flow_list;\n \tstruct rte_flow_error error;\n \tclock_t start_iter, end_iter;\n \tdouble cpu_time_used;\n@@ -386,6 +459,7 @@ flows_handler(void)\n \tint port_id;\n \tint iter_id;\n \tuint32_t eagain_counter = 0;\n+\tuint32_t flow_index;\n \n \tnr_ports = rte_eth_dev_count_avail();\n \n@@ -397,8 +471,14 @@ flows_handler(void)\n \n \tprintf(\":: Flows Count per port: %d\\n\", flows_count);\n \n+\tflow_list = rte_zmalloc(\"flow_list\",\n+\t\t(sizeof(struct rte_flow *) * flows_count) + 1, 0);\n+\tif (flow_list == NULL)\n+\t\trte_exit(EXIT_FAILURE, \"No Memory available!\");\n+\n \tfor (port_id = 0; port_id < nr_ports; port_id++) {\n \t\tcpu_time_used = 0;\n+\t\tflow_index = 0;\n \t\tif (flow_group > 0) {\n \t\t\t/*\n \t\t\t * Create global rule to jump into flow_group,\n@@ -417,6 +497,7 @@ flows_handler(void)\n \t\t\t\tprint_flow_error(error);\n \t\t\t\trte_exit(EXIT_FAILURE, \"error in creating flow\");\n \t\t\t}\n+\t\t\tflow_list[flow_index++] = flow;\n \t\t}\n \n \t\t/* Insertion Rate */\n@@ -440,6 +521,8 @@ flows_handler(void)\n \t\t\t\trte_exit(EXIT_FAILURE, \"error in creating flow\");\n \t\t\t}\n \n+\t\t\tflow_list[flow_index++] = flow;\n+\n \t\t\tif (i && !((i + 1) % iterations_number)) {\n \t\t\t\t/* Save the insertion rate of each iter */\n \t\t\t\tend_iter = clock();\n@@ -473,6 +556,9 @@ flows_handler(void)\n \t\tprintf(\":: The time for creating %d in flows %f seconds\\n\",\n \t\t\t\t\t\tflows_count, cpu_time_used);\n \t\tprintf(\":: EAGAIN counter = %d\\n\", eagain_counter);\n+\n+\t\tif (delete_flag)\n+\t\t\tdestroy_flows(port_id, flow_list);\n \t}\n }\n \n@@ -631,6 +717,7 @@ main(int argc, char **argv)\n \tdump_iterations = false;\n \tflows_count = DEFAULT_RULES_COUNT;\n \titerations_number = DEFAULT_ITERATION;\n+\tdelete_flag = false;\n \tflow_group = 0;\n \n \tsignal(SIGINT, signal_handler);\ndiff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst\nindex 0e4dcf1ad..e511e9c1a 100644\n--- a/doc/guides/rel_notes/release_20_05.rst\n+++ b/doc/guides/rel_notes/release_20_05.rst\n@@ -218,6 +218,7 @@ New Features\n \n Application features:\n * Measure rte_flow insertion rate.\n+ * Measure rte_flow deletion rate.\n \n \n Removed Items\ndiff --git a/doc/guides/tools/flow-perf.rst b/doc/guides/tools/flow-perf.rst\nindex 6f3f7dafb..1f8b1fa15 100644\n--- a/doc/guides/tools/flow-perf.rst\n+++ b/doc/guides/tools/flow-perf.rst\n@@ -25,6 +25,8 @@ The current version has limitations which can be removed in future:\n * Support outer items up to tunnel layer only.\n * Single core insertion only.\n \n+The application also provide the ability to measure rte flow deletion rate.\n+\n \n Compiling the Application\n =========================\n@@ -71,6 +73,8 @@ The command line options are:\n \tPrint rates for each iteration of flows.\n \tDefault iteration is 1,00,000.\n \n+*\t``--deletion-rate``\n+\tEnable deletion rate calculations.\n \n Attributes:\n \n", "prefixes": [ "v6", "3/5" ] }