Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 70029,
    "url": "https://patches.dpdk.org/api/patches/70029/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200509082421.24588-1-guohongzhi1@huawei.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200509082421.24588-1-guohongzhi1@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200509082421.24588-1-guohongzhi1@huawei.com",
    "date": "2020-05-09T08:24:21",
    "name": "lib/librte_net: fix bug for ipv4 checksum calculating",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "54a7d56f86829199545048633235abe06304f5a2",
    "submitter": {
        "id": 1710,
        "url": "https://patches.dpdk.org/api/people/1710/?format=api",
        "name": "Hongzhi Guo",
        "email": "guohongzhi1@huawei.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200509082421.24588-1-guohongzhi1@huawei.com/mbox/",
    "series": [
        {
            "id": 9954,
            "url": "https://patches.dpdk.org/api/series/9954/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9954",
            "date": "2020-05-09T08:24:21",
            "name": "lib/librte_net: fix bug for ipv4 checksum calculating",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/9954/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/70029/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/70029/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E39B7A046B;\n\tSat,  9 May 2020 10:24:37 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BE6D91D706;\n\tSat,  9 May 2020 10:24:37 +0200 (CEST)",
            "from huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by dpdk.org (Postfix) with ESMTP id B41571D705\n for <dev@dpdk.org>; Sat,  9 May 2020 10:24:35 +0200 (CEST)",
            "from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59])\n by Forcepoint Email with ESMTP id E2F43F23578B51544977;\n Sat,  9 May 2020 16:24:33 +0800 (CST)",
            "from DESKTOP-ORJPOMD.china.huawei.com (10.173.251.143) by\n DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id\n 14.3.487.0; Sat, 9 May 2020 16:24:27 +0800"
        ],
        "From": "guohongzhi <guohongzhi1@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<olivier.matz@6wind.com>, <zhoujingbin@huawei.com>,\n <chenchanghu@huawei.com>, <jerry.lilijun@huawei.com>,\n <haifeng.lin@huawei.com>, <guohongzhi1@huawei.com>",
        "Date": "Sat, 9 May 2020 16:24:21 +0800",
        "Message-ID": "<20200509082421.24588-1-guohongzhi1@huawei.com>",
        "X-Mailer": "git-send-email 2.21.0.windows.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.173.251.143]",
        "X-CFilter-Loop": "Reflected",
        "Subject": "[dpdk-dev] [PATCH] [PATCH] lib/librte_net: fix bug for ipv4\n\tchecksum calculating",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The function of rte_ipv4_cksum for calculating the checksum of IPv4 header is incorrect. This function will return checksum value like 0xffff. This value, however, is considered an illegal checksum on some switches(like Trident3).\nRFC 1624 specifies the IPv4 checksum as follows:\nhttps://tools.ietf.org/rfc/rfc1624\nSince there is guaranteed to be at least one\n   non-zero field in the IP header, and the checksum field in the\n   protocol header is the complement of the sum, the checksum field can\n   never contain ~(+0), which is -0 (0xFFFF).  It can, however, contain\n   ~(-0), which is +0 (0x0000).\n---\n lib/librte_net/rte_ip.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h\nindex 1ceb7b7..ece2e43 100644\n--- a/lib/librte_net/rte_ip.h\n+++ b/lib/librte_net/rte_ip.h\n@@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)\n {\n \tuint16_t cksum;\n \tcksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));\n-\treturn (cksum == 0xffff) ? cksum : (uint16_t)~cksum;\n+\treturn (uint16_t)~cksum;\n }\n \n /**\n",
    "prefixes": []
}