Patch Comment List
List patch comments
GET /api/patches/70/comments/?format=api&order=-submitter
[ { "id": 198, "web_url": "https://patches.dpdk.org/comment/198/", "msgid": "<20140722192756.GA11289@mhcomputing.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20140722192756.GA11289@mhcomputing.net", "date": "2014-07-22T19:27:57", "subject": "Re: [dpdk-dev] [PATCH 2/4] virtio-net.c: incorrect parens around\n\tequality check", "submitter": { "id": 37, "url": "https://patches.dpdk.org/api/people/37/?format=api", "name": "Matthew Hall", "email": "mhall@mhcomputing.net" }, "content": "On Tue, Jul 22, 2014 at 03:14:51PM +0200, Thomas Monjalon wrote:\n> Hi Matthew,\n> \n> I think that patches 1, 3 and 4 need some rework but this one is valid\n> and has no relation with other ones in the serie. So it can be integrated now.\n\nGreat thanks!\n\nI'll work a bit more on the others when I've got time.\n\nDiscovered them during a weekend Open Source project.\n\nMatthew.", "headers": { "Return-Path": "<mhall@mhcomputing.net>", "Received": [ "from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186])\n\tby dpdk.org (Postfix) with ESMTP id C463C5930\n\tfor <dev@dpdk.org>; Tue, 22 Jul 2014 21:27:12 +0200 (CEST)", "by mail.mhcomputing.net (Postfix, from userid 1000)\n\tid 19EDC80C764; Tue, 22 Jul 2014 12:27:57 -0700 (PDT)" ], "Date": "Tue, 22 Jul 2014 12:27:57 -0700", "From": "Matthew Hall <mhall@mhcomputing.net>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Message-ID": "<20140722192756.GA11289@mhcomputing.net>", "References": "<1405914461-19335-1-git-send-email-mhall@mhcomputing.net>\n\t<1405914461-19335-3-git-send-email-mhall@mhcomputing.net>\n\t<42607666.SQuAkzsMo0@xps13>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<42607666.SQuAkzsMo0@xps13>", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 2/4] virtio-net.c: incorrect parens around\n\tequality check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Tue, 22 Jul 2014 19:27:13 -0000" }, "addressed": null }, { "id": 194, "web_url": "https://patches.dpdk.org/comment/194/", "msgid": "<42607666.SQuAkzsMo0@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/42607666.SQuAkzsMo0@xps13", "date": "2014-07-22T13:14:51", "subject": "Re: [dpdk-dev] [PATCH 2/4] virtio-net.c: incorrect parens around\n\tequality check", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "Hi Matthew,\n\nI think that patches 1, 3 and 4 need some rework but this one is valid\nand has no relation with other ones in the serie. So it can be integrated now.\n\n2014-07-20 20:47, Matthew Hall:\n> --- a/examples/vhost/virtio-net.c\n> +++ b/examples/vhost/virtio-net.c\n> @@ -280,8 +280,8 @@ get_config_ll_entry(struct vhost_device_ctx ctx)\n> \n> \t/* Loop through linked list until the device_fh is found. */\n> \twhile (ll_dev != NULL) {\n> -\t\tif ((ll_dev->dev.device_fh == ctx.fh))\n> - return ll_dev;\n> +\t\tif (ll_dev->dev.device_fh == ctx.fh)\n> +\t\t\treturn ll_dev;\n> \t\tll_dev = ll_dev->next;\n> \t}\n\nAcked-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n\nApplied for version 1.7.1.\n\nThanks", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-wi0-f182.google.com (mail-wi0-f182.google.com\n\t[209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 50719B36D\n\tfor <dev@dpdk.org>; Tue, 22 Jul 2014 15:13:40 +0200 (CEST)", "by mail-wi0-f182.google.com with SMTP id d1so384015wiv.15\n\tfor <dev@dpdk.org>; Tue, 22 Jul 2014 06:14:59 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\t19sm972056wjz.3.2014.07.22.06.14.57 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 22 Jul 2014 06:14:58 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=X5LhL0GG4bmaJVzZPerT/0qxeYnlsrvS6wyV8P+1YE8=;\n\tb=CbEUkjNz3XAiKGCJWEE9kb3l3GVqNIRxC01EUsAOffhtU+tkqW54e3CNIpygs5N1S+\n\tVjxI3g/0uT2rCMq+V2n286I/313SGjcnqJx9wDrIyeac4jSf9VWrVKFNeneUFocJ+duZ\n\tATFGrwsINjKbxGqs15cUwblgQ6IusOC0Ltx3hT2b8OYxxddXwZuhAUXdWyLklWzILlPk\n\tIA5A0lh+iXvdSJ4wUDOV6D+zqmPOj3cbEAH/WdTvrzSDB1otlXXJDpYlVfBCUkfVfxth\n\tFncu1T3Q2H9iza/jYqyNZk8c1l53I5O7yfyLjDnHk1KDs+4veHl+N2eBpRvPCvpZUWur\n\t03ag==", "X-Gm-Message-State": "ALoCoQkqNSqYcVADEyG6elP8Eeg2bYpsqCt323URYLeeWBpaSgGH8jY4r2EqGuI/mOdXyEn6Coyh", "X-Received": "by 10.194.100.34 with SMTP id ev2mr33368197wjb.76.1406034899111; \n\tTue, 22 Jul 2014 06:14:59 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Matthew Hall <mhall@mhcomputing.net>", "Date": "Tue, 22 Jul 2014 15:14:51 +0200", "Message-ID": "<42607666.SQuAkzsMo0@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; )", "In-Reply-To": "<1405914461-19335-3-git-send-email-mhall@mhcomputing.net>", "References": "<1405914461-19335-1-git-send-email-mhall@mhcomputing.net>\n\t<1405914461-19335-3-git-send-email-mhall@mhcomputing.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 2/4] virtio-net.c: incorrect parens around\n\tequality check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Tue, 22 Jul 2014 13:13:40 -0000" }, "addressed": null } ]