Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69802/?format=api
{ "id": 69802, "url": "https://patches.dpdk.org/api/patches/69802/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200506064737.80627-1-yong.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200506064737.80627-1-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200506064737.80627-1-yong.liu@intel.com", "date": "2020-05-06T06:47:37", "name": "net/virtio: fix 32-bit build with clang 6.0.0", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "48ff25acc046bf53d838fcdcddac64a83b7ae6f1", "submitter": { "id": 17, "url": "https://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200506064737.80627-1-yong.liu@intel.com/mbox/", "series": [ { "id": 9854, "url": "https://patches.dpdk.org/api/series/9854/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9854", "date": "2020-05-06T06:47:37", "name": "net/virtio: fix 32-bit build with clang 6.0.0", "version": 1, "mbox": "https://patches.dpdk.org/series/9854/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/69802/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/69802/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3968CA0350;\n\tWed, 6 May 2020 08:47:43 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 903E31D700;\n\tWed, 6 May 2020 08:47:42 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 3E7E11D6FF\n for <dev@dpdk.org>; Wed, 6 May 2020 08:47:41 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 May 2020 23:47:40 -0700", "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.56])\n by orsmga004.jf.intel.com with ESMTP; 05 May 2020 23:47:38 -0700" ], "IronPort-SDR": [ "\n fxxlji06XXiC8U6n09fye9dD8MEn6Basssb5fAoTU7fx00aLHOiO64kGi3+/ZF4VdkGEIeeRbO\n nZLHxjLLii0g==", "\n 3YBgR6fsrrkxHzIbI3uc/MSvM0Xm4crBkYQWDlsoALNK8ewefektyZ2mKeNnhy0ldosGaYjWDY\n 7fv2vGZP+O9Q==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,358,1583222400\"; d=\"scan'208\";a=\"407129500\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com, xiaolong.ye@intel.com, zhihong.wang@intel.com", "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>", "Date": "Wed, 6 May 2020 14:47:37 +0800", "Message-Id": "<20200506064737.80627-1-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] net/virtio: fix 32-bit build with clang 6.0.0", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Clang 6.0.0 will undefine function _mm512_maskz_set1_epi64 on i686\ntarget. Fix it by replacing the function with _mm512_set4_epi64 when\ndoing 32-bit build.\n\nWarning messasge during build:\n../drivers/net/virtio/virtio_rxtx_packed_avx.c:385:19: warning:\nimplicit declaration of function '_mm512_maskz_set1_epi64' is invalid\nin C99 [-Wimplicit-function-declaration]\n\nFixes: 8d35836e4a7c (\"net/virtio: add vectorized packed ring Rx path\")\nSigned-off-by: Marvin Liu <yong.liu@intel.com>", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx_packed_avx.c b/drivers/net/virtio/virtio_rxtx_packed_avx.c\nindex d130d68bf..6a8214725 100644\n--- a/drivers/net/virtio/virtio_rxtx_packed_avx.c\n+++ b/drivers/net/virtio/virtio_rxtx_packed_avx.c\n@@ -365,7 +365,12 @@ virtqueue_dequeue_batch_packed_vec(struct virtnet_rx *rxvq,\n \t\treturn -1;\n \n \t/* only care avail/used bits */\n+#if defined(RTE_ARCH_I686)\n+\t__m512i v_mask = _mm512_set4_epi64(PACKED_FLAGS_MASK, 0x0,\n+\t\t\t\t\t PACKED_FLAGS_MASK, 0x0);\n+#else\n \t__m512i v_mask = _mm512_maskz_set1_epi64(0xaa, PACKED_FLAGS_MASK);\n+#endif\n \tdesc_addr = &vq->vq_packed.ring.desc[id];\n \n \t__m512i v_desc = _mm512_loadu_si512(desc_addr);\n@@ -373,7 +378,12 @@ virtqueue_dequeue_batch_packed_vec(struct virtnet_rx *rxvq,\n \n \t__m512i v_used_flag = _mm512_setzero_si512();\n \tif (vq->vq_packed.used_wrap_counter)\n+#if defined(RTE_ARCH_I686)\n+\t\tv_used_flag = _mm512_set4_epi64(PACKED_FLAGS_MASK, 0x0,\n+\t\t\t\t\t\tPACKED_FLAGS_MASK, 0x0);\n+#else\n \t\tv_used_flag = _mm512_maskz_set1_epi64(0xaa, PACKED_FLAGS_MASK);\n+#endif\n \n \t/* Check all descs are used */\n \tdesc_stats = _mm512_cmpneq_epu64_mask(v_flag, v_used_flag);\n", "prefixes": [] }