Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 69688,
    "url": "https://patches.dpdk.org/api/patches/69688/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1588576329-15792-1-git-send-email-matan@mellanox.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1588576329-15792-1-git-send-email-matan@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1588576329-15792-1-git-send-email-matan@mellanox.com",
    "date": "2020-05-04T07:12:09",
    "name": "vdpa/mlx5: fix PCI address comparison",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6f6cd84f2f6a58ace38ac612923f0cd6d02368b2",
    "submitter": {
        "id": 796,
        "url": "https://patches.dpdk.org/api/people/796/?format=api",
        "name": "Matan Azrad",
        "email": "matan@mellanox.com"
    },
    "delegate": {
        "id": 2642,
        "url": "https://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1588576329-15792-1-git-send-email-matan@mellanox.com/mbox/",
    "series": [
        {
            "id": 9798,
            "url": "https://patches.dpdk.org/api/series/9798/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9798",
            "date": "2020-05-04T07:12:09",
            "name": "vdpa/mlx5: fix PCI address comparison",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/9798/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/69688/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/69688/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 378B8A04AF;\n\tMon,  4 May 2020 09:12:29 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ED3441D426;\n\tMon,  4 May 2020 09:12:25 +0200 (CEST)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id B90E81D422\n for <dev@dpdk.org>; Mon,  4 May 2020 09:12:23 +0200 (CEST)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n matan@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 4 May 2020 10:12:18 +0300",
            "from pegasus25.mtr.labs.mlnx. (pegasus25.mtr.labs.mlnx\n [10.210.16.10])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0447CH8w002585;\n Mon, 4 May 2020 10:12:18 +0300"
        ],
        "From": "Matan Azrad <matan@mellanox.com>",
        "To": "dev@dpdk.org",
        "Cc": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>, stable@dpdk.org",
        "Date": "Mon,  4 May 2020 07:12:09 +0000",
        "Message-Id": "<1588576329-15792-1-git-send-email-matan@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "Subject": "[dpdk-dev] [PATCH] vdpa/mlx5: fix PCI address comparison",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "A regular memcmp function was used to compare between two objects of\ntype `struct rte_pci_addr`.\n\nDue to the alignment rules of compiler structure builders, some memory\nis not initiated in the structure even though all the fields were\ninitiated.\n\nTherefore, the comparison may fail even though the PCI addresses are\nidentical and to cause false failure in probe.\n\nUse the dedicated API to compare 2 PCI addresses.\n\nFixes: 75dd0ae91765 (\"vdpa/mlx5: disable RoCE\")\nCc: stable@dpdk.org\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\nTested-by: Noa Ezra <noae@mellanox.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c\nindex 9f7353d..1113d6c 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c\n@@ -305,7 +305,7 @@\n \t\tDRV_LOG(DEBUG, \"Checking device \\\"%s\\\"..\", ibv_list[n]->name);\n \t\tif (mlx5_dev_to_pci_addr(ibv_list[n]->ibdev_path, &pci_addr))\n \t\t\tcontinue;\n-\t\tif (memcmp(addr, &pci_addr, sizeof(pci_addr)))\n+\t\tif (rte_pci_addr_cmp(addr, &pci_addr))\n \t\t\tcontinue;\n \t\tibv_match = ibv_list[n];\n \t\tbreak;\n",
    "prefixes": []
}