Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69620/?format=api
{ "id": 69620, "url": "https://patches.dpdk.org/api/patches/69620/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200430160137.59135-12-ciara.power@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200430160137.59135-12-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200430160137.59135-12-ciara.power@intel.com", "date": "2020-04-30T16:01:30", "name": "[v5,11/18] rawdev: add callback support for telemetry", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fead60de0991f455f661be4c33ab71d9709968c0", "submitter": { "id": 978, "url": "https://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200430160137.59135-12-ciara.power@intel.com/mbox/", "series": [ { "id": 9771, "url": "https://patches.dpdk.org/api/series/9771/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9771", "date": "2020-04-30T16:01:19", "name": "update and simplify telemetry library.", "version": 5, "mbox": "https://patches.dpdk.org/series/9771/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/69620/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/69620/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BEFA2A00C5;\n\tThu, 30 Apr 2020 18:04:30 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 91ACD1DC13;\n\tThu, 30 Apr 2020 18:02:26 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id 7D4271DBEF\n for <dev@dpdk.org>; Thu, 30 Apr 2020 18:02:23 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Apr 2020 09:02:23 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by orsmga003.jf.intel.com with ESMTP; 30 Apr 2020 09:02:20 -0700" ], "IronPort-SDR": [ "\n OnFeds/KoYM+zvjyd6hzji5VuTYQL6wvIAToQUoC2iTVzpJYeYIZF4aadHike9KA1IG8fONDQm\n jE19DB3jve8A==", "\n 1OaOIwxUwP5adLPp+sgVT7fVAqJhtGN/Q1tndBGRtCsJNpa93CFxWgV/9dyVC3WHKQ1K7kdCGq\n f4i+o92LlpTg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,336,1583222400\"; d=\"scan'208\";a=\"258345181\"", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org,\n\tkevin.laatz@intel.com", "Cc": "reshma.pattan@intel.com, jerinjacobk@gmail.com, david.marchand@redhat.com,\n keith.wiles@intel.com, mb@smartsharesystems.com, thomas@monjalon.net,\n stephen@networkplumber.org, bluca@debian.org,\n Ciara Power <ciara.power@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 30 Apr 2020 17:01:30 +0100", "Message-Id": "<20200430160137.59135-12-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200430160137.59135-1-ciara.power@intel.com>", "References": "<20200319171907.60891-1-ciara.power@intel.com>\n <20200430160137.59135-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 11/18] rawdev: add callback support for\n\ttelemetry", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The rawdev library now registers commands with telemetry, and\nimplements the corresponding callback functions. These allow a list of\nrawdev devices and xstats for a rawdev port to be queried.\n\nAn example usage, with ioat rawdev driver instances, is shown below:\n\nConnecting to /var/run/dpdk/rte/dpdk_telemetry.v2\n{\"version\": \"DPDK 20.05.0-rc0\", \"pid\": 65777, \"max_output_len\": 16384}\n--> /\n{\"/\": [\"/\", \"/ethdev/link_status\", \"/ethdev/list\", \"/ethdev/xstats\", \\\n \"/help\", \"/info\", \"/rawdev/list\", \"/rawdev/xstats\"]}\n--> /rawdev/list\n{\"/rawdev/list\": [0, 1, 2, 3, 4, 5]}\n--> /rawdev/xstats,0\n{\"/rawdev/xstats\": {\"failed_enqueues\": 0, \"successful_enqueues\": 0, \\\n \"copies_started\": 0, \"copies_completed\": 0}}\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Ciara Power <ciara.power@intel.com>\nReviewed-by: Keith Wiles <keith.wiles@intel.com>\n\n---\nv4: Modified to use binary data formatting instead of JSON.\nv2: Renamed stats to xstats for device specific stats.\n---\n lib/librte_rawdev/Makefile | 4 ++\n lib/librte_rawdev/meson.build | 4 ++\n lib/librte_rawdev/rte_rawdev.c | 79 ++++++++++++++++++++++++++++++++++\n 3 files changed, 87 insertions(+)", "diff": "diff --git a/lib/librte_rawdev/Makefile b/lib/librte_rawdev/Makefile\nindex 7dd1197dcd..5d7c2a582d 100644\n--- a/lib/librte_rawdev/Makefile\n+++ b/lib/librte_rawdev/Makefile\n@@ -11,6 +11,10 @@ CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n LDLIBS += -lrte_eal\n \n+ifeq ($(CONFIG_RTE_LIBRTE_TELEMETRY),y)\n+LDLIBS += -lrte_telemetry\n+endif\n+\n # library source files\n SRCS-y += rte_rawdev.c\n \ndiff --git a/lib/librte_rawdev/meson.build b/lib/librte_rawdev/meson.build\nindex a20fbdc048..1f23d2a80c 100644\n--- a/lib/librte_rawdev/meson.build\n+++ b/lib/librte_rawdev/meson.build\n@@ -3,3 +3,7 @@\n \n sources = files('rte_rawdev.c')\n headers = files('rte_rawdev.h', 'rte_rawdev_pmd.h')\n+\n+if dpdk_conf.has('RTE_LIBRTE_TELEMETRY')\n+\tdeps += ['telemetry']\n+endif\ndiff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawdev.c\nindex b6f1e1c779..ee6c087b12 100644\n--- a/lib/librte_rawdev/rte_rawdev.c\n+++ b/lib/librte_rawdev/rte_rawdev.c\n@@ -29,6 +29,9 @@\n #include <rte_common.h>\n #include <rte_malloc.h>\n #include <rte_errno.h>\n+#ifdef RTE_LIBRTE_TELEMETRY\n+#include <rte_telemetry.h>\n+#endif\n \n #include \"rte_rawdev.h\"\n #include \"rte_rawdev_pmd.h\"\n@@ -544,9 +547,85 @@ rte_rawdev_pmd_release(struct rte_rawdev *rawdev)\n \treturn 0;\n }\n \n+#ifdef RTE_LIBRTE_TELEMETRY\n+static int\n+handle_dev_list(const char *cmd __rte_unused,\n+\t\tconst char *params __rte_unused,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tint i;\n+\n+\trte_tel_data_start_array(d, RTE_TEL_INT_VAL);\n+\tfor (i = 0; i < rawdev_globals.nb_devs; i++)\n+\t\tif (rte_rawdevices[i].attached == RTE_RAWDEV_ATTACHED)\n+\t\t\trte_tel_data_add_array_int(d, i);\n+\treturn 0;\n+}\n+\n+static int\n+handle_dev_xstats(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tuint64_t *rawdev_xstats;\n+\tstruct rte_rawdev_xstats_name *xstat_names;\n+\tint dev_id, num_xstats, i, ret;\n+\tunsigned int *ids;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\tdev_id = atoi(params);\n+\tif (!rte_rawdev_pmd_is_valid_dev(dev_id))\n+\t\treturn -1;\n+\n+\tnum_xstats = xstats_get_count(dev_id);\n+\tif (num_xstats < 0)\n+\t\treturn -1;\n+\n+\t/* use one malloc for names, stats and ids */\n+\trawdev_xstats = malloc((sizeof(uint64_t) +\n+\t\t\tsizeof(struct rte_rawdev_xstats_name) +\n+\t\t\tsizeof(unsigned int)) * num_xstats);\n+\tif (rawdev_xstats == NULL)\n+\t\treturn -1;\n+\txstat_names = (void *)&rawdev_xstats[num_xstats];\n+\tids = (void *)&xstat_names[num_xstats];\n+\n+\tret = rte_rawdev_xstats_names_get(dev_id, xstat_names, num_xstats);\n+\tif (ret < 0 || ret > num_xstats) {\n+\t\tfree(rawdev_xstats);\n+\t\treturn -1;\n+\t}\n+\n+\tfor (i = 0; i < num_xstats; i++)\n+\t\tids[i] = i;\n+\n+\tret = rte_rawdev_xstats_get(dev_id, ids, rawdev_xstats, num_xstats);\n+\tif (ret < 0 || ret > num_xstats) {\n+\t\tfree(rawdev_xstats);\n+\t\treturn -1;\n+\t}\n+\n+\trte_tel_data_start_dict(d);\n+\tfor (i = 0; i < num_xstats; i++)\n+\t\trte_tel_data_add_dict_u64(d, xstat_names[i].name,\n+\t\t\t\trawdev_xstats[i]);\n+\n+\tfree(rawdev_xstats);\n+\treturn 0;\n+}\n+#endif\n+\n RTE_INIT(librawdev_init_log)\n {\n \tlibrawdev_logtype = rte_log_register(\"lib.rawdev\");\n \tif (librawdev_logtype >= 0)\n \t\trte_log_set_level(librawdev_logtype, RTE_LOG_INFO);\n+#ifdef RTE_LIBRTE_TELEMETRY\n+\trte_telemetry_register_cmd(\"/rawdev/list\", handle_dev_list,\n+\t\t\t\"Returns list of available rawdev ports. Takes no parameters\");\n+\trte_telemetry_register_cmd(\"/rawdev/xstats\", handle_dev_xstats,\n+\t\t\t\"Returns the xstats for a rawdev port. Parameters: int port_id\");\n+#endif\n }\n", "prefixes": [ "v5", "11/18" ] }