Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69548/?format=api
https://patches.dpdk.org/api/patches/69548/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200429111328.64952-7-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200429111328.64952-7-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200429111328.64952-7-huwei013@chinasoftinc.com", "date": "2020-04-29T11:13:28", "name": "[6/6] net/hns3: fix return value when clearing statistics fails", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "be7d2adf5c0d241787a236f2a88f7f00c8061c09", "submitter": { "id": 1537, "url": "https://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200429111328.64952-7-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 9733, "url": "https://patches.dpdk.org/api/series/9733/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9733", "date": "2020-04-29T11:13:22", "name": "misc updates and bugfixes for hns3 PMD driver", "version": 1, "mbox": "https://patches.dpdk.org/series/9733/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/69548/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/69548/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BA4F9A00BE;\n\tWed, 29 Apr 2020 13:14:39 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 551701DA6C;\n\tWed, 29 Apr 2020 13:14:06 +0200 (CEST)", "from mail.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 77CAB1DA4E\n for <dev@dpdk.org>; Wed, 29 Apr 2020 13:13:59 +0200 (CEST)", "from localhost.localdomain (114.119.4.74) by INCCAS002.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Wed, 29 Apr 2020\n 19:13:40 +0800" ], "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "Date": "Wed, 29 Apr 2020 19:13:28 +0800", "Message-ID": "<20200429111328.64952-7-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20200429111328.64952-1-huwei013@chinasoftinc.com>", "References": "<20200429111328.64952-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[114.119.4.74]", "Subject": "[dpdk-dev] [PATCH 6/6] net/hns3: fix return value when clearing\n\tstatistics fails", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>\n\nSince the return value of the '.stats_reset' and '.xstats_reset' callback\nfunction is int, when failing to issue command to firmware to execute clear\nstatistics, the relevant callback function should return non-zero value.\n\nFixes: 8839c5e202f3 (\"net/hns3: support device stats\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_stats.c | 21 +++++++++++++++++----\n 1 file changed, 17 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c\nindex ad276206c..d2467a484 100644\n--- a/drivers/net/hns3/hns3_stats.c\n+++ b/drivers/net/hns3/hns3_stats.c\n@@ -527,6 +527,7 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)\n \t\tif (ret) {\n \t\t\thns3_err(hw, \"Failed to reset RX No.%d queue stat: %d\",\n \t\t\t\t i, ret);\n+\t\t\treturn ret;\n \t\t}\n \n \t\thns3_cmd_setup_basic_desc(&desc_reset, HNS3_OPC_QUERY_TX_STATUS,\n@@ -537,6 +538,7 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)\n \t\tif (ret) {\n \t\t\thns3_err(hw, \"Failed to reset TX No.%d queue stat: %d\",\n \t\t\t\t i, ret);\n+\t\t\treturn ret;\n \t\t}\n \t}\n \n@@ -571,7 +573,7 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)\n \treturn 0;\n }\n \n-static void\n+static int\n hns3_mac_stats_reset(__rte_unused struct rte_eth_dev *dev)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n@@ -580,10 +582,14 @@ hns3_mac_stats_reset(__rte_unused struct rte_eth_dev *dev)\n \tint ret;\n \n \tret = hns3_query_update_mac_stats(dev);\n-\tif (ret)\n+\tif (ret) {\n \t\thns3_err(hw, \"Clear Mac stats fail : %d\", ret);\n+\t\treturn ret;\n+\t}\n \n \tmemset(mac_stats, 0, sizeof(struct hns3_mac_stats));\n+\n+\treturn 0;\n }\n \n /* This function calculates the number of xstats based on the current config */\n@@ -979,9 +985,13 @@ hns3_dev_xstats_reset(struct rte_eth_dev *dev)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_pf *pf = &hns->pf;\n+\tint ret;\n \n \t/* Clear tqp stats */\n-\t(void)hns3_stats_reset(dev);\n+\tret = hns3_stats_reset(dev);\n+\tif (ret)\n+\t\treturn ret;\n+\n \t/* Clear reset stats */\n \tmemset(&hns->hw.reset.stats, 0, sizeof(struct hns3_reset_stats));\n \n@@ -989,7 +999,10 @@ hns3_dev_xstats_reset(struct rte_eth_dev *dev)\n \t\treturn 0;\n \n \t/* HW registers are cleared on read */\n-\thns3_mac_stats_reset(dev);\n+\tret = hns3_mac_stats_reset(dev);\n+\tif (ret)\n+\t\treturn ret;\n+\n \t/* Clear error stats */\n \tmemset(&pf->abn_int_stats, 0, sizeof(struct hns3_err_msix_intr_stats));\n \n", "prefixes": [ "6/6" ] }{ "id": 69548, "url": "