Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69510/?format=api
https://patches.dpdk.org/api/patches/69510/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200429025946.48096-1-xuan.ding@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200429025946.48096-1-xuan.ding@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200429025946.48096-1-xuan.ding@intel.com", "date": "2020-04-29T02:59:46", "name": "vhost: zero_copy incompatible with client mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ba473282bec885f9174fd13d0ea8143c099964f6", "submitter": { "id": 1401, "url": "https://patches.dpdk.org/api/people/1401/?format=api", "name": "Ding, Xuan", "email": "xuan.ding@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200429025946.48096-1-xuan.ding@intel.com/mbox/", "series": [ { "id": 9722, "url": "https://patches.dpdk.org/api/series/9722/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9722", "date": "2020-04-29T02:59:46", "name": "vhost: zero_copy incompatible with client mode", "version": 1, "mbox": "https://patches.dpdk.org/series/9722/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/69510/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/69510/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B8086A00BE;\n\tWed, 29 Apr 2020 05:03:52 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4CE5D1D735;\n\tWed, 29 Apr 2020 05:03:52 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 498191D734\n for <dev@dpdk.org>; Wed, 29 Apr 2020 05:03:50 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2020 20:03:49 -0700", "from dpdk-xuanding-dev2.sh.intel.com ([10.67.118.193])\n by fmsmga008.fm.intel.com with ESMTP; 28 Apr 2020 20:03:47 -0700" ], "IronPort-SDR": [ "\n S5FESmUBe8xlSs8YEiI/a6WcVHWNxwX2GzzOefbSKWxReT8WBE35wsKlLDy5F734WWkPyYGaPE\n G4VS7qu+wtGg==", "\n uQJkjHgxCcwSJ56lICs9+fzjVTUlBa2BH1Uz/QZwvtdBjAxfN4gciIx/cSxCOOvzDuwV9p8C3L\n bCT9D97QTWRg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,329,1583222400\"; d=\"scan'208\";a=\"249346666\"", "From": "Xuan Ding <xuan.ding@intel.com>", "To": "maxime.coquelin@redhat.com, zhihong.wang@intel.com, xiaolong.ye@intel.com", "Cc": "dev@dpdk.org,\n\tXuan Ding <xuan.ding@intel.com>", "Date": "Wed, 29 Apr 2020 02:59:46 +0000", "Message-Id": "<20200429025946.48096-1-xuan.ding@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] vhost: zero_copy incompatible with client mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In server mode, virtio-user inits under the assumption that vhost-user\nsupports a list of features. However, this could be problematic when\nin_order feature is negotiated but not supported by vhost-user when\nenables dequeue_zero_copy later.\n\nAdd handling when vhost-user enables dequeue_zero_copy as client.\n\nSigned-off-by: Xuan Ding <xuan.ding@intel.com>\n---\n lib/librte_vhost/socket.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c\nindex 7c8012179..bb8d0d780 100644\n--- a/lib/librte_vhost/socket.c\n+++ b/lib/librte_vhost/socket.c\n@@ -926,6 +926,12 @@ rte_vhost_driver_register(const char *path, uint64_t flags)\n \t\t\tret = -1;\n \t\t\tgoto out_mutex;\n \t\t}\n+\t\tif (!vsocket->is_server) {\n+\t\t\tVHOST_LOG_CONFIG(ERR,\n+\t\t\t\"error: zero copy is incompatible with vhost client mode\\n\");\n+\t\t\tret = -1;\n+\t\t\tgoto out_mutex;\n+\t\t}\n \t\tvsocket->supported_features &= ~(1ULL << VIRTIO_F_IN_ORDER);\n \t\tvsocket->features &= ~(1ULL << VIRTIO_F_IN_ORDER);\n \n", "prefixes": [] }{ "id": 69510, "url": "