Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 69497,
    "url": "https://patches.dpdk.org/api/patches/69497/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200429010100.22003-2-yong.liu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200429010100.22003-2-yong.liu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200429010100.22003-2-yong.liu@intel.com",
    "date": "2020-04-29T01:00:58",
    "name": "[v4,1/2] vhost: utilize dpdk dynamic memory allocator",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "f5d65b2ca5fdf6deba93ed2fbaa3bbb07efef6d2",
    "submitter": {
        "id": 17,
        "url": "https://patches.dpdk.org/api/people/17/?format=api",
        "name": "Marvin Liu",
        "email": "yong.liu@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200429010100.22003-2-yong.liu@intel.com/mbox/",
    "series": [
        {
            "id": 9716,
            "url": "https://patches.dpdk.org/api/series/9716/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9716",
            "date": "2020-04-29T01:00:58",
            "name": "[v4,1/2] vhost: utilize dpdk dynamic memory allocator",
            "version": 4,
            "mbox": "https://patches.dpdk.org/series/9716/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/69497/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/69497/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 64BB4A00BE;\n\tWed, 29 Apr 2020 03:01:20 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6910E1D6AE;\n\tWed, 29 Apr 2020 03:01:13 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id AF4D31D6A5\n for <dev@dpdk.org>; Wed, 29 Apr 2020 03:01:10 +0200 (CEST)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2020 18:01:09 -0700",
            "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.56])\n by fmsmga004.fm.intel.com with ESMTP; 28 Apr 2020 18:01:08 -0700"
        ],
        "IronPort-SDR": [
            "\n KZZu0M4sfmseydHZPWoR2Bxi0bvEUo0gaKI4Zpl6+KTlAUHDlyJU8CoQ1vT7K9jo+C/VmtyRCo\n PzyhkskzujoQ==",
            "\n sr9HrElP0jnTIFaxwdgxceJ7mBpSveXAvKfcRFP9VtJ0BAxMRLgk5Gi+8SLyPgXr1f5bBpG0AW\n ceLWu5uRMt7g=="
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.73,329,1583222400\"; d=\"scan'208\";a=\"282336201\"",
        "From": "Marvin Liu <yong.liu@intel.com>",
        "To": "maxime.coquelin@redhat.com, xiaolong.ye@intel.com, zhihong.wang@intel.com",
        "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>",
        "Date": "Wed, 29 Apr 2020 09:00:58 +0800",
        "Message-Id": "<20200429010100.22003-2-yong.liu@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200429010100.22003-1-yong.liu@intel.com>",
        "References": "<20200316153353.112897-1-yong.liu@intel.com>\n <20200429010100.22003-1-yong.liu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v4 1/2] vhost: utilize dpdk dynamic memory\n\tallocator",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Replace dynamic memory allocator with dpdk memory allocator.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>",
    "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex bd1be0104..79fcb9d19 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -191,7 +191,7 @@ vhost_backend_cleanup(struct virtio_net *dev)\n \t\tdev->mem = NULL;\n \t}\n \n-\tfree(dev->guest_pages);\n+\trte_free(dev->guest_pages);\n \tdev->guest_pages = NULL;\n \n \tif (dev->log_addr) {\n@@ -903,11 +903,12 @@ add_one_guest_page(struct virtio_net *dev, uint64_t guest_phys_addr,\n \tif (dev->nr_guest_pages == dev->max_guest_pages) {\n \t\tdev->max_guest_pages *= 2;\n \t\told_pages = dev->guest_pages;\n-\t\tdev->guest_pages = realloc(dev->guest_pages,\n-\t\t\t\t\tdev->max_guest_pages * sizeof(*page));\n-\t\tif (!dev->guest_pages) {\n+\t\tdev->guest_pages = rte_realloc(dev->guest_pages,\n+\t\t\t\t\tdev->max_guest_pages * sizeof(*page),\n+\t\t\t\t\tRTE_CACHE_LINE_SIZE);\n+\t\tif (dev->guest_pages == NULL) {\n \t\t\tVHOST_LOG_CONFIG(ERR, \"cannot realloc guest_pages\\n\");\n-\t\t\tfree(old_pages);\n+\t\t\trte_free(old_pages);\n \t\t\treturn -1;\n \t\t}\n \t}\n@@ -1062,10 +1063,12 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *msg,\n \t\t\tvhost_user_iotlb_flush_all(dev->virtqueue[i]);\n \n \tdev->nr_guest_pages = 0;\n-\tif (!dev->guest_pages) {\n+\tif (dev->guest_pages == NULL) {\n \t\tdev->max_guest_pages = 8;\n-\t\tdev->guest_pages = malloc(dev->max_guest_pages *\n-\t\t\t\t\t\tsizeof(struct guest_page));\n+\t\tdev->guest_pages = rte_zmalloc(NULL,\n+\t\t\t\t\tdev->max_guest_pages *\n+\t\t\t\t\tsizeof(struct guest_page),\n+\t\t\t\t\tRTE_CACHE_LINE_SIZE);\n \t\tif (dev->guest_pages == NULL) {\n \t\t\tVHOST_LOG_CONFIG(ERR,\n \t\t\t\t\"(%d) failed to allocate memory \"\n",
    "prefixes": [
        "v4",
        "1/2"
    ]
}