Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 6944,
    "url": "https://patches.dpdk.org/api/patches/6944/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1441523526-26202-47-git-send-email-jingjing.wu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1441523526-26202-47-git-send-email-jingjing.wu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1441523526-26202-47-git-send-email-jingjing.wu@intel.com",
    "date": "2015-09-06T07:12:00",
    "name": "[dpdk-dev,46/52] i40e/base: remove useless assignments",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "fe20f322bdce1644a089b1ca8e55dbc8fef86e7e",
    "submitter": {
        "id": 47,
        "url": "https://patches.dpdk.org/api/people/47/?format=api",
        "name": "Jingjing Wu",
        "email": "jingjing.wu@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1441523526-26202-47-git-send-email-jingjing.wu@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/6944/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/6944/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D886193D8;\n\tSun,  6 Sep 2015 09:13:59 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 0861793D6\n\tfor <dev@dpdk.org>; Sun,  6 Sep 2015 09:13:57 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga103.fm.intel.com with ESMTP; 06 Sep 2015 00:13:57 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 06 Sep 2015 00:13:56 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t867DsLS019857;\n\tSun, 6 Sep 2015 15:13:54 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t867DqXs026561; Sun, 6 Sep 2015 15:13:54 +0800",
            "(from wujingji@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t867DpOe026557; \n\tSun, 6 Sep 2015 15:13:51 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.17,478,1437462000\"; d=\"scan'208\";a=\"763416153\"",
        "From": "Jingjing Wu <jingjing.wu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Sun,  6 Sep 2015 15:12:00 +0800",
        "Message-Id": "<1441523526-26202-47-git-send-email-jingjing.wu@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1441523526-26202-1-git-send-email-jingjing.wu@intel.com>",
        "References": "<1441523526-26202-1-git-send-email-jingjing.wu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 46/52] i40e/base: remove useless assignments",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The assignments of addr_high and addr_low were not only wrong because\nthey were assigning virtual addresses to a hardware accessed variable,\nbut they were shortly thereafter overwritten by the send_asq_command\ncall with a non-NULL third argument (buffer) with correctly formatted\ndata.\n\nSigned-off-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n drivers/net/i40e/base/i40e_common.c | 4 ----\n 1 file changed, 4 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex 727e2c3..023dcbc 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -5323,8 +5323,6 @@ enum i40e_status_code i40e_aq_alternate_write_indirect(struct i40e_hw *hw,\n \n \tcmd_resp->address = CPU_TO_LE32(addr);\n \tcmd_resp->length = CPU_TO_LE32(dw_count);\n-\tcmd_resp->addr_high = CPU_TO_LE32(I40E_HI_WORD((u64)buffer));\n-\tcmd_resp->addr_low = CPU_TO_LE32(I40E_LO_DWORD((u64)buffer));\n \n \tstatus = i40e_asq_send_command(hw, &desc, buffer,\n \t\t\t\t       I40E_LO_DWORD(4*dw_count), NULL);\n@@ -5406,8 +5404,6 @@ enum i40e_status_code i40e_aq_alternate_read_indirect(struct i40e_hw *hw,\n \n \tcmd_resp->address = CPU_TO_LE32(addr);\n \tcmd_resp->length = CPU_TO_LE32(dw_count);\n-\tcmd_resp->addr_high = CPU_TO_LE32(I40E_HI_DWORD((u64)buffer));\n-\tcmd_resp->addr_low = CPU_TO_LE32(I40E_LO_DWORD((u64)buffer));\n \n \tstatus = i40e_asq_send_command(hw, &desc, buffer,\n \t\t\t\t       I40E_LO_DWORD(4*dw_count), NULL);\n",
    "prefixes": [
        "dpdk-dev",
        "46/52"
    ]
}