Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69283/?format=api
{ "id": 69283, "url": "https://patches.dpdk.org/api/patches/69283/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200424233657.12267-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200424233657.12267-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200424233657.12267-2-stephen@networkplumber.org", "date": "2020-04-24T23:36:56", "name": "[1/2] net/tap: simplify netlink send/receive functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b82406f0ce144e0885d56e28f0eaecf3c0b4d7dc", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200424233657.12267-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 9629, "url": "https://patches.dpdk.org/api/series/9629/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9629", "date": "2020-04-24T23:36:55", "name": "net/tap: simplfication and servicabilty improvements", "version": 1, "mbox": "https://patches.dpdk.org/series/9629/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/69283/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/69283/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8D412A00C2;\n\tSat, 25 Apr 2020 01:37:16 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8681A1D405;\n\tSat, 25 Apr 2020 01:37:11 +0200 (CEST)", "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 5DD3C1D168\n for <dev@dpdk.org>; Sat, 25 Apr 2020 01:37:08 +0200 (CEST)", "by mail-pf1-f195.google.com with SMTP id x2so1857929pfx.7\n for <dev@dpdk.org>; Fri, 24 Apr 2020 16:37:08 -0700 (PDT)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id b5sm6826823pfb.190.2020.04.24.16.37.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 24 Apr 2020 16:37:05 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=EPViAVgKaw1TigZGhGqVlElJmnnnWmoaY8X1IwJYVOk=;\n b=VR2Q+kzZkLblS42G1r2sFD3Im391MtiQbhkLhowKuyyDYFT5qWq6uh7XAwK3aGVh2N\n O44yYIRQ/L/+Me7+nS+YeUbcROLX95j8tRLCpzPsB8NBfZw1IPDYCkeMU+Dbrd8rQ4h0\n W7N3PkJa8kQDq0PgPJ9DC1ku/ft8B6C2o9dI6IAYWjy5h2st085EZhVMpHho50bU9vCc\n TNiIse902G/EutG8GA8M44v0g49VbHsEBv9Vou+wfvjoXUYghpXnAdqknCMzur7Z8ryE\n HRb4XlnLHrkRWNKmMnurB6MbBtfPQ/rsjYqIKNRU8y/D3qlDi3EnNl78O4JQgOAqogTe\n 6z7w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=EPViAVgKaw1TigZGhGqVlElJmnnnWmoaY8X1IwJYVOk=;\n b=f2oU8lDMXHV8ibRr4C+8XNkoyyXkiyTlSHv60LIBJWVg/tGwplYL69CHLmidPYR9FR\n 1TKHnPLuGBTVqSm0s03LIxvVAYvfH0p8FJe5GSxNfJ4U3e7wpX1Fx886UEwXJWdKjEio\n 5c0mT2dJTShEOcb7EJI2F8LJcxO6wlM0zCpYOwoTLhPwth4OtmpgktAZxhxI0RAX+rFz\n bis/VGgy3JH1jJwNn7/eC7NbfyfYzJ7/cleI89MXKr1CMVi8i79le1UCjd1JDtJMLIoF\n FO8GLJrE+CMXMLugCmiAnyH1PdCOgYD7O+drXJesjkDDqruETSOOw/o5XCKqJhALEI73\n dzwA==", "X-Gm-Message-State": "AGi0PuZAQuQRok9UHFMGnh0AC9s4TuLOac+t79U4nvRz4jJQGrIXnXfG\n Zti9TORXA2ORquLQVK/tYLWPsHvryhM=", "X-Google-Smtp-Source": "\n APiQypJpRhLEz5h7aZezk3AXulV2pAoVnF0e2NocXeKdS1Tyw4l+cCmS5Wlmv+IC99mPL+EoOgVkSQ==", "X-Received": "by 2002:a63:f64d:: with SMTP id\n u13mr11568691pgj.151.1587771426756;\n Fri, 24 Apr 2020 16:37:06 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org,\n\tkeith.wiles@intel.com", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 24 Apr 2020 16:36:56 -0700", "Message-Id": "<20200424233657.12267-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200424233657.12267-1-stephen@networkplumber.org>", "References": "<20200424233657.12267-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] net/tap: simplify netlink send/receive\n\tfunctions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The tap_nl_recv() function does not need to use the full\ncomplex recvmsg() system call, basic recv() will work here.\n\nDitto for tap_nl_send() full sendmsg is not needed.\n\nAdd logic to retry in case EINTR rather than forcing\nerror handling back in driver or worse to ethdev API.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/tap_netlink.c | 45 +++++++++++------------------------\n 1 file changed, 14 insertions(+), 31 deletions(-)", "diff": "diff --git a/drivers/net/tap/tap_netlink.c b/drivers/net/tap/tap_netlink.c\nindex 14bbbec754f6..64220178a6ba 100644\n--- a/drivers/net/tap/tap_netlink.c\n+++ b/drivers/net/tap/tap_netlink.c\n@@ -101,26 +101,17 @@ tap_nl_final(int nlsk_fd)\n int\n tap_nl_send(int nlsk_fd, struct nlmsghdr *nh)\n {\n-\t/* man 7 netlink EXAMPLE */\n-\tstruct sockaddr_nl sa = {\n-\t\t.nl_family = AF_NETLINK,\n-\t};\n-\tstruct iovec iov = {\n-\t\t.iov_base = nh,\n-\t\t.iov_len = nh->nlmsg_len,\n-\t};\n-\tstruct msghdr msg = {\n-\t\t.msg_name = &sa,\n-\t\t.msg_namelen = sizeof(sa),\n-\t\t.msg_iov = &iov,\n-\t\t.msg_iovlen = 1,\n-\t};\n \tint send_bytes;\n \n \tnh->nlmsg_pid = 0; /* communication with the kernel uses pid 0 */\n \tnh->nlmsg_seq = (uint32_t)rte_rand();\n-\tsend_bytes = sendmsg(nlsk_fd, &msg, 0);\n+\n+retry:\n+\tsend_bytes = send(nlsk_fd, nh, nh->nlmsg_len, 0);\n \tif (send_bytes < 0) {\n+\t\tif (errno == EINTR)\n+\t\t\tgoto retry;\n+\n \t\tTAP_LOG(ERR, \"Failed to send netlink message: %s (%d)\",\n \t\t\tstrerror(errno), errno);\n \t\treturn -1;\n@@ -161,30 +152,22 @@ tap_nl_recv_ack(int nlsk_fd)\n int\n tap_nl_recv(int nlsk_fd, int (*cb)(struct nlmsghdr *, void *arg), void *arg)\n {\n-\t/* man 7 netlink EXAMPLE */\n-\tstruct sockaddr_nl sa;\n \tchar buf[BUF_SIZE];\n-\tstruct iovec iov = {\n-\t\t.iov_base = buf,\n-\t\t.iov_len = sizeof(buf),\n-\t};\n-\tstruct msghdr msg = {\n-\t\t.msg_name = &sa,\n-\t\t.msg_namelen = sizeof(sa),\n-\t\t.msg_iov = &iov,\n-\t\t/* One message at a time */\n-\t\t.msg_iovlen = 1,\n-\t};\n \tint multipart = 0;\n \tint ret = 0;\n \n \tdo {\n \t\tstruct nlmsghdr *nh;\n-\t\tint recv_bytes = 0;\n+\t\tint recv_bytes;\n \n-\t\trecv_bytes = recvmsg(nlsk_fd, &msg, 0);\n-\t\tif (recv_bytes < 0)\n+retry:\n+\t\trecv_bytes = recv(nlsk_fd, buf, sizeof(buf), 0);\n+\t\tif (recv_bytes < 0) {\n+\t\t\tif (errno == EINTR)\n+\t\t\t\tgoto retry;\n \t\t\treturn -1;\n+\t\t}\n+\n \t\tfor (nh = (struct nlmsghdr *)buf;\n \t\t NLMSG_OK(nh, (unsigned int)recv_bytes);\n \t\t nh = NLMSG_NEXT(nh, recv_bytes)) {\n", "prefixes": [ "1/2" ] }