Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69265/?format=api
{ "id": 69265, "url": "https://patches.dpdk.org/api/patches/69265/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200424124159.45989-11-ciara.power@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200424124159.45989-11-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200424124159.45989-11-ciara.power@intel.com", "date": "2020-04-24T12:41:51", "name": "[v4,10/18] ethdev: add callback support for telemetry", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1aa457fabd2f9898a9abee7a0e6117db816e38f6", "submitter": { "id": 978, "url": "https://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200424124159.45989-11-ciara.power@intel.com/mbox/", "series": [ { "id": 9624, "url": "https://patches.dpdk.org/api/series/9624/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9624", "date": "2020-04-24T12:41:41", "name": "update and simplify telemetry library.", "version": 4, "mbox": "https://patches.dpdk.org/series/9624/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/69265/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/69265/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 10847A00C2;\n\tFri, 24 Apr 2020 15:03:55 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 511B21D14A;\n\tFri, 24 Apr 2020 15:02:21 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 6718E1C295\n for <dev@dpdk.org>; Fri, 24 Apr 2020 15:02:10 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2020 06:02:06 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by orsmga007.jf.intel.com with ESMTP; 24 Apr 2020 06:02:04 -0700" ], "IronPort-SDR": [ "\n j7v2nZmHZiJE9So4BhnyVyyyYxm9Hv+T4ytqwC39WzMMN/AKHEjMDI6GI7LOrUgbCHqRnL+G+V\n Ajqv2F9cm/kg==", "\n AAD9BK4K9ji6zvuh6aiuXMztFtaw8exEHJwtQveNFAbkfwo457eL5oGORAmgwnQIKp6FC9Bwvi\n Wph8wxpZNQaA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,311,1583222400\"; d=\"scan'208\";a=\"245228320\"", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org,\n\tkevin.laatz@intel.com", "Cc": "reshma.pattan@intel.com, jerinjacobk@gmail.com, david.marchand@redhat.com,\n keith.wiles@intel.com, mb@smartsharesystems.com, thomas@monjalon.net,\n Bruce Richardson <bruce.richardson@intel.com>,\n Ciara Power <ciara.power@intel.com>", "Date": "Fri, 24 Apr 2020 13:41:51 +0100", "Message-Id": "<20200424124159.45989-11-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200424124159.45989-1-ciara.power@intel.com>", "References": "<20200319171907.60891-1-ciara.power@intel.com>\n <20200424124159.45989-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 10/18] ethdev: add callback support for\n\ttelemetry", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nThe ethdev library now registers commands with telemetry, and\nimplements the callback functions. These commands allow the list of\nethdev ports and the xstats and link status for a port to be queried.\n\nAn example using ethdev commands is shown below:\n\nConnecting to /var/run/dpdk/rte/dpdk_telemetry.v2\n{\"version\": \"DPDK 20.05.0-rc0\", \"pid\": 64379, \"max_output_len\": 16384}\n--> /\n{\"/\": [\"/\", \"/ethdev/link_status\", \"/ethdev/list\", \"/ethdev/xstats\", \\\n \"/help\", \"/info\"]}\n--> /ethdev/list\n{\"/ethdev/list\": [0, 1, 2, 3]}\n--> /ethdev/link_status,0\n{\"/ethdev/link_status\": {\"status\": \"UP\", \"speed\": 10000, \"duplex\": \\\n \"full-duplex\"}}\n--> /ethdev/xstats,0\n{\"/ethdev/xstats\": {\"rx_good_packets\": 0, \"tx_good_packets\": 0, \\\n <snip>\n \"tx_priority7_xon_to_xoff_packets\": 0}}\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n\n---\nv4: Modified to use binary data formatting instead of JSON.\nv2:\n - Renamed stats to xstats for device specific stats.\n - Added link status command for ethdev ports.\n---\n lib/librte_ethdev/Makefile | 4 ++\n lib/librte_ethdev/meson.build | 4 ++\n lib/librte_ethdev/rte_ethdev.c | 107 +++++++++++++++++++++++++++++++++\n 3 files changed, 115 insertions(+)", "diff": "diff --git a/lib/librte_ethdev/Makefile b/lib/librte_ethdev/Makefile\nindex d50b7ddf10..38d3d35bfe 100644\n--- a/lib/librte_ethdev/Makefile\n+++ b/lib/librte_ethdev/Makefile\n@@ -24,6 +24,10 @@ SRCS-y += rte_mtr.c\n SRCS-y += ethdev_profile.c\n SRCS-y += ethdev_trace_points.c\n \n+ifeq ($(CONFIG_RTE_LIBRTE_TELEMETRY),y)\n+LDLIBS += -lrte_telemetry\n+endif\n+\n #\n # Export include files\n #\ndiff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build\nindex e5fd82e93c..6e0535ecfd 100644\n--- a/lib/librte_ethdev/meson.build\n+++ b/lib/librte_ethdev/meson.build\n@@ -28,3 +28,7 @@ headers = files('rte_ethdev.h',\n \t'rte_tm_driver.h')\n \n deps += ['net', 'kvargs', 'meter']\n+\n+if dpdk_conf.has('RTE_LIBRTE_TELEMETRY')\n+\tdeps += ['telemetry']\n+endif\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 72aed59a54..4cfc6d1707 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -38,6 +38,9 @@\n #include <rte_kvargs.h>\n #include <rte_class.h>\n #include <rte_ether.h>\n+#ifdef RTE_LIBRTE_TELEMETRY\n+#include <rte_telemetry.h>\n+#endif\n \n #include \"rte_ethdev_trace.h\"\n #include \"rte_ethdev.h\"\n@@ -5199,9 +5202,113 @@ rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs *eth_da)\n \treturn result;\n }\n \n+#ifdef RTE_LIBRTE_TELEMETRY\n+static int\n+handle_port_list(const char *cmd __rte_unused,\n+\t\tconst char *params __rte_unused,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tint port_id;\n+\n+\trte_tel_data_start_array(d, RTE_TEL_INT_VAL);\n+\tRTE_ETH_FOREACH_DEV(port_id)\n+\t\trte_tel_data_add_array_int(d, port_id);\n+\treturn 0;\n+}\n+\n+static int\n+handle_port_xstats(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tstruct rte_eth_xstat *eth_xstats;\n+\tstruct rte_eth_xstat_name *xstat_names;\n+\tint port_id, num_xstats;\n+\tint i, ret;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\tport_id = atoi(params);\n+\tif (!rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -1;\n+\n+\tnum_xstats = rte_eth_xstats_get(port_id, NULL, 0);\n+\tif (num_xstats < 0)\n+\t\treturn -1;\n+\n+\t/* use one malloc for both names and stats */\n+\teth_xstats = malloc((sizeof(struct rte_eth_xstat) +\n+\t\t\tsizeof(struct rte_eth_xstat_name)) * num_xstats);\n+\tif (eth_xstats == NULL)\n+\t\treturn -1;\n+\txstat_names = (void *)ð_xstats[num_xstats];\n+\n+\tret = rte_eth_xstats_get_names(port_id, xstat_names, num_xstats);\n+\tif (ret < 0 || ret > num_xstats) {\n+\t\tfree(eth_xstats);\n+\t\treturn -1;\n+\t}\n+\n+\tret = rte_eth_xstats_get(port_id, eth_xstats, num_xstats);\n+\tif (ret < 0 || ret > num_xstats) {\n+\t\tfree(eth_xstats);\n+\t\treturn -1;\n+\t}\n+\n+\trte_tel_data_start_dict(d);\n+\tfor (i = 0; i < num_xstats; i++)\n+\t\trte_tel_data_add_dict_u64(d, xstat_names[i].name,\n+\t\t\t\teth_xstats[i].value);\n+\treturn 0;\n+}\n+\n+static int\n+handle_port_link_status(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tstatic const char *status_str = \"status\";\n+\tint ret, port_id;\n+\tstruct rte_eth_link link;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\tport_id = atoi(params);\n+\tif (!rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -1;\n+\n+\tret = rte_eth_link_get(port_id, &link);\n+\tif (ret < 0)\n+\t\treturn -1;\n+\n+\trte_tel_data_start_dict(d);\n+\tif (!link.link_status) {\n+\t\trte_tel_data_add_dict_string(d, status_str, \"DOWN\");\n+\t\treturn 0;\n+\t}\n+\trte_tel_data_add_dict_string(d, status_str, \"UP\");\n+\trte_tel_data_add_dict_u64(d, \"speed\", link.link_speed);\n+\trte_tel_data_add_dict_string(d, \"duplex\",\n+\t\t\t(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n+\t\t\t\t\"full-duplex\" : \"half-duplex\");\n+\treturn 0;\n+}\n+#endif\n+\n RTE_INIT(ethdev_init_log)\n {\n \trte_eth_dev_logtype = rte_log_register(\"lib.ethdev\");\n \tif (rte_eth_dev_logtype >= 0)\n \t\trte_log_set_level(rte_eth_dev_logtype, RTE_LOG_INFO);\n+#ifdef RTE_LIBRTE_TELEMETRY\n+\trte_telemetry_register_cmd(\"/ethdev/list\", handle_port_list,\n+\t\t\t\"Returns list of available ethdev ports. Takes no parameters\");\n+\trte_telemetry_register_cmd(\"/ethdev/xstats\", handle_port_xstats,\n+\t\t\t\"Returns the extended stats for a port. Parameters: int port_id\");\n+\trte_telemetry_register_cmd(\"/ethdev/link_status\",\n+\t\t\thandle_port_link_status,\n+\t\t\t\"Returns the link status for a port. Parameters: int port_id\");\n+#endif\n }\n", "prefixes": [ "v4", "10/18" ] }