Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69263/?format=api
{ "id": 69263, "url": "https://patches.dpdk.org/api/patches/69263/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200424124159.45989-9-ciara.power@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200424124159.45989-9-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200424124159.45989-9-ciara.power@intel.com", "date": "2020-04-24T12:41:49", "name": "[v4,08/18] telemetry: add default callback commands", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "75f64adce76a95e798fc918fc04a21c5d2bc4506", "submitter": { "id": 978, "url": "https://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200424124159.45989-9-ciara.power@intel.com/mbox/", "series": [ { "id": 9624, "url": "https://patches.dpdk.org/api/series/9624/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9624", "date": "2020-04-24T12:41:41", "name": "update and simplify telemetry library.", "version": 4, "mbox": "https://patches.dpdk.org/series/9624/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/69263/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/69263/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CE3EBA00C2;\n\tFri, 24 Apr 2020 15:03:32 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8A6FD1C434;\n\tFri, 24 Apr 2020 15:02:18 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 588041C240\n for <dev@dpdk.org>; Fri, 24 Apr 2020 15:02:09 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2020 06:02:01 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by orsmga007.jf.intel.com with ESMTP; 24 Apr 2020 06:01:59 -0700" ], "IronPort-SDR": [ "\n IFIowVcDFFbj8CkGdpSQ4mnmC6KOFBYiVGkFzq1WQKP5w/WKxocvcxGetNJtvmkreExQyFeL1F\n io8UtJFeM+lg==", "\n 6/PL5zMZQnncO1kL/MLe6Idt9+mz33P0/EdDi7OK7t2YHAzB1UX99I77/7VTzsOHtwk3cUUgPd\n ii4cgoBAaAiw==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,311,1583222400\"; d=\"scan'208\";a=\"245228292\"", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org,\n\tkevin.laatz@intel.com", "Cc": "reshma.pattan@intel.com, jerinjacobk@gmail.com, david.marchand@redhat.com,\n keith.wiles@intel.com, mb@smartsharesystems.com, thomas@monjalon.net,\n Ciara Power <ciara.power@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 24 Apr 2020 13:41:49 +0100", "Message-Id": "<20200424124159.45989-9-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200424124159.45989-1-ciara.power@intel.com>", "References": "<20200319171907.60891-1-ciara.power@intel.com>\n <20200424124159.45989-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 08/18] telemetry: add default callback commands", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The default commands are now added to provide the list of commands\navailable, help text for a specified command, and also information\nabout DPDK and telemetry.\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\n---\nv4: Added help command to provide help text for a command.\n---\n lib/librte_telemetry/telemetry.c | 51 ++++++++++++++++++++++++++++++++\n 1 file changed, 51 insertions(+)", "diff": "diff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/telemetry.c\nindex b71915bb69..63986378d8 100644\n--- a/lib/librte_telemetry/telemetry.c\n+++ b/lib/librte_telemetry/telemetry.c\n@@ -73,6 +73,51 @@ rte_telemetry_register_cmd(const char *cmd, telemetry_cb fn, const char *help)\n \treturn 0;\n }\n \n+static int\n+list_commands(const char *cmd __rte_unused, const char *params __rte_unused,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tint i;\n+\n+\trte_tel_data_start_array(d, RTE_TEL_STRING_VAL);\n+\tfor (i = 0; i < num_callbacks; i++)\n+\t\trte_tel_data_add_array_string(d, callbacks[i].cmd);\n+\treturn 0;\n+}\n+\n+static int\n+json_info(const char *cmd __rte_unused, const char *params __rte_unused,\n+\t\tstruct rte_tel_data *d)\n+{\n+\trte_tel_data_start_dict(d);\n+\trte_tel_data_add_dict_string(d, \"version\", rte_version());\n+\trte_tel_data_add_dict_int(d, \"pid\", getpid());\n+\trte_tel_data_add_dict_int(d, \"max_output_len\", MAX_OUTPUT_LEN);\n+\treturn 0;\n+}\n+\n+static int\n+command_help(const char *cmd __rte_unused, const char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tint i;\n+\n+\tif (!params)\n+\t\treturn -1;\n+\trte_tel_data_start_dict(d);\n+\trte_spinlock_lock(&callback_sl);\n+\tfor (i = 0; i < num_callbacks; i++)\n+\t\tif (strcmp(params, callbacks[i].cmd) == 0) {\n+\t\t\trte_tel_data_add_dict_string(d, params,\n+\t\t\t\t\tcallbacks[i].help);\n+\t\t\tbreak;\n+\t\t}\n+\trte_spinlock_unlock(&callback_sl);\n+\tif (i == num_callbacks)\n+\t\treturn -1;\n+\treturn 0;\n+}\n+\n static void\n output_json(const char *cmd, const struct rte_tel_data *d, int s)\n {\n@@ -297,6 +342,12 @@ telemetry_v2_init(const char *runtime_dir)\n {\n \tpthread_t t_new;\n \n+\trte_telemetry_register_cmd(\"/\", list_commands,\n+\t\t\t\"Returns list of available commands, Takes no parameters\");\n+\trte_telemetry_register_cmd(\"/info\", json_info,\n+\t\t\t\"Returns DPDK Telemetry information. Takes no parameters\");\n+\trte_telemetry_register_cmd(\"/help\", command_help,\n+\t\t\t\"Returns help text for a command. Parameters: string command\");\n \tv2_socket.fn = client_handler;\n \tif (strlcpy(v2_socket.path, get_socket_path(runtime_dir, 2),\n \t\t\tsizeof(v2_socket.path)) >= sizeof(v2_socket.path)) {\n", "prefixes": [ "v4", "08/18" ] }