Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69146/?format=api
{ "id": 69146, "url": "https://patches.dpdk.org/api/patches/69146/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200422190349.3768487-26-jerinj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200422190349.3768487-26-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200422190349.3768487-26-jerinj@marvell.com", "date": "2020-04-22T19:03:42", "name": "[v7,25/32] eal/trace: add trace mode configuration parameter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "32718bc636c94a7635a3c4bbda5ae5ea770c1837", "submitter": { "id": 1188, "url": "https://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200422190349.3768487-26-jerinj@marvell.com/mbox/", "series": [ { "id": 9574, "url": "https://patches.dpdk.org/api/series/9574/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9574", "date": "2020-04-22T19:03:17", "name": "DPDK Trace support", "version": 7, "mbox": "https://patches.dpdk.org/series/9574/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/69146/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/69146/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 14BDBA00C2;\n\tWed, 22 Apr 2020 21:08:30 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CF0911D6C3;\n\tWed, 22 Apr 2020 21:05:51 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 5C86D1D67A\n for <dev@dpdk.org>; Wed, 22 Apr 2020 21:05:35 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 03MJ5Y2I020008; Wed, 22 Apr 2020 12:05:34 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 30fxwpk036-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 22 Apr 2020 12:05:34 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 22 Apr 2020 12:05:27 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 22 Apr 2020 12:05:27 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id DC7A33F703F;\n Wed, 22 Apr 2020 12:05:24 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=AyHMjlD8zTGjXyxJjQ06173Udf+9ZenEizEdGJXlZqg=;\n b=ozzHt7CWWnCJfJG0mHGWePLoqykuyvJinJG84dcUghB6DwVbtj9Ylh5lt0m7gzUvqufE\n 8u82iW3oZPRB9yKYZKdcW12Iv+GnGG0wzGdiOIKNBD8Asg04rXHITXkYU5UIWCxJQqmc\n ZSEkob/zbRWoGjr70esiDy9z62mNMMrpoaQVrnzAiTbVuH+/GNLhjE6zjQK7eUhAQppc\n 7urUhJ+aK6Oa6HSKb9o7xc7yGnwSuU//HTRZBi8SO5sBgzv2BGij7klL+KXIc0g7oDrc\n j/0K/oEOiiqVCwQ/tG3JxHJUkTpIBPOjrluhD9247r9UE7+f0ECQAWGPhs/EHPTbIY09 2Q==", "From": "<jerinj@marvell.com>", "To": "John McNamara <john.mcnamara@intel.com>, Marko Kovacevic\n <marko.kovacevic@intel.com>, Jerin Jacob <jerinj@marvell.com>, \"Sunil Kumar\n Kori\" <skori@marvell.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <bruce.richardson@intel.com>,\n <david.marchand@redhat.com>, <mattias.ronnblom@ericsson.com>", "Date": "Thu, 23 Apr 2020 00:33:42 +0530", "Message-ID": "<20200422190349.3768487-26-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200422190349.3768487-1-jerinj@marvell.com>", "References": "<20200419100133.3232316-1-jerinj@marvell.com>\n <20200422190349.3768487-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676\n definitions=2020-04-22_06:2020-04-22,\n 2020-04-22 signatures=0", "Subject": "[dpdk-dev] [PATCH v7 25/32] eal/trace: add trace mode configuration\n\tparameter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Sunil Kumar Kori <skori@marvell.com>\n\nTrace library exposes --trace-mode eal parameter to configure\nevent record mode when ring buffers are full.\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\n---\n doc/guides/linux_gsg/eal_args.include.rst | 12 ++++++\n lib/librte_eal/common/eal_common_options.c | 17 ++++++++\n .../common/eal_common_trace_utils.c | 40 +++++++++++++++++++\n lib/librte_eal/common/eal_options.h | 2 +\n lib/librte_eal/common/eal_trace.h | 1 +\n 5 files changed, 72 insertions(+)", "diff": "diff --git a/doc/guides/linux_gsg/eal_args.include.rst b/doc/guides/linux_gsg/eal_args.include.rst\nindex b921c83b8..361c7cf67 100644\n--- a/doc/guides/linux_gsg/eal_args.include.rst\n+++ b/doc/guides/linux_gsg/eal_args.include.rst\n@@ -176,6 +176,18 @@ Debugging options\n By default, size of trace output file is ``1MB`` and parameter\n must be specified once only.\n \n+* ``--trace-mode=<o[verwrite] | d[iscard] >``\n+\n+ Specify the mode of update of trace output file. Either update on a file\n+ can be wrapped or discarded when file size reaches its maximum limit.\n+ For example:\n+\n+ To ``discard`` update on trace output file::\n+\n+ --trace-mode=d or --trace-mode=discard\n+\n+ Default mode is ``overwrite`` and parameter must be specified once only.\n+\n Other options\n ~~~~~~~~~~~~~\n \ndiff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex 32b163a81..7e3a7df9c 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -71,6 +71,7 @@ eal_long_options[] = {\n \t{OPT_TRACE, 1, NULL, OPT_TRACE_NUM },\n \t{OPT_TRACE_DIR, 1, NULL, OPT_TRACE_DIR_NUM },\n \t{OPT_TRACE_BUF_SIZE, 1, NULL, OPT_TRACE_BUF_SIZE_NUM },\n+\t{OPT_TRACE_MODE, 1, NULL, OPT_TRACE_MODE_NUM },\n \t{OPT_MASTER_LCORE, 1, NULL, OPT_MASTER_LCORE_NUM },\n \t{OPT_MBUF_POOL_OPS_NAME, 1, NULL, OPT_MBUF_POOL_OPS_NAME_NUM},\n \t{OPT_NO_HPET, 0, NULL, OPT_NO_HPET_NUM },\n@@ -1450,6 +1451,15 @@ eal_parse_common_option(int opt, const char *optarg,\n \t\tbreak;\n \t}\n \n+\tcase OPT_TRACE_MODE_NUM: {\n+\t\tif (eal_trace_mode_args_save(optarg) < 0) {\n+\t\t\tRTE_LOG(ERR, EAL, \"invalid parameters for --\"\n+\t\t\t\tOPT_TRACE_MODE \"\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\t\tbreak;\n+\t}\n+\n \tcase OPT_LCORES_NUM:\n \t\tif (eal_parse_lcores(optarg) < 0) {\n \t\t\tRTE_LOG(ERR, EAL, \"invalid parameter for --\"\n@@ -1741,6 +1751,13 @@ eal_common_usage(void)\n \t \" 'KBytes' and 'MBytes' respectively.\\n\"\n \t \" Default is 1MB and parameter must be\\n\"\n \t \" specified once only.\\n\"\n+\t \" --\"OPT_TRACE_MODE\"=<o[verwrite] | d[iscard]>\\n\"\n+\t \" Specify the mode of update of trace\\n\"\n+\t \" output file. Either update on a file can\\n\"\n+\t \" be wrapped or discarded when file size\\n\"\n+\t \" reaches its maximum limit.\\n\"\n+\t \" Default mode is 'overwrite' and parameter\\n\"\n+\t \" must be specified once only.\\n\"\n \t \" -v Display version information on startup\\n\"\n \t \" -h, --help This help\\n\"\n \t \" --\"OPT_IN_MEMORY\" Operate entirely in memory. This will\\n\"\ndiff --git a/lib/librte_eal/common/eal_common_trace_utils.c b/lib/librte_eal/common/eal_common_trace_utils.c\nindex b4ac79c95..5b2906677 100644\n--- a/lib/librte_eal/common/eal_common_trace_utils.c\n+++ b/lib/librte_eal/common/eal_common_trace_utils.c\n@@ -223,6 +223,46 @@ trace_bufsz_args_apply(void)\n \t\ttrace->buff_len = 1024 * 1024; /* 1MB */\n }\n \n+int\n+eal_trace_mode_args_save(const char *optarg)\n+{\n+\tstruct trace *trace = trace_obj_get();\n+\tsize_t len = strlen(optarg);\n+\tunsigned long tmp;\n+\tchar *pattern;\n+\n+\tif (optarg == NULL) {\n+\t\ttrace_err(\"no optarg is passed\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (len == 0) {\n+\t\ttrace_err(\"value is not provided with option\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tpattern = (char *)calloc(1, len + 2);\n+\tif (pattern == NULL) {\n+\t\ttrace_err(\"fail to allocate memory\");\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\tsprintf(pattern, \"%s*\", optarg);\n+\n+\tif (fnmatch(pattern, \"overwrite\", 0) == 0)\n+\t\ttmp = RTE_TRACE_MODE_OVERWRITE;\n+\telse if (fnmatch(pattern, \"discard\", 0) == 0)\n+\t\ttmp = RTE_TRACE_MODE_DISCARD;\n+\telse {\n+\t\tfree(pattern);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\ttrace->mode = tmp;\n+\tfree(pattern);\n+\treturn 0;\n+}\n+\n int\n eal_trace_dir_args_save(char const *optarg)\n {\ndiff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h\nindex 3e9a54f3a..90ead1b7c 100644\n--- a/lib/librte_eal/common/eal_options.h\n+++ b/lib/librte_eal/common/eal_options.h\n@@ -39,6 +39,8 @@ enum {\n \tOPT_TRACE_DIR_NUM,\n #define OPT_TRACE_BUF_SIZE \"trace-bufsz\"\n \tOPT_TRACE_BUF_SIZE_NUM,\n+#define OPT_TRACE_MODE \"trace-mode\"\n+\tOPT_TRACE_MODE_NUM,\n #define OPT_MASTER_LCORE \"master-lcore\"\n \tOPT_MASTER_LCORE_NUM,\n #define OPT_MBUF_POOL_OPS_NAME \"mbuf-pool-ops-name\"\ndiff --git a/lib/librte_eal/common/eal_trace.h b/lib/librte_eal/common/eal_trace.h\nindex 2fd73c5d5..dc3eca6eb 100644\n--- a/lib/librte_eal/common/eal_trace.h\n+++ b/lib/librte_eal/common/eal_trace.h\n@@ -116,6 +116,7 @@ void eal_trace_fini(void);\n int eal_trace_args_save(const char *optarg);\n void eal_trace_args_free(void);\n int eal_trace_dir_args_save(const char *optarg);\n+int eal_trace_mode_args_save(const char *optarg);\n int eal_trace_bufsz_args_save(const char *optarg);\n \n #endif /* __EAL_TRACE_H */\n", "prefixes": [ "v7", "25/32" ] }