Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69137/?format=api
https://patches.dpdk.org/api/patches/69137/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200422190349.3768487-18-jerinj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200422190349.3768487-18-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200422190349.3768487-18-jerinj@marvell.com", "date": "2020-04-22T19:03:34", "name": "[v7,17/32] eal/trace: add alarm tracepoints", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5708ea1dc9ffbd783c185d0e80e6a89721b56919", "submitter": { "id": 1188, "url": "https://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200422190349.3768487-18-jerinj@marvell.com/mbox/", "series": [ { "id": 9574, "url": "https://patches.dpdk.org/api/series/9574/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9574", "date": "2020-04-22T19:03:17", "name": "DPDK Trace support", "version": 7, "mbox": "https://patches.dpdk.org/series/9574/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/69137/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/69137/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7B604A00C2;\n\tWed, 22 Apr 2020 21:06:57 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A30DC1D614;\n\tWed, 22 Apr 2020 21:05:29 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 9C6DC1D603\n for <dev@dpdk.org>; Wed, 22 Apr 2020 21:04:58 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 03MIxcb6013115; Wed, 22 Apr 2020 12:04:57 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 30fxwpk01j-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 22 Apr 2020 12:04:57 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 22 Apr 2020 12:04:55 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 22 Apr 2020 12:04:56 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id 0A4613F7043;\n Wed, 22 Apr 2020 12:04:53 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=xi0EsxqEtzyAGMRtNfO/wH0QrIwMmAOznjzuE3StJJ4=;\n b=LBCpuQGrt6p1RuqSU8CfkEu13dqN49fwnFjCYmPvTvyK3BVsD08HlsPK9xMfj+k9CXa1\n m1p++jgma35c5vh4CY0cpHdfBveE+ft5t1LKViUllMs01AewPUkLipcFqWNSeTqilOWH\n vgumBiyZuthni9JjExXOkFk7wXoyfsHaGmNGyrs7KJTHxTi68BJly0bdZZFlmWj1bcYA\n 65NnRqxKW/ykA8XAJrVi7gycN7GXrqO/dlk8Q28wn6mz9I22nN41l40G6mrLp5EibcSO\n u7EXz/3Q6p7unWxt93WBDoQv1RQfX0NH6N8JVJsSA8I6U8wztNJhHaGC5FPw7sGhygyf /g==", "From": "<jerinj@marvell.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <david.marchand@redhat.com>,\n <mattias.ronnblom@ericsson.com>", "Date": "Thu, 23 Apr 2020 00:33:34 +0530", "Message-ID": "<20200422190349.3768487-18-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200422190349.3768487-1-jerinj@marvell.com>", "References": "<20200419100133.3232316-1-jerinj@marvell.com>\n <20200422190349.3768487-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676\n definitions=2020-04-22_06:2020-04-22,\n 2020-04-22 signatures=0", "Subject": "[dpdk-dev] [PATCH v7 17/32] eal/trace: add alarm tracepoints", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nAdd following alarm related trace points.\n\n- rte_trace_lib_eal_alarm_set()\n- rte_trace_lib_eal_alarm_cancel()\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\n---\n .../common/eal_common_trace_points.c | 9 ++++++++\n lib/librte_eal/freebsd/eal_alarm.c | 3 +++\n lib/librte_eal/include/rte_eal_trace.h | 21 +++++++++++++++++++\n lib/librte_eal/linux/eal_alarm.c | 4 ++++\n lib/librte_eal/rte_eal_version.map | 2 ++\n 5 files changed, 39 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_common_trace_points.c b/lib/librte_eal/common/eal_common_trace_points.c\nindex d37289f81..ba9c8e407 100644\n--- a/lib/librte_eal/common/eal_common_trace_points.c\n+++ b/lib/librte_eal/common/eal_common_trace_points.c\n@@ -23,6 +23,9 @@ RTE_TRACE_POINT_DEFINE(rte_eal_trace_generic_ptr);\n RTE_TRACE_POINT_DEFINE(rte_eal_trace_generic_str);\n RTE_TRACE_POINT_DEFINE(rte_eal_trace_generic_func);\n \n+RTE_TRACE_POINT_DEFINE(rte_eal_trace_alarm_set);\n+RTE_TRACE_POINT_DEFINE(rte_eal_trace_alarm_cancel);\n+\n RTE_INIT(eal_trace_init)\n {\n \tRTE_TRACE_POINT_REGISTER(rte_eal_trace_generic_void,\n@@ -57,4 +60,10 @@ RTE_INIT(eal_trace_init)\n \t\t\t\t lib.eal.generic.string);\n \tRTE_TRACE_POINT_REGISTER(rte_eal_trace_generic_func,\n \t\t\t\t lib.eal.generic.func);\n+\n+\tRTE_TRACE_POINT_REGISTER(rte_eal_trace_alarm_set,\n+\t\t\t\t lib.eal.alarm.set);\n+\tRTE_TRACE_POINT_REGISTER(rte_eal_trace_alarm_cancel,\n+\t\t\t\t lib.eal.alarm.cancel);\n+\n }\ndiff --git a/lib/librte_eal/freebsd/eal_alarm.c b/lib/librte_eal/freebsd/eal_alarm.c\nindex 51ea4b8c0..c38b2e04f 100644\n--- a/lib/librte_eal/freebsd/eal_alarm.c\n+++ b/lib/librte_eal/freebsd/eal_alarm.c\n@@ -17,6 +17,7 @@\n #include <rte_errno.h>\n #include <rte_interrupts.h>\n #include <rte_spinlock.h>\n+#include <rte_eal_trace.h>\n \n #include \"eal_private.h\"\n #include \"eal_alarm_private.h\"\n@@ -223,6 +224,7 @@ rte_eal_alarm_set(uint64_t us, rte_eal_alarm_callback cb_fn, void *cb_arg)\n \n \trte_spinlock_unlock(&alarm_list_lk);\n \n+\trte_eal_trace_alarm_set(us, cb_fn, cb_arg, ret);\n \treturn ret;\n }\n \n@@ -310,5 +312,6 @@ rte_eal_alarm_cancel(rte_eal_alarm_callback cb_fn, void *cb_arg)\n \n \trte_spinlock_unlock(&alarm_list_lk);\n \n+\trte_eal_trace_alarm_cancel(cb_fn, cb_arg, count);\n \treturn count;\n }\ndiff --git a/lib/librte_eal/include/rte_eal_trace.h b/lib/librte_eal/include/rte_eal_trace.h\nindex fe9776d80..5de8ce856 100644\n--- a/lib/librte_eal/include/rte_eal_trace.h\n+++ b/lib/librte_eal/include/rte_eal_trace.h\n@@ -15,6 +15,7 @@\n extern \"C\" {\n #endif\n \n+#include <rte_alarm.h>\n #include <rte_trace_point.h>\n \n /* Generic */\n@@ -115,6 +116,26 @@ RTE_TRACE_POINT(\n \n #define RTE_TRACE_LIB_EAL_GENERIC_FUNC rte_eal_trace_generic_func(__func__)\n \n+/* Alarm */\n+RTE_TRACE_POINT(\n+\trte_eal_trace_alarm_set,\n+\tRTE_TRACE_POINT_ARGS(uint64_t us, rte_eal_alarm_callback cb_fn,\n+\t\t\t void *cb_arg, int rc),\n+\trte_trace_point_emit_u64(us);\n+\trte_trace_point_emit_ptr(cb_fn);\n+\trte_trace_point_emit_ptr(cb_arg);\n+\trte_trace_point_emit_int(rc);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_eal_trace_alarm_cancel,\n+\tRTE_TRACE_POINT_ARGS(rte_eal_alarm_callback cb_fn, void *cb_arg,\n+\t\t\t int count),\n+\trte_trace_point_emit_ptr(cb_fn);\n+\trte_trace_point_emit_ptr(cb_arg);\n+\trte_trace_point_emit_int(count);\n+)\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_eal/linux/eal_alarm.c b/lib/librte_eal/linux/eal_alarm.c\nindex 0924c9205..3252c6fa5 100644\n--- a/lib/librte_eal/linux/eal_alarm.c\n+++ b/lib/librte_eal/linux/eal_alarm.c\n@@ -20,6 +20,8 @@\n #include <rte_lcore.h>\n #include <rte_errno.h>\n #include <rte_spinlock.h>\n+#include <rte_eal_trace.h>\n+\n #include <eal_private.h>\n \n #ifndef\tTFD_NONBLOCK\n@@ -172,6 +174,7 @@ rte_eal_alarm_set(uint64_t us, rte_eal_alarm_callback cb_fn, void *cb_arg)\n \t}\n \trte_spinlock_unlock(&alarm_list_lk);\n \n+\trte_eal_trace_alarm_set(us, cb_fn, cb_arg, ret);\n \treturn ret;\n }\n \n@@ -240,5 +243,6 @@ rte_eal_alarm_cancel(rte_eal_alarm_callback cb_fn, void *cb_arg)\n \telse if (err)\n \t\trte_errno = err;\n \n+\trte_eal_trace_alarm_cancel(cb_fn, cb_arg, count);\n \treturn count;\n }\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex c333ac900..4cba9a55d 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -357,6 +357,8 @@ EXPERIMENTAL {\n \trte_trace_regexp;\n \trte_trace_save;\n \n+\t__rte_trace_lib_eal_alarm_cancel;\n+\t__rte_trace_lib_eal_alarm_set;\n \t__rte_trace_lib_eal_generic_double;\n \t__rte_trace_lib_eal_generic_float;\n \t__rte_trace_lib_eal_generic_func;\n", "prefixes": [ "v7", "17/32" ] }{ "id": 69137, "url": "