Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69130/?format=api
{ "id": 69130, "url": "https://patches.dpdk.org/api/patches/69130/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200422190349.3768487-11-jerinj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200422190349.3768487-11-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200422190349.3768487-11-jerinj@marvell.com", "date": "2020-04-22T19:03:27", "name": "[v7,10/32] eal/trace: implement debug dump function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c065a71b42c562e4225723e3b5d6e869c8a65d01", "submitter": { "id": 1188, "url": "https://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200422190349.3768487-11-jerinj@marvell.com/mbox/", "series": [ { "id": 9574, "url": "https://patches.dpdk.org/api/series/9574/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9574", "date": "2020-04-22T19:03:17", "name": "DPDK Trace support", "version": 7, "mbox": "https://patches.dpdk.org/series/9574/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/69130/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/69130/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DA939A00C2;\n\tWed, 22 Apr 2020 21:05:44 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 07FE01D5CF;\n\tWed, 22 Apr 2020 21:04:53 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 9B9391D595\n for <dev@dpdk.org>; Wed, 22 Apr 2020 21:04:34 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 03MJ1Mam005798; Wed, 22 Apr 2020 12:04:34 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 30jd013jfs-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 22 Apr 2020 12:04:33 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 22 Apr 2020 12:04:31 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 22 Apr 2020 12:04:31 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 22 Apr 2020 12:04:31 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id C1F503F703F;\n Wed, 22 Apr 2020 12:04:28 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=jeXUCTXcWX0rRLNacrflzBWNGqx0zsJGORoaOFWqh9w=;\n b=YagJj0Xp1ptb12mYNub1Zqq3EWc0aJlrXQDPBw1vbdVY1AlNyOulBtKOErVlK/6gpXfV\n ux6gZ6YmnuavANUhVdb3khBxUCgsWM0cu08jPfcw7PIwXGDDkG0rNNm/QMSA/caiSrou\n DpjGgRKZefWZUu6NA7HPhJSVaACRMLYocKI/i8XxjDN3tkQbdDpZA99dWCsCFzN4ugQb\n Xf/wuwVMJ21AJUbJ7OEruLR83RNWvv2X/wrK/+I893O5PhK+GlaBbME3iUbHQ0NMqMsm\n 9agLZZVobTluxPF3TQiYJ1E7VnHShoLXFSbTwD2ICq6qlXpfUE2JkB+09TGLdc/fUz+r sQ==", "From": "<jerinj@marvell.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <bruce.richardson@intel.com>,\n <david.marchand@redhat.com>, <mattias.ronnblom@ericsson.com>", "Date": "Thu, 23 Apr 2020 00:33:27 +0530", "Message-ID": "<20200422190349.3768487-11-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200422190349.3768487-1-jerinj@marvell.com>", "References": "<20200419100133.3232316-1-jerinj@marvell.com>\n <20200422190349.3768487-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676\n definitions=2020-04-22_06:2020-04-22,\n 2020-04-22 signatures=0", "Subject": "[dpdk-dev] [PATCH v7 10/32] eal/trace: implement debug dump function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nImplement rte_trace_metadata_dump() and rte_trace_dump()\nfunctions. Former one used to dump the CTF metadata file and\nthe latter one to dump all the registered events and its status.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\n---\n lib/librte_eal/common/eal_common_trace.c | 57 +++++++++++++++++\n lib/librte_eal/common/eal_common_trace_ctf.c | 67 ++++++++++++++++++++\n lib/librte_eal/rte_eal_version.map | 2 +\n 3 files changed, 126 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_common_trace.c b/lib/librte_eal/common/eal_common_trace.c\nindex 43f51df62..bca1232f9 100644\n--- a/lib/librte_eal/common/eal_common_trace.c\n+++ b/lib/librte_eal/common/eal_common_trace.c\n@@ -230,6 +230,63 @@ rte_trace_point_lookup(const char *name)\n \treturn NULL;\n }\n \n+static void\n+trace_point_dump(FILE *f, struct trace_point *tp)\n+{\n+\trte_trace_point_t *handle = tp->handle;\n+\n+\tfprintf(f, \"\\tid %d, %s, size is %d, %s\\n\",\n+\t\ttrace_id_get(handle), tp->name,\n+\t\t(uint16_t)(*handle & __RTE_TRACE_FIELD_SIZE_MASK),\n+\t\trte_trace_point_is_enabled(handle) ? \"enabled\" : \"disabled\");\n+}\n+\n+static void\n+trace_lcore_mem_dump(FILE *f)\n+{\n+\tstruct trace *trace = trace_obj_get();\n+\tstruct __rte_trace_header *header;\n+\tuint32_t count;\n+\n+\tif (trace->nb_trace_mem_list == 0)\n+\t\treturn;\n+\n+\trte_spinlock_lock(&trace->lock);\n+\tfprintf(f, \"nb_trace_mem_list = %d\\n\", trace->nb_trace_mem_list);\n+\tfprintf(f, \"\\nTrace mem info\\n--------------\\n\");\n+\tfor (count = 0; count < trace->nb_trace_mem_list; count++) {\n+\t\theader = trace->lcore_meta[count].mem;\n+\t\tfprintf(f, \"\\tid %d, mem=%p, area=%s, lcore_id=%d, name=%s\\n\",\n+\t\tcount, header,\n+\t\ttrace_area_to_string(trace->lcore_meta[count].area),\n+\t\theader->stream_header.lcore_id,\n+\t\theader->stream_header.thread_name);\n+\t}\n+\trte_spinlock_unlock(&trace->lock);\n+}\n+\n+void\n+rte_trace_dump(FILE *f)\n+{\n+\tstruct trace_point_head *tp_list = trace_list_head_get();\n+\tstruct trace *trace = trace_obj_get();\n+\tstruct trace_point *tp;\n+\n+\tfprintf(f, \"\\nGlobal info\\n-----------\\n\");\n+\tfprintf(f, \"status = %s\\n\",\n+\t\trte_trace_is_enabled() ? \"enabled\" : \"disabled\");\n+\tfprintf(f, \"mode = %s\\n\",\n+\t\ttrace_mode_to_string(rte_trace_mode_get()));\n+\tfprintf(f, \"dir = %s\\n\", trace->dir);\n+\tfprintf(f, \"buffer len = %d\\n\", trace->buff_len);\n+\tfprintf(f, \"number of trace points = %d\\n\", trace->nb_trace_points);\n+\n+\ttrace_lcore_mem_dump(f);\n+\tfprintf(f, \"\\nTrace point info\\n----------------\\n\");\n+\tSTAILQ_FOREACH(tp, tp_list, next)\n+\t\ttrace_point_dump(f, tp);\n+}\n+\n static inline size_t\n list_sz(uint32_t index)\n {\ndiff --git a/lib/librte_eal/common/eal_common_trace_ctf.c b/lib/librte_eal/common/eal_common_trace_ctf.c\nindex c4f00bf22..302e2bb74 100644\n--- a/lib/librte_eal/common/eal_common_trace_ctf.c\n+++ b/lib/librte_eal/common/eal_common_trace_ctf.c\n@@ -419,3 +419,70 @@ trace_metadata_destroy(void)\n \t}\n }\n \n+static void\n+meta_fix_freq(struct trace *trace, char *meta)\n+{\n+\tchar *str;\n+\tint rc;\n+\n+\tstr = RTE_PTR_ADD(meta, trace->ctf_meta_offset_freq);\n+\trc = sprintf(str, \"%20\"PRIu64\"\", rte_get_timer_hz());\n+\tstr[rc] = ';';\n+}\n+\n+static void\n+meta_fix_freq_offset(struct trace *trace, char *meta)\n+{\n+\tuint64_t uptime_tickes_floor, uptime_ticks, freq, uptime_sec;\n+\tuint64_t offset, offset_s;\n+\tchar *str;\n+\tint rc;\n+\n+\tuptime_ticks = trace->uptime_ticks &\n+\t\t\t((1ULL << __RTE_TRACE_EVENT_HEADER_ID_SHIFT) - 1);\n+\tfreq = rte_get_tsc_hz();\n+\tuptime_tickes_floor = RTE_ALIGN_MUL_FLOOR(uptime_ticks, freq);\n+\n+\tuptime_sec = uptime_tickes_floor / freq;\n+\toffset_s = trace->epoch_sec - uptime_sec;\n+\n+\toffset = uptime_ticks - uptime_tickes_floor;\n+\toffset += trace->epoch_nsec * (freq / NSEC_PER_SEC);\n+\n+\tstr = RTE_PTR_ADD(meta, trace->ctf_meta_offset_freq_off_s);\n+\trc = sprintf(str, \"%20\"PRIu64\"\", offset_s);\n+\tstr[rc] = ';';\n+\tstr = RTE_PTR_ADD(meta, trace->ctf_meta_offset_freq_off);\n+\trc = sprintf(str, \"%20\"PRIu64\"\", offset);\n+\tstr[rc] = ';';\n+}\n+\n+static void\n+meta_fixup(struct trace *trace, char *meta)\n+{\n+\tmeta_fix_freq(trace, meta);\n+\tmeta_fix_freq_offset(trace, meta);\n+}\n+\n+int\n+rte_trace_metadata_dump(FILE *f)\n+{\n+\tstruct trace *trace = trace_obj_get();\n+\tchar *ctf_meta = trace->ctf_meta;\n+\tint rc;\n+\n+\tif (!rte_trace_is_enabled())\n+\t\treturn 0;\n+\n+\tif (ctf_meta == NULL)\n+\t\treturn -EINVAL;\n+\n+\tif (!__atomic_load_n(&trace->ctf_fixup_done, __ATOMIC_SEQ_CST) &&\n+\t\t\t\trte_get_timer_hz()) {\n+\t\tmeta_fixup(trace, ctf_meta);\n+\t\t__atomic_store_n(&trace->ctf_fixup_done, 1, __ATOMIC_SEQ_CST);\n+\t}\n+\n+\trc = fprintf(f, \"%s\", ctf_meta);\n+\treturn rc < 0 ? rc : 0;\n+}\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 98e0f8413..7bda1704c 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -343,7 +343,9 @@ EXPERIMENTAL {\n \tper_lcore_trace_point_sz;\n \trte_log_can_log;\n \trte_thread_getname;\n+\trte_trace_dump;\n \trte_trace_is_enabled;\n+\trte_trace_metadata_dump;\n \trte_trace_mode_get;\n \trte_trace_mode_set;\n \trte_trace_pattern;\n", "prefixes": [ "v7", "10/32" ] }