Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69073/?format=api
{ "id": 69073, "url": "https://patches.dpdk.org/api/patches/69073/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200422033006.1124-5-honnappa.nagarahalli@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200422033006.1124-5-honnappa.nagarahalli@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200422033006.1124-5-honnappa.nagarahalli@arm.com", "date": "2020-04-22T03:30:06", "name": "[v5,4/4] lib/rcu: add additional debug logs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bfedfe48904f17434ab3e468fc10f20aab138cea", "submitter": { "id": 1045, "url": "https://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200422033006.1124-5-honnappa.nagarahalli@arm.com/mbox/", "series": [ { "id": 9558, "url": "https://patches.dpdk.org/api/series/9558/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9558", "date": "2020-04-22T03:30:02", "name": "Add RCU reclamation APIs", "version": 5, "mbox": "https://patches.dpdk.org/series/9558/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/69073/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/69073/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 64EE6A05A1;\n\tWed, 22 Apr 2020 05:30:53 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B10201C434;\n\tWed, 22 Apr 2020 05:30:39 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 27D1D1C2DD\n for <dev@dpdk.org>; Wed, 22 Apr 2020 05:30:36 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 721BE1063;\n Tue, 21 Apr 2020 20:30:35 -0700 (PDT)", "from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com\n [10.118.14.48])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 611913F6CF;\n Tue, 21 Apr 2020 20:30:35 -0700 (PDT)" ], "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "To": "konstantin.ananyev@intel.com, stephen@networkplumber.org,\n vladimir.medvedkin@intel.com, dev@dpdk.org", "Cc": "honnappa.nagarahalli@arm.com, david.marchand@redhat.com,\n ruifeng.wang@arm.com, dharmik.thakkar@arm.com, nd@arm.com", "Date": "Tue, 21 Apr 2020 22:30:06 -0500", "Message-Id": "<20200422033006.1124-5-honnappa.nagarahalli@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200422033006.1124-1-honnappa.nagarahalli@arm.com>", "References": "<20191001062917.35578-1-honnappa.nagarahalli@arm.com>\n <20200422033006.1124-1-honnappa.nagarahalli@arm.com>", "Subject": "[dpdk-dev] [PATCH v5 4/4] lib/rcu: add additional debug logs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Added additional debug logs. These helped in debugging RCU\ndefer APIs.\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n lib/librte_rcu/rte_rcu_qsbr.h | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_rcu/rte_rcu_qsbr.h b/lib/librte_rcu/rte_rcu_qsbr.h\nindex e2fc7f83e..9524915fa 100644\n--- a/lib/librte_rcu/rte_rcu_qsbr.h\n+++ b/lib/librte_rcu/rte_rcu_qsbr.h\n@@ -718,8 +718,15 @@ rte_rcu_qsbr_check(struct rte_rcu_qsbr *v, uint64_t t, bool wait)\n \tRTE_ASSERT(v != NULL);\n \n \t/* Check if all the readers have already acknowledged this token */\n-\tif (likely(t <= v->acked_token))\n+\tif (likely(t <= v->acked_token)) {\n+\t\t__RTE_RCU_DP_LOG(DEBUG,\n+\t\t\t\"%s: check: token = %\"PRIu64\", wait = %d\",\n+\t\t\t__func__, t, wait);\n+\t\t__RTE_RCU_DP_LOG(DEBUG,\n+\t\t\t\"%s: status: least acked token = %\"PRIu64\"\",\n+\t\t\t__func__, v->acked_token);\n \t\treturn 1;\n+\t}\n \n \tif (likely(v->num_threads == v->max_threads))\n \t\treturn __rte_rcu_qsbr_check_all(v, t, wait);\n", "prefixes": [ "v5", "4/4" ] }