List comments

GET /api/patches/69/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 172,
        "web_url": "https://patches.dpdk.org/comment/172/",
        "msgid": "<1882677.eVWsvu6oSK@xps13>",
        "date": "2014-07-21T13:44:41",
        "subject": "Re: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in\n\tl3fwd-acl",
        "submitter": {
            "id": 1,
            "url": "https://patches.dpdk.org/api/people/1/",
            "name": "Thomas Monjalon",
            "email": "thomas.monjalon@6wind.com"
        },
        "content": "Hi,\n\n2014-07-20 20:47, Matthew Hall:\n> +CFLAGS += -Wno-unused-function\n\nI think it's better to fix the code instead of removing a warning.\nIf there is a very good reason to not do it, it would appear in the log.\n\nThanks",
        "headers": {
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "dev@dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=heAvoM2WIId10QDPd3E83oF3SdZi43xFCyg2iRIeS3o=;\n\tb=KVU45Z7iRmkX9duHQBb2D98ry06rlwRakFfsldFfwsYXYcqcTlSlgxXxEv9yj1oOL4\n\t5/XDgHnwpZJSOzVLULenRN4ELdRN82GQJpmddAF869V6nlUGvi/EC9pFLjoUEFy23PYf\n\teAJNDrsVWmbi7J27iefxtj8YFsx9shXwxm1BazeMYPGLMUUctaYtRlMrVjRBOz29MIwa\n\t9dUL7KbWOcOYXmrGTe3+orFZ8y2yLpkxrAJi74oUQqOHaAxbIwKKMhW2zirx5qJHcwLt\n\thdMqa0bG0vXn5OsCGpv+r2GM6WSOoffXcnZFlLAEZ382gh4Z2k4CbeEnvV0QSqxfA1ir\n\t5bKA==",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Date": "Mon, 21 Jul 2014 15:44:41 +0200",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1405914461-19335-1-git-send-email-mhall@mhcomputing.net>\n\t<1405914461-19335-2-git-send-email-mhall@mhcomputing.net>",
            "In-Reply-To": "<1405914461-19335-2-git-send-email-mhall@mhcomputing.net>",
            "X-Gm-Message-State": "ALoCoQmbXB+roLa/sxlV7d1JjmCeIQ5WJ88Do3Z7PnrVtK+VPD8CpftbX2KBkryEpt/Kc1xn0L+T",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "To": "Matthew Hall <mhall@mhcomputing.net>",
            "User-Agent": "KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; )",
            "MIME-Version": "1.0",
            "Received": [
                "from mail-we0-f182.google.com (mail-we0-f182.google.com\n\t[74.125.82.182]) by dpdk.org (Postfix) with ESMTP id 4531E595A\n\tfor <dev@dpdk.org>; Mon, 21 Jul 2014 15:43:35 +0200 (CEST)",
                "by mail-we0-f182.google.com with SMTP id k48so6391687wev.13\n\tfor <dev@dpdk.org>; Mon, 21 Jul 2014 06:44:49 -0700 (PDT)",
                "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tpl1sm20092891wic.17.2014.07.21.06.44.48 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 21 Jul 2014 06:44:48 -0700 (PDT)"
            ],
            "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "Message-ID": "<1882677.eVWsvu6oSK@xps13>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Transfer-Encoding": "7Bit",
            "Subject": "Re: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in\n\tl3fwd-acl",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-List-Received-Date": "Mon, 21 Jul 2014 13:43:35 -0000",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Return-Path": "<thomas.monjalon@6wind.com>",
            "Organization": "6WIND",
            "X-Received": "by 10.180.8.10 with SMTP id n10mr4568422wia.41.1405950289683;\n\tMon, 21 Jul 2014 06:44:49 -0700 (PDT)",
            "X-Mailman-Version": "2.1.15"
        }
    },
    {
        "id": 182,
        "web_url": "https://patches.dpdk.org/comment/182/",
        "msgid": "<5d0e56af-1662-4e4a-b942-4da275234d5f@email.android.com>",
        "date": "2014-07-21T16:53:45",
        "subject": "Re: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in\n\tl3fwd-acl",
        "submitter": {
            "id": 37,
            "url": "https://patches.dpdk.org/api/people/37/",
            "name": "Matthew Hall",
            "email": "mhall@mhcomputing.net"
        },
        "content": "The same code is used in l3fwd and l3fwd-acl. When it is reused in l3fwd-acl a packet processing function from original l3fwd is not used any more.",
        "headers": {
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "dev@dpdk.org",
            "Content-Type": "text/plain;\n charset=UTF-8",
            "Date": "Mon, 21 Jul 2014 09:53:45 -0700",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<1882677.eVWsvu6oSK@xps13>",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1405914461-19335-1-git-send-email-mhall@mhcomputing.net>\n\t<1405914461-19335-2-git-send-email-mhall@mhcomputing.net>\n\t<1882677.eVWsvu6oSK@xps13>",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "To": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "User-Agent": "K-9 Mail for Android",
            "MIME-Version": "1.0",
            "Received": [
                "from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186])\n\tby dpdk.org (Postfix) with ESMTP id 53B9C595A\n\tfor <dev@dpdk.org>; Mon, 21 Jul 2014 19:22:04 +0200 (CEST)",
                "from [192.168.0.34] (172-3-139-73.lightspeed.sntcca.sbcglobal.net\n\t[172.3.139.73])\n\tby mail.mhcomputing.net (Postfix) with ESMTPSA id 8C48580BDB3;\n\tMon, 21 Jul 2014 10:22:46 -0700 (PDT)"
            ],
            "From": "Matthew Hall <mhall@mhcomputing.net>",
            "Message-ID": "<5d0e56af-1662-4e4a-b942-4da275234d5f@email.android.com>",
            "Content-Transfer-Encoding": "8bit",
            "Subject": "Re: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in\n\tl3fwd-acl",
            "X-List-Received-Date": "Mon, 21 Jul 2014 17:22:04 -0000",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Return-Path": "<mhall@mhcomputing.net>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-Mailman-Version": "2.1.15"
        }
    },
    {
        "id": 183,
        "web_url": "https://patches.dpdk.org/comment/183/",
        "msgid": "<59AF69C657FD0841A61C55336867B5B0343B0E8C@IRSMSX103.ger.corp.intel.com>",
        "date": "2014-07-21T17:37:49",
        "subject": "Re: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in\n\tl3fwd-acl",
        "submitter": {
            "id": 20,
            "url": "https://patches.dpdk.org/api/people/20/",
            "name": "Bruce Richardson",
            "email": "bruce.richardson@intel.com"
        },
        "content": "> -----Original Message-----\n> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matthew Hall\n> Sent: Sunday, July 20, 2014 8:48 PM\n> To: dev@dpdk.org\n> Subject: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in l3fwd-acl\n> \n> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>\n> ---\n>  examples/l3fwd/Makefile | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/examples/l3fwd/Makefile b/examples/l3fwd/Makefile\n> index 68de8fc..5cd7396 100644\n> --- a/examples/l3fwd/Makefile\n> +++ b/examples/l3fwd/Makefile\n> @@ -46,6 +46,7 @@ SRCS-y := main.c\n> \n>  CFLAGS += -O3 $(USER_FLAGS)\n>  CFLAGS += $(WERROR_FLAGS)\n> +CFLAGS += -Wno-unused-function\n> \n\nRather than disabling the warnings, would it not be better to remove the functions entirely from the compile? I would assume that these are functions for one leg of the l3fwd code (e.g. hash lookup vs lpm lookup) that are not used in the other leg of the code, in which case the proper fix should be to add some more #ifdefs, right?\n\n/Bruce",
        "headers": {
            "Thread-Index": "AQHPpJdnpTbSOJKo3kiI4X4g1wvFMZuqy2IA",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "X-MS-Has-Attach": "",
            "Date": "Mon, 21 Jul 2014 17:37:49 +0000",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<1405914461-19335-2-git-send-email-mhall@mhcomputing.net>",
            "Message-ID": "<59AF69C657FD0841A61C55336867B5B0343B0E8C@IRSMSX103.ger.corp.intel.com>",
            "X-BeenThere": "dev@dpdk.org",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Accept-Language": "en-GB, en-US",
            "References": "<1405914461-19335-1-git-send-email-mhall@mhcomputing.net>\n\t<1405914461-19335-2-git-send-email-mhall@mhcomputing.net>",
            "X-MS-TNEF-Correlator": "",
            "Return-Path": "<bruce.richardson@intel.com>",
            "x-originating-ip": "[163.33.239.181]",
            "MIME-Version": "1.0",
            "Received": [
                "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 57824595A\n\tfor <dev@dpdk.org>; Mon, 21 Jul 2014 19:36:48 +0200 (CEST)",
                "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 21 Jul 2014 10:38:02 -0700",
                "from irsmsx101.ger.corp.intel.com ([163.33.3.153])\n\tby fmsmga002.fm.intel.com with ESMTP; 21 Jul 2014 10:38:01 -0700",
                "from irsmsx107.ger.corp.intel.com (163.33.3.99) by\n\tIRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP\n\tServer (TLS) id 14.3.123.3; Mon, 21 Jul 2014 18:37:49 +0100",
                "from irsmsx103.ger.corp.intel.com ([169.254.3.62]) by\n\tIRSMSX107.ger.corp.intel.com ([169.254.10.112]) with mapi id\n\t14.03.0123.003; Mon, 21 Jul 2014 18:37:49 +0100"
            ],
            "From": "\"Richardson, Bruce\" <bruce.richardson@intel.com>",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Content-Transfer-Encoding": "quoted-printable",
            "Subject": "Re: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in\n\tl3fwd-acl",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-List-Received-Date": "Mon, 21 Jul 2014 17:36:48 -0000",
            "To": "Matthew Hall <mhall@mhcomputing.net>, \"dev@dpdk.org\" <dev@dpdk.org>",
            "Content-Language": "en-US",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "X-Mailman-Version": "2.1.15",
            "X-ExtLoop1": "1",
            "Thread-Topic": "[dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in\n\tl3fwd-acl",
            "X-IronPort-AV": "E=Sophos;i=\"5.01,702,1400050800\"; d=\"scan'208\";a=\"573190568\""
        }
    }
]