Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68898/?format=api
{ "id": 68898, "url": "https://patches.dpdk.org/api/patches/68898/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200419100133.3232316-28-jerinj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200419100133.3232316-28-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200419100133.3232316-28-jerinj@marvell.com", "date": "2020-04-19T10:01:27", "name": "[v6,27/33] eal/trace: add unit test cases", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4fc7a08c4745dec5b9916005219107d4c5a7bcc9", "submitter": { "id": 1188, "url": "https://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200419100133.3232316-28-jerinj@marvell.com/mbox/", "series": [ { "id": 9495, "url": "https://patches.dpdk.org/api/series/9495/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9495", "date": "2020-04-19T10:01:02", "name": "DPDK Trace support", "version": 6, "mbox": "https://patches.dpdk.org/series/9495/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/68898/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/68898/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2C8CFA0561;\n\tSun, 19 Apr 2020 12:09:52 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D47731D66A;\n\tSun, 19 Apr 2020 12:03:39 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 5AABA1D604\n for <dev@dpdk.org>; Sun, 19 Apr 2020 12:03:21 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 03JA18bB020141; Sun, 19 Apr 2020 03:03:20 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 30g12njxet-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sun, 19 Apr 2020 03:03:19 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Sun, 19 Apr 2020 03:03:17 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Sun, 19 Apr 2020 03:03:16 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Sun, 19 Apr 2020 03:03:16 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id C40873F703F;\n Sun, 19 Apr 2020 03:03:14 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=yx0hFrEoX4TNGHiLUirngM1tuA+bEqSODzcAwjTSU5I=;\n b=PWRCTjsliCN75xrCg1RK61cg67soAE1jPehq8Ql/8R1R9R5kC6FoWIdgNZ4DoXT46WGX\n RGXMs9U0QqdM2UifNqZPgb8aoT+KZf+485/b70ibP5mi8a2+LhrPaLirXL0QVQigCW9/\n hwZ4R+WQC9jK8Dlqw5COD8xI9RGTQRFm/3Q2iwRBD11ARLpe7MjN+5QODyiAvny/r6+/\n 11ZjGFmJ60nvZ13ctPF+ke3tst4lnTIeKzTxtEfZ+X9UV77pW/X7vT2cGQ/1cVuaEdWp\n DzBF84RX1xcb1VYpAKBEGk2aD2m7XzOKOnuMUXOaikNIO0MjK0o31zm1FDpBBQl3msAY VQ==", "From": "<jerinj@marvell.com>", "To": "", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <bruce.richardson@intel.com>,\n <david.marchand@redhat.com>, <mattias.ronnblom@ericsson.com>,\n <skori@marvell.com>", "Date": "Sun, 19 Apr 2020 15:31:27 +0530", "Message-ID": "<20200419100133.3232316-28-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200419100133.3232316-1-jerinj@marvell.com>", "References": "<20200413150116.734047-1-jerinj@marvell.com>\n <20200419100133.3232316-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676\n definitions=2020-04-19_02:2020-04-17,\n 2020-04-19 signatures=0", "Subject": "[dpdk-dev] [PATCH v6 27/33] eal/trace: add unit test cases", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Sunil Kumar Kori <skori@marvell.com>\n\nExample commands to run UT and check the traces with babeltrace viewer.\n\n- Delete the existing /root/dpdk-traces/ directory if needed.\n> sudo rm -rf /root/dpdk-traces/\n\n- Start the dpdk-test\n> sudo ./build/app/test/dpdk-test -c 0x3 - --trace=.*\n\n- Run trace_autotest\n> trace_autotest\n\n- View the traces with babletrace viewer.\n> sudo babeltrace /root/dpdk-traces/\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\n---\n app/test/Makefile | 3 +-\n app/test/meson.build | 2 +\n app/test/test_trace.c | 223 +++++++++++++++++++++++++++++++++\n app/test/test_trace.h | 15 +++\n app/test/test_trace_register.c | 17 +++\n 5 files changed, 259 insertions(+), 1 deletion(-)\n create mode 100644 app/test/test_trace.c\n create mode 100644 app/test/test_trace.h\n create mode 100644 app/test/test_trace_register.c", "diff": "diff --git a/app/test/Makefile b/app/test/Makefile\nindex be53d33c3..9fb7b843f 100644\n--- a/app/test/Makefile\n+++ b/app/test/Makefile\n@@ -148,7 +148,8 @@ SRCS-y += test_alarm.c\n SRCS-y += test_interrupts.c\n SRCS-y += test_version.c\n SRCS-y += test_func_reentrancy.c\n-\n+SRCS-y += test_trace.c\n+SRCS-y += test_trace_register.c\n SRCS-y += test_service_cores.c\n \n ifeq ($(CONFIG_RTE_LIBRTE_PMD_RING),y)\ndiff --git a/app/test/meson.build b/app/test/meson.build\nindex 04b59cffa..78023ee71 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -121,6 +121,8 @@ test_sources = files('commands.c',\n \t'test_timer_racecond.c',\n \t'test_timer_secondary.c',\n \t'test_ticketlock.c',\n+\t'test_trace.c',\n+\t'test_trace_register.c',\n \t'test_version.c',\n \t'virtual_pmd.c'\n )\ndiff --git a/app/test/test_trace.c b/app/test/test_trace.c\nnew file mode 100644\nindex 000000000..26b403e62\n--- /dev/null\n+++ b/app/test/test_trace.c\n@@ -0,0 +1,223 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2020 Marvell International Ltd.\n+ */\n+\n+#include <rte_lcore.h>\n+#include <rte_trace.h>\n+#include <rte_trace_eal.h>\n+\n+#include \"test.h\"\n+#include \"test_trace.h\"\n+\n+static int32_t\n+test_trace_point_globbing(void)\n+{\n+\tbool val;\n+\tint rc;\n+\n+\trc = rte_trace_pattern(\"app.dpdk.test*\", false);\n+\tif (rc != 1)\n+\t\tgoto failed;\n+\n+\tval = rte_trace_point_is_enabled(&__app_dpdk_test_tp);\n+\tif (val == true)\n+\t\tgoto failed;\n+\n+\trc = rte_trace_pattern(\"app.dpdk.test*\", true);\n+\tif (rc != 1)\n+\t\tgoto failed;\n+\n+\tval = rte_trace_point_is_enabled(&__app_dpdk_test_tp);\n+\tif (val == false)\n+\t\tgoto failed;\n+\n+\trc = rte_trace_pattern(\"invalid_testpoint.*\", true);\n+\tif (rc != 0)\n+\t\tgoto failed;\n+\n+\treturn TEST_SUCCESS;\n+\n+failed:\n+\treturn TEST_FAILED;\n+}\n+\n+static int32_t\n+test_trace_point_regex(void)\n+{\n+\tbool val;\n+\tint rc;\n+\n+\n+\trc = rte_trace_regexp(\"app.dpdk.test*\", false);\n+\tif (rc != 1)\n+\t\tgoto failed;\n+\n+\tval = rte_trace_point_is_enabled(&__app_dpdk_test_tp);\n+\tif (val == true)\n+\t\tgoto failed;\n+\n+\trc = rte_trace_regexp(\"app.dpdk.test*\", true);\n+\tif (rc != 1)\n+\t\tgoto failed;\n+\n+\tval = rte_trace_point_is_enabled(&__app_dpdk_test_tp);\n+\tif (val == false)\n+\t\tgoto failed;\n+\n+\trc = rte_trace_regexp(\"invalid_testpoint.*\", true);\n+\tif (rc != 0)\n+\t\tgoto failed;\n+\n+\treturn TEST_SUCCESS;\n+\n+failed:\n+\treturn TEST_FAILED;\n+}\n+\n+static int32_t\n+test_trace_point_disable_enable(void)\n+{\n+\tbool val;\n+\tint rc;\n+\n+\trc = rte_trace_point_disable(&__app_dpdk_test_tp);\n+\tif (rc < 0)\n+\t\tgoto failed;\n+\n+\tval = rte_trace_point_is_enabled(&__app_dpdk_test_tp);\n+\tif (val == true)\n+\t\tgoto failed;\n+\n+\trc = rte_trace_point_enable(&__app_dpdk_test_tp);\n+\tif (rc < 0)\n+\t\tgoto failed;\n+\n+\tval = rte_trace_point_is_enabled(&__app_dpdk_test_tp);\n+\tif (val == false)\n+\t\tgoto failed;\n+\n+\t/* Emit the trace */\n+\tapp_dpdk_test_tp(\"app.dpdk.test.tp\");\n+\treturn TEST_SUCCESS;\n+\n+failed:\n+\treturn TEST_FAILED;\n+}\n+\n+static int\n+test_trace_mode(void)\n+{\n+\tenum rte_trace_mode current;\n+\n+\tcurrent = rte_trace_mode_get();\n+\n+\tif (rte_trace_is_enabled() == false)\n+\t\treturn TEST_SKIPPED;\n+\n+\trte_trace_mode_set(RTE_TRACE_MODE_DISCARD);\n+\tif (rte_trace_mode_get() != RTE_TRACE_MODE_DISCARD)\n+\t\tgoto failed;\n+\n+\trte_trace_mode_set(RTE_TRACE_MODE_OVERWRITE);\n+\tif (rte_trace_mode_get() != RTE_TRACE_MODE_OVERWRITE)\n+\t\tgoto failed;\n+\n+\trte_trace_mode_set(current);\n+\treturn TEST_SUCCESS;\n+\n+failed:\n+\treturn TEST_FAILED;\n+\n+}\n+\n+static int\n+test_trace_points_lookup(void)\n+{\n+\trte_trace_point_t *trace;\n+\n+\ttrace = rte_trace_point_lookup(\"app.dpdk.test.tp\");\n+\tif (trace == NULL)\n+\t\tgoto fail;\n+\ttrace = rte_trace_point_lookup(\"this_trace_point_does_not_exist\");\n+\tif (trace != NULL)\n+\t\tgoto fail;\n+\n+\treturn TEST_SUCCESS;\n+fail:\n+\treturn TEST_FAILED;\n+}\n+\n+static int\n+test_trace_fastpath_point(void)\n+{\n+\t/* Emit the FP trace */\n+\tapp_dpdk_test_fp();\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+static int\n+test_generic_trace_points(void)\n+{\n+\tint tmp;\n+\n+\trte_trace_lib_eal_generic_void();\n+\trte_trace_lib_eal_generic_u64(0x10000000000000);\n+\trte_trace_lib_eal_generic_u32(0x10000000);\n+\trte_trace_lib_eal_generic_u16(0xffee);\n+\trte_trace_lib_eal_generic_u8(0xc);\n+\trte_trace_lib_eal_generic_i64(-1234);\n+\trte_trace_lib_eal_generic_i32(-1234567);\n+\trte_trace_lib_eal_generic_i16(12);\n+\trte_trace_lib_eal_generic_i8(-3);\n+\trte_trace_lib_eal_generic_int(3333333);\n+\trte_trace_lib_eal_generic_long(333);\n+\trte_trace_lib_eal_generic_float(20.45);\n+\trte_trace_lib_eal_generic_double(20000.5000004);\n+\trte_trace_lib_eal_generic_ptr(&tmp);\n+\trte_trace_lib_eal_generic_str(\"my string\");\n+\tRTE_TRACE_LIB_EAL_GENERIC_FUNC;\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+static struct unit_test_suite trace_tests = {\n+\t.suite_name = \"trace autotest\",\n+\t.setup = NULL,\n+\t.teardown = NULL,\n+\t.unit_test_cases = {\n+\t\tTEST_CASE(test_trace_mode),\n+\t\tTEST_CASE(test_generic_trace_points),\n+\t\tTEST_CASE(test_trace_fastpath_point),\n+\t\tTEST_CASE(test_trace_point_disable_enable),\n+\t\tTEST_CASE(test_trace_point_globbing),\n+\t\tTEST_CASE(test_trace_point_regex),\n+\t\tTEST_CASE(test_trace_points_lookup),\n+\t\tTEST_CASES_END()\n+\t}\n+};\n+\n+static int\n+test_trace(void)\n+{\n+\treturn unit_test_suite_runner(&trace_tests);\n+}\n+\n+REGISTER_TEST_COMMAND(trace_autotest, test_trace);\n+\n+static int\n+test_trace_dump(void)\n+{\n+\trte_trace_dump(stdout);\n+\treturn 0;\n+}\n+\n+REGISTER_TEST_COMMAND(trace_dump, test_trace_dump);\n+\n+static int\n+test_trace_metadata_dump(void)\n+{\n+\treturn rte_trace_metadata_dump(stdout);\n+}\n+\n+REGISTER_TEST_COMMAND(trace_metadata_dump, test_trace_metadata_dump);\ndiff --git a/app/test/test_trace.h b/app/test/test_trace.h\nnew file mode 100644\nindex 000000000..413842f60\n--- /dev/null\n+++ b/app/test/test_trace.h\n@@ -0,0 +1,15 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2020 Marvell International Ltd.\n+ */\n+#include <rte_trace_point.h>\n+\n+RTE_TRACE_POINT(\n+\tapp_dpdk_test_tp,\n+\tRTE_TRACE_POINT_ARGS(const char *str),\n+\trte_trace_point_emit_string(str);\n+)\n+\n+RTE_TRACE_POINT_FP(\n+\tapp_dpdk_test_fp,\n+\tRTE_TRACE_POINT_ARGS(void),\n+)\ndiff --git a/app/test/test_trace_register.c b/app/test/test_trace_register.c\nnew file mode 100644\nindex 000000000..1735149a2\n--- /dev/null\n+++ b/app/test/test_trace_register.c\n@@ -0,0 +1,17 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2020 Marvell International Ltd.\n+ */\n+#define RTE_TRACE_POINT_REGISTER_SELECT /* Select trace point register macros */\n+\n+#include \"test_trace.h\"\n+\n+/* Define trace points */\n+RTE_TRACE_POINT_DEFINE(app_dpdk_test_tp);\n+RTE_TRACE_POINT_DEFINE(app_dpdk_test_fp);\n+\n+RTE_INIT(register_valid_trace_points)\n+{\n+\tRTE_TRACE_POINT_REGISTER(app_dpdk_test_tp, app.dpdk.test.tp);\n+\tRTE_TRACE_POINT_REGISTER(app_dpdk_test_fp, app.dpdk.test.fp);\n+}\n+\n", "prefixes": [ "v6", "27/33" ] }