Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68892/?format=api
{ "id": 68892, "url": "https://patches.dpdk.org/api/patches/68892/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200419100133.3232316-22-jerinj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200419100133.3232316-22-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200419100133.3232316-22-jerinj@marvell.com", "date": "2020-04-19T10:01:21", "name": "[v6,21/33] eal/trace: add thread tracepoints", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8de76a2cac579293eaa732cdc4f212d4586e7b07", "submitter": { "id": 1188, "url": "https://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200419100133.3232316-22-jerinj@marvell.com/mbox/", "series": [ { "id": 9495, "url": "https://patches.dpdk.org/api/series/9495/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9495", "date": "2020-04-19T10:01:02", "name": "DPDK Trace support", "version": 6, "mbox": "https://patches.dpdk.org/series/9495/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/68892/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/68892/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B5399A0561;\n\tSun, 19 Apr 2020 12:08:01 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 724A31D632;\n\tSun, 19 Apr 2020 12:03:22 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 7058F1D623\n for <dev@dpdk.org>; Sun, 19 Apr 2020 12:03:14 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 03JA18BI020144; Sun, 19 Apr 2020 03:02:56 -0700", "from sc-exch03.marvell.com ([199.233.58.183])\n by mx0b-0016f401.pphosted.com with ESMTP id 30g12njxdh-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sun, 19 Apr 2020 03:02:56 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Sun, 19 Apr 2020 03:02:54 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Sun, 19 Apr 2020 03:02:54 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Sun, 19 Apr 2020 03:02:53 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id BB6763F703F;\n Sun, 19 Apr 2020 03:02:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=rwv0kf6g7Oi2Sn57UWV2W3gphfiF7neD0S7TgxC6pB0=;\n b=fQSPsTRfZzKEVgmQQXZT1AVM5POIBsAQVrH6EcmS/6H9cfdKPe+nixO4b0c/0Cz+O4Rp\n q4QQL74ZmQU+z2EHPIwLmEWzOp94RvPGscP4AbokQw6eyGnMBpEq7XqZru9gTwZ7/QCX\n MxShfrWQr8qoU889qw7pGZ1W/+wuIfLXSKbD60ockkkb/Rr7hnbhwu6Gs2dou+PVi+nX\n 8IjoUZ+JRGnz9lgILK/uE67Jbf1lAv6IY6XMmr+QtRM31e6PRpSsjFakoneBTFj/TXJY\n +OO7c4cCDJP22HkbYw3yn+zL2FfFy96fdVU36pGAgywIk3gUlLGrS9xHwDzA4RLVmgOv CQ==", "From": "<jerinj@marvell.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <david.marchand@redhat.com>,\n <mattias.ronnblom@ericsson.com>", "Date": "Sun, 19 Apr 2020 15:31:21 +0530", "Message-ID": "<20200419100133.3232316-22-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200419100133.3232316-1-jerinj@marvell.com>", "References": "<20200413150116.734047-1-jerinj@marvell.com>\n <20200419100133.3232316-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676\n definitions=2020-04-19_02:2020-04-17,\n 2020-04-19 signatures=0", "Subject": "[dpdk-dev] [PATCH v6 21/33] eal/trace: add thread tracepoints", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nAdd the following thread related tracepoints.\n\n- rte_trace_lib_eal_thread_remote_launch()\n- rte_trace_lib_eal_thread_lcore_ready()\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\n---\n lib/librte_eal/common/eal_common_trace_points.c | 8 ++++++++\n lib/librte_eal/freebsd/eal_interrupts.c | 2 +-\n lib/librte_eal/freebsd/eal_thread.c | 12 ++++++++----\n lib/librte_eal/include/rte_trace_eal.h | 17 +++++++++++++++++\n lib/librte_eal/linux/eal_thread.c | 12 ++++++++----\n lib/librte_eal/rte_eal_version.map | 2 ++\n 6 files changed, 44 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_trace_points.c b/lib/librte_eal/common/eal_common_trace_points.c\nindex a3c9bc01b..9cecd8206 100644\n--- a/lib/librte_eal/common/eal_common_trace_points.c\n+++ b/lib/librte_eal/common/eal_common_trace_points.c\n@@ -35,6 +35,9 @@ RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_memzone_reserve);\n RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_memzone_lookup);\n RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_memzone_free);\n \n+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_thread_remote_launch);\n+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_thread_lcore_ready);\n+\n RTE_INIT(eal_trace_init)\n {\n \tRTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_void,\n@@ -90,4 +93,9 @@ RTE_INIT(eal_trace_init)\n \t\t\t\t lib.eal.memzone.lookup);\n \tRTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_memzone_free,\n \t\t\t\t lib.eal.memzone.free);\n+\n+\tRTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_thread_remote_launch,\n+\t\t\t\t lib.eal.thread.remote.launch);\n+\tRTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_thread_lcore_ready,\n+\t\t\t\t lib.eal.thread.lcore.ready);\n }\ndiff --git a/lib/librte_eal/freebsd/eal_interrupts.c b/lib/librte_eal/freebsd/eal_interrupts.c\nindex 00991f26a..7def3189b 100644\n--- a/lib/librte_eal/freebsd/eal_interrupts.c\n+++ b/lib/librte_eal/freebsd/eal_interrupts.c\n@@ -85,7 +85,7 @@ rte_intr_callback_register(const struct rte_intr_handle *intr_handle,\n {\n \tstruct rte_intr_callback *callback;\n \tstruct rte_intr_source *src;\n-\tint ret, add_event = 0;\n+\tint ret = 0, add_event = 0;\n \n \t/* first do parameter checking */\n \tif (intr_handle == NULL || intr_handle->fd < 0 || cb == NULL) {\ndiff --git a/lib/librte_eal/freebsd/eal_thread.c b/lib/librte_eal/freebsd/eal_thread.c\nindex c25b4a019..d6d0e3af2 100644\n--- a/lib/librte_eal/freebsd/eal_thread.c\n+++ b/lib/librte_eal/freebsd/eal_thread.c\n@@ -20,8 +20,7 @@\n #include <rte_per_lcore.h>\n #include <rte_eal.h>\n #include <rte_lcore.h>\n-#include <rte_trace.h>\n-#include <rte_trace_point.h>\n+#include <rte_trace_eal.h>\n \n #include \"eal_private.h\"\n #include \"eal_thread.h\"\n@@ -42,9 +41,10 @@ rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned slave_id)\n \tchar c = 0;\n \tint m2s = lcore_config[slave_id].pipe_master2slave[1];\n \tint s2m = lcore_config[slave_id].pipe_slave2master[0];\n+\tint rc = -EBUSY;\n \n \tif (lcore_config[slave_id].state != WAIT)\n-\t\treturn -EBUSY;\n+\t\tgoto finish;\n \n \tlcore_config[slave_id].f = f;\n \tlcore_config[slave_id].arg = arg;\n@@ -64,7 +64,10 @@ rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned slave_id)\n \tif (n <= 0)\n \t\trte_panic(\"cannot read on configuration pipe\\n\");\n \n-\treturn 0;\n+\trc = 0;\n+finish:\n+\trte_trace_lib_eal_thread_remote_launch(f, arg, slave_id, rc);\n+\treturn rc;\n }\n \n /* set affinity for current thread */\n@@ -127,6 +130,7 @@ eal_thread_loop(__rte_unused void *arg)\n \t\tlcore_id, thread_id, cpuset, ret == 0 ? \"\" : \"...\");\n \n \t__rte_trace_mem_per_thread_alloc();\n+\trte_trace_lib_eal_thread_lcore_ready(lcore_id, cpuset);\n \n \t/* read on our pipe to get commands */\n \twhile (1) {\ndiff --git a/lib/librte_eal/include/rte_trace_eal.h b/lib/librte_eal/include/rte_trace_eal.h\nindex d13b434ca..da805e804 100644\n--- a/lib/librte_eal/include/rte_trace_eal.h\n+++ b/lib/librte_eal/include/rte_trace_eal.h\n@@ -205,6 +205,23 @@ RTE_TRACE_POINT(\n \trte_trace_point_emit_int(rc);\n )\n \n+/* Thread */\n+RTE_TRACE_POINT(\n+\trte_trace_lib_eal_thread_remote_launch,\n+\tRTE_TRACE_POINT_ARGS(int (*f)(void *), void *arg,\n+\t\t\t unsigned int slave_id, int rc),\n+\trte_trace_point_emit_ptr(f);\n+\trte_trace_point_emit_ptr(arg);\n+\trte_trace_point_emit_u32(slave_id);\n+\trte_trace_point_emit_int(rc);\n+)\n+RTE_TRACE_POINT(\n+\trte_trace_lib_eal_thread_lcore_ready,\n+\tRTE_TRACE_POINT_ARGS(unsigned int lcore_id, const char *cpuset),\n+\trte_trace_point_emit_u32(lcore_id);\n+\trte_trace_point_emit_string(cpuset);\n+)\n+\n \n #ifdef __cplusplus\n }\ndiff --git a/lib/librte_eal/linux/eal_thread.c b/lib/librte_eal/linux/eal_thread.c\nindex 24772fc3d..c2940bc4a 100644\n--- a/lib/librte_eal/linux/eal_thread.c\n+++ b/lib/librte_eal/linux/eal_thread.c\n@@ -20,8 +20,7 @@\n #include <rte_per_lcore.h>\n #include <rte_eal.h>\n #include <rte_lcore.h>\n-#include <rte_trace.h>\n-#include <rte_trace_point.h>\n+#include <rte_trace_eal.h>\n \n #include \"eal_private.h\"\n #include \"eal_thread.h\"\n@@ -42,9 +41,10 @@ rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned slave_id)\n \tchar c = 0;\n \tint m2s = lcore_config[slave_id].pipe_master2slave[1];\n \tint s2m = lcore_config[slave_id].pipe_slave2master[0];\n+\tint rc = -EBUSY;\n \n \tif (lcore_config[slave_id].state != WAIT)\n-\t\treturn -EBUSY;\n+\t\tgoto finish;\n \n \tlcore_config[slave_id].f = f;\n \tlcore_config[slave_id].arg = arg;\n@@ -64,7 +64,10 @@ rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned slave_id)\n \tif (n <= 0)\n \t\trte_panic(\"cannot read on configuration pipe\\n\");\n \n-\treturn 0;\n+\trc = 0;\n+finish:\n+\trte_trace_lib_eal_thread_remote_launch(f, arg, slave_id, rc);\n+\treturn rc;\n }\n \n /* set affinity for current EAL thread */\n@@ -127,6 +130,7 @@ eal_thread_loop(__rte_unused void *arg)\n \t\tlcore_id, (uintptr_t)thread_id, cpuset, ret == 0 ? \"\" : \"...\");\n \n \t__rte_trace_mem_per_thread_alloc();\n+\trte_trace_lib_eal_thread_lcore_ready(lcore_id, cpuset);\n \n \t/* read on our pipe to get commands */\n \twhile (1) {\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 22455c7c0..83fb686f4 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -382,4 +382,6 @@ EXPERIMENTAL {\n \t__rte_trace_lib_eal_memzone_free;\n \t__rte_trace_lib_eal_memzone_lookup;\n \t__rte_trace_lib_eal_memzone_reserve;\n+\t__rte_trace_lib_eal_thread_lcore_ready;\n+\t__rte_trace_lib_eal_thread_remote_launch;\n };\n", "prefixes": [ "v6", "21/33" ] }