Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 68791,
    "url": "https://patches.dpdk.org/api/patches/68791/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200417161920.85858-5-ajit.khaparde@broadcom.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200417161920.85858-5-ajit.khaparde@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200417161920.85858-5-ajit.khaparde@broadcom.com",
    "date": "2020-04-17T16:19:12",
    "name": "[v2,04/12] net/bnxt: add resource name type to debug messages",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "962b35ceecc22e92dc99d3e44a7660776afbcc7f",
    "submitter": {
        "id": 501,
        "url": "https://patches.dpdk.org/api/people/501/?format=api",
        "name": "Ajit Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "delegate": {
        "id": 1766,
        "url": "https://patches.dpdk.org/api/users/1766/?format=api",
        "username": "ajitkhaparde",
        "first_name": "Ajit",
        "last_name": "Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200417161920.85858-5-ajit.khaparde@broadcom.com/mbox/",
    "series": [
        {
            "id": 9475,
            "url": "https://patches.dpdk.org/api/series/9475/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9475",
            "date": "2020-04-17T16:19:08",
            "name": "enhancements to host based flow table management",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/9475/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/68791/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/68791/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5521EA0597;\n\tFri, 17 Apr 2020 18:20:10 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D32981EA15;\n\tFri, 17 Apr 2020 18:19:34 +0200 (CEST)",
            "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 6308A1E9BF\n for <dev@dpdk.org>; Fri, 17 Apr 2020 18:19:26 +0200 (CEST)",
            "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 4892430C1D6;\n Fri, 17 Apr 2020 09:08:05 -0700 (PDT)",
            "from localhost.localdomain (unknown [10.230.185.215])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id D7FFA14008D;\n Fri, 17 Apr 2020 09:19:24 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 4892430C1D6",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1587139685;\n bh=wg0ao+L0LwY1H65cb3JI6YGTFfXB8YcuXfVjfuV8mcU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=D2GenPwnTnI4GaHhSzeqgd9Ym9dBrZ7ei7OQm8uZr9begLEQAGFlSWSTBQf2MQsE/\n LwxHuOBYw4bH8tv9UwMY5meNTp17eJcBi+4K2m2S6PrEovmp4mMCHPcsi5Fs63leFJ\n UyKM8Njx6lpgPJU2+DvcbpPCBFjl2bdSyao6RDUk=",
        "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "Mike Baucom <michael.baucom@broadcom.com>,\n Kishore Padmanabha <kishore.padmanabha@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>",
        "Date": "Fri, 17 Apr 2020 09:19:12 -0700",
        "Message-Id": "<20200417161920.85858-5-ajit.khaparde@broadcom.com>",
        "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)",
        "In-Reply-To": "<20200417161920.85858-1-ajit.khaparde@broadcom.com>",
        "References": "\n <1586962156-11179-1-git-send-email-venkatkumar.duvvuru@broadcom.com>\n <20200417161920.85858-1-ajit.khaparde@broadcom.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v2 04/12] net/bnxt: add resource name type to\n\tdebug messages",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Mike Baucom <michael.baucom@broadcom.com>\n\nAdded the name of the resource to the index/result and key/mask common\nbuilder functions.\n\nReviewed-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Mike Baucom <michael.baucom@broadcom.com>\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n---\n drivers/net/bnxt/tf_ulp/ulp_mapper.c | 61 ++++++++++++++++------------\n 1 file changed, 34 insertions(+), 27 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\nindex ca4dd4562..f787c6e4d 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n@@ -365,7 +365,8 @@ ulp_mapper_ident_process(struct bnxt_ulp_mapper_parms *parms,\n static int32_t\n ulp_mapper_result_field_process(struct bnxt_ulp_mapper_parms *parms,\n \t\t\t\tstruct bnxt_ulp_mapper_result_field_info *fld,\n-\t\t\t\tstruct ulp_blob *blob)\n+\t\t\t\tstruct ulp_blob *blob,\n+\t\t\t\tconst char *name)\n {\n \tuint16_t idx, size_idx;\n \tuint8_t\t *val = NULL;\n@@ -376,20 +377,20 @@ ulp_mapper_result_field_process(struct bnxt_ulp_mapper_parms *parms,\n \tcase BNXT_ULP_RESULT_OPC_SET_TO_CONSTANT:\n \t\tval = fld->result_operand;\n \t\tif (!ulp_blob_push(blob, val, fld->field_bit_size)) {\n-\t\t\tBNXT_TF_DBG(ERR, \"Failed to add field\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s failed to add field\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tbreak;\n \tcase BNXT_ULP_RESULT_OPC_SET_TO_ACT_PROP:\n \t\tif (!ulp_operand_read(fld->result_operand,\n \t\t\t\t      (uint8_t *)&idx, sizeof(uint16_t))) {\n-\t\t\tBNXT_TF_DBG(ERR, \"operand read failed\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s operand read failed\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tidx = tfp_be_to_cpu_16(idx);\n \n \t\tif (idx >= BNXT_ULP_ACT_PROP_IDX_LAST) {\n-\t\t\tBNXT_TF_DBG(ERR, \"act_prop[%d] oob\\n\", idx);\n+\t\t\tBNXT_TF_DBG(ERR, \"%s act_prop[%d] oob\\n\", name, idx);\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tval = &parms->act_prop->act_details[idx];\n@@ -400,20 +401,20 @@ ulp_mapper_result_field_process(struct bnxt_ulp_mapper_parms *parms,\n \t\t\tval += field_size;\n \t\t}\n \t\tif (!ulp_blob_push(blob, val, fld->field_bit_size)) {\n-\t\t\tBNXT_TF_DBG(ERR, \"push field failed\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s push field failed\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tbreak;\n \tcase BNXT_ULP_RESULT_OPC_SET_TO_ACT_PROP_SZ:\n \t\tif (!ulp_operand_read(fld->result_operand,\n \t\t\t\t      (uint8_t *)&idx, sizeof(uint16_t))) {\n-\t\t\tBNXT_TF_DBG(ERR, \"operand read failed\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s operand read failed\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tidx = tfp_be_to_cpu_16(idx);\n \n \t\tif (idx >= BNXT_ULP_ACT_PROP_IDX_LAST) {\n-\t\t\tBNXT_TF_DBG(ERR, \"act_prop[%d] oob\\n\", idx);\n+\t\t\tBNXT_TF_DBG(ERR, \"%s act_prop[%d] oob\\n\", name, idx);\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tval = &parms->act_prop->act_details[idx];\n@@ -421,7 +422,7 @@ ulp_mapper_result_field_process(struct bnxt_ulp_mapper_parms *parms,\n \t\t/* get the size index next */\n \t\tif (!ulp_operand_read(&fld->result_operand[sizeof(uint16_t)],\n \t\t\t\t      (uint8_t *)&size_idx, sizeof(uint16_t))) {\n-\t\t\tBNXT_TF_DBG(ERR, \"operand read failed\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s operand read failed\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tsize_idx = tfp_be_to_cpu_16(size_idx);\n@@ -439,20 +440,21 @@ ulp_mapper_result_field_process(struct bnxt_ulp_mapper_parms *parms,\n \tcase BNXT_ULP_RESULT_OPC_SET_TO_REGFILE:\n \t\tif (!ulp_operand_read(fld->result_operand,\n \t\t\t\t      (uint8_t *)&idx, sizeof(uint16_t))) {\n-\t\t\tBNXT_TF_DBG(ERR, \"operand read failed\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s operand read failed\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \n \t\tidx = tfp_be_to_cpu_16(idx);\n \t\t/* Uninitialized regfile entries return 0 */\n \t\tif (!ulp_regfile_read(parms->regfile, idx, &regval)) {\n-\t\t\tBNXT_TF_DBG(ERR, \"regfile[%d] read oob\\n\", idx);\n+\t\t\tBNXT_TF_DBG(ERR, \"%s regfile[%d] read oob\\n\",\n+\t\t\t\t    name, idx);\n \t\t\treturn -EINVAL;\n \t\t}\n \n \t\tval = ulp_blob_push_64(blob, &regval, fld->field_bit_size);\n \t\tif (!val) {\n-\t\t\tBNXT_TF_DBG(ERR, \"push field failed\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s push field failed\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tbreak;\n@@ -468,7 +470,8 @@ static int32_t\n ulp_mapper_keymask_field_process(struct bnxt_ulp_mapper_parms *parms,\n \t\t\t\t struct bnxt_ulp_mapper_class_key_field_info *f,\n \t\t\t\t struct ulp_blob *blob,\n-\t\t\t\t uint8_t is_key)\n+\t\t\t\t uint8_t is_key,\n+\t\t\t\t const char *name)\n {\n \tuint64_t regval;\n \tuint16_t idx, bitlen;\n@@ -493,13 +496,13 @@ ulp_mapper_keymask_field_process(struct bnxt_ulp_mapper_parms *parms,\n \tcase BNXT_ULP_SPEC_OPC_SET_TO_CONSTANT:\n \t\tval = operand;\n \t\tif (!ulp_blob_push(blob, val, bitlen)) {\n-\t\t\tBNXT_TF_DBG(ERR, \"push to key blob failed\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s push to key blob failed\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tbreak;\n \tcase BNXT_ULP_SPEC_OPC_ADD_PAD:\n \t\tif (!ulp_blob_pad_push(blob, bitlen)) {\n-\t\t\tBNXT_TF_DBG(ERR, \"Pad too large for blob\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s pad too large for blob\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \n@@ -507,7 +510,7 @@ ulp_mapper_keymask_field_process(struct bnxt_ulp_mapper_parms *parms,\n \tcase BNXT_ULP_SPEC_OPC_SET_TO_HDR_FIELD:\n \t\tif (!ulp_operand_read(operand, (uint8_t *)&idx,\n \t\t\t\t      sizeof(uint16_t))) {\n-\t\t\tBNXT_TF_DBG(ERR, \"key operand read failed.\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s key operand read failed.\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tidx = tfp_be_to_cpu_16(idx);\n@@ -527,27 +530,27 @@ ulp_mapper_keymask_field_process(struct bnxt_ulp_mapper_parms *parms,\n \t\t}\n \n \t\tif (!ulp_blob_push(blob, val, bitlen)) {\n-\t\t\tBNXT_TF_DBG(ERR, \"push to key blob failed\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s push to key blob failed\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tbreak;\n \tcase BNXT_ULP_SPEC_OPC_SET_TO_REGFILE:\n \t\tif (!ulp_operand_read(operand, (uint8_t *)&idx,\n \t\t\t\t      sizeof(uint16_t))) {\n-\t\t\tBNXT_TF_DBG(ERR, \"key operand read failed.\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s key operand read failed.\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tidx = tfp_be_to_cpu_16(idx);\n \n \t\tif (!ulp_regfile_read(regfile, idx, &regval)) {\n-\t\t\tBNXT_TF_DBG(ERR, \"regfile[%d] read failed.\\n\",\n-\t\t\t\t    idx);\n+\t\t\tBNXT_TF_DBG(ERR, \"%s regfile[%d] read failed.\\n\",\n+\t\t\t\t    name, idx);\n \t\t\treturn -EINVAL;\n \t\t}\n \n \t\tval = ulp_blob_push_64(blob, &regval, bitlen);\n \t\tif (!val) {\n-\t\t\tBNXT_TF_DBG(ERR, \"push to key blob failed\\n\");\n+\t\t\tBNXT_TF_DBG(ERR, \"%s push to key blob failed\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n \tdefault:\n@@ -715,7 +718,8 @@ ulp_mapper_action_info_process(struct bnxt_ulp_mapper_parms *parms,\n \t\tfld = &flds[i];\n \t\trc = ulp_mapper_result_field_process(parms,\n \t\t\t\t\t\t     fld,\n-\t\t\t\t\t\t     &blob);\n+\t\t\t\t\t\t     &blob,\n+\t\t\t\t\t\t     \"Action\");\n \t\tif (rc) {\n \t\t\tBNXT_TF_DBG(ERR, \"Action field failed\\n\");\n \t\t\treturn rc;\n@@ -777,7 +781,7 @@ ulp_mapper_tcam_tbl_process(struct bnxt_ulp_mapper_parms *parms,\n \tfor (i = 0; i < num_kflds; i++) {\n \t\t/* Setup the key */\n \t\trc = ulp_mapper_keymask_field_process(parms, &kflds[i],\n-\t\t\t\t\t\t      &key, 1);\n+\t\t\t\t\t\t      &key, 1, \"TCAM Key\");\n \t\tif (rc) {\n \t\t\tBNXT_TF_DBG(ERR, \"Key field set failed.\\n\");\n \t\t\treturn rc;\n@@ -785,7 +789,7 @@ ulp_mapper_tcam_tbl_process(struct bnxt_ulp_mapper_parms *parms,\n \n \t\t/* Setup the mask */\n \t\trc = ulp_mapper_keymask_field_process(parms, &kflds[i],\n-\t\t\t\t\t\t      &mask, 0);\n+\t\t\t\t\t\t      &mask, 0, \"TCAM Mask\");\n \t\tif (rc) {\n \t\t\tBNXT_TF_DBG(ERR, \"Mask field set failed.\\n\");\n \t\t\treturn rc;\n@@ -852,7 +856,8 @@ ulp_mapper_tcam_tbl_process(struct bnxt_ulp_mapper_parms *parms,\n \t\tfor (i = 0; i < num_dflds; i++) {\n \t\t\trc = ulp_mapper_result_field_process(parms,\n \t\t\t\t\t\t\t     &dflds[i],\n-\t\t\t\t\t\t\t     &data);\n+\t\t\t\t\t\t\t     &data,\n+\t\t\t\t\t\t\t     \"TCAM Result\");\n \t\t\tif (rc) {\n \t\t\t\tBNXT_TF_DBG(ERR, \"Failed to set data fields\\n\");\n \t\t\t\tgoto error;\n@@ -955,7 +960,7 @@ ulp_mapper_em_tbl_process(struct bnxt_ulp_mapper_parms *parms,\n \tfor (i = 0; i < num_kflds; i++) {\n \t\t/* Setup the key */\n \t\trc = ulp_mapper_keymask_field_process(parms, &kflds[i],\n-\t\t\t\t\t\t      &key, 1);\n+\t\t\t\t\t\t      &key, 1, \"EM Key\");\n \t\tif (rc) {\n \t\t\tBNXT_TF_DBG(ERR, \"Key field set failed.\\n\");\n \t\t\treturn rc;\n@@ -981,7 +986,8 @@ ulp_mapper_em_tbl_process(struct bnxt_ulp_mapper_parms *parms,\n \n \t\trc = ulp_mapper_result_field_process(parms,\n \t\t\t\t\t\t     fld,\n-\t\t\t\t\t\t     &data);\n+\t\t\t\t\t\t     &data,\n+\t\t\t\t\t\t     \"EM Result\");\n \t\tif (rc) {\n \t\t\tBNXT_TF_DBG(ERR, \"Failed to set data fields.\\n\");\n \t\t\treturn rc;\n@@ -1130,7 +1136,8 @@ ulp_mapper_index_tbl_process(struct bnxt_ulp_mapper_parms *parms,\n \tfor (i = 0; i < num_flds; i++) {\n \t\trc = ulp_mapper_result_field_process(parms,\n \t\t\t\t\t\t     &flds[i],\n-\t\t\t\t\t\t     &data);\n+\t\t\t\t\t\t     &data,\n+\t\t\t\t\t\t     \"Indexed Result\");\n \t\tif (rc) {\n \t\t\tBNXT_TF_DBG(ERR, \"data field failed\\n\");\n \t\t\treturn rc;\n",
    "prefixes": [
        "v2",
        "04/12"
    ]
}