Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68780/?format=api
{ "id": 68780, "url": "https://patches.dpdk.org/api/patches/68780/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1587138115-13149-1-git-send-email-adwivedi@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1587138115-13149-1-git-send-email-adwivedi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1587138115-13149-1-git-send-email-adwivedi@marvell.com", "date": "2020-04-17T15:41:54", "name": "[1/2] examples/ipsec-secgw: remove duplicated if check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8c265290c1c7c5a7e29d6fcec926c3fbe5ce787e", "submitter": { "id": 1561, "url": "https://patches.dpdk.org/api/people/1561/?format=api", "name": "Ankur Dwivedi", "email": "adwivedi@marvell.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1587138115-13149-1-git-send-email-adwivedi@marvell.com/mbox/", "series": [ { "id": 9471, "url": "https://patches.dpdk.org/api/series/9471/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9471", "date": "2020-04-17T15:41:54", "name": "[1/2] examples/ipsec-secgw: remove duplicated if check", "version": 1, "mbox": "https://patches.dpdk.org/series/9471/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/68780/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/68780/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 520C5A058A;\n\tFri, 17 Apr 2020 17:42:30 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3E5EF1E961;\n\tFri, 17 Apr 2020 17:42:30 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 8406E1E91B\n for <dev@dpdk.org>; Fri, 17 Apr 2020 17:42:28 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 03HFaFvh018167 for <dev@dpdk.org>; Fri, 17 Apr 2020 08:42:27 -0700", "from sc-exch03.marvell.com ([199.233.58.183])\n by mx0b-0016f401.pphosted.com with ESMTP id 30dn84vs17-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 17 Apr 2020 08:42:27 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 17 Apr 2020 08:42:25 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Fri, 17 Apr 2020 08:42:26 -0700", "from hyd1349.t110.caveonetworks.com (unknown [10.29.45.13])\n by maili.marvell.com (Postfix) with ESMTP id 66EC73F703F;\n Fri, 17 Apr 2020 08:42:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-type; s=pfpt0818;\n bh=DvPPAFbu9BJlIAg0iMZaiFmPBR4YBSHU/HXTsX4dH+s=;\n b=r0h+cwHdLWOwgW/OfOewLArll7zUN5ZKjpNlbAofPdlRZVbEf5EXHmMVQhCVwsIy8nOh\n uEGk3GlxC0H2FHVaqBiIGxcAoQHp4878XiL9gM+c4+SLOsjCknxM12CmaxLR2vfCIdig\n IhFkJrKJoOeXaP6GYYxZIVoymheN7nEDqiu+0j0S2c8rDdYzsml9p0wPlN1ua/GJuVtM\n tSUGzkE9xfDIWfp2q8fYlHBrQrhKMq9YY/jwoOUuJlla4WKvotNzh8Q2ns1gJvcof5Rl\n yCXOu9yoympK8m/nm7WKFcfTqbrAjZchhn4/p1vpkTC0T6Jvje0Occet/tcA1YBCC1Nh Zw==", "From": "Ankur Dwivedi <adwivedi@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<lbartosik@marvell.com>, <anoobj@marvell.com>, Ankur Dwivedi\n <adwivedi@marvell.com>", "Date": "Fri, 17 Apr 2020 21:11:54 +0530", "Message-ID": "<1587138115-13149-1-git-send-email-adwivedi@marvell.com>", "X-Mailer": "git-send-email 1.9.3", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676\n definitions=2020-04-17_07:2020-04-17,\n 2020-04-17 signatures=0", "Subject": "[dpdk-dev] [PATCH 1/2] examples/ipsec-secgw: remove duplicated if\n\tcheck", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The two if check does the same task, so removing one.\n\nCoverity Issue: 355669\nFixes: 9ad50c29d01d (\"examples/ipsec-secgw: add app mode worker\")\n\nSigned-off-by: Ankur Dwivedi <adwivedi@marvell.com>\n---\n examples/ipsec-secgw/ipsec_worker.c | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)", "diff": "diff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c\nindex 5fde667..b6c851f 100644\n--- a/examples/ipsec-secgw/ipsec_worker.c\n+++ b/examples/ipsec-secgw/ipsec_worker.c\n@@ -112,12 +112,7 @@\n \trte_acl_classify((struct rte_acl_ctx *)sp, &nlp, &res, 1,\n \t\t\tDEFAULT_MAX_CATEGORIES);\n \n-\tif (unlikely(res == 0)) {\n-\t\t/* No match */\n-\t\treturn 0;\n-\t}\n-\n-\tif (res == DISCARD)\n+\tif (unlikely(res == DISCARD))\n \t\treturn 0;\n \telse if (res == BYPASS) {\n \t\t*sa_idx = -1;\n", "prefixes": [ "1/2" ] }