Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68724/?format=api
{ "id": 68724, "url": "https://patches.dpdk.org/api/patches/68724/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1587098436-7493-11-git-send-email-nicolas.chautru@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1587098436-7493-11-git-send-email-nicolas.chautru@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1587098436-7493-11-git-send-email-nicolas.chautru@intel.com", "date": "2020-04-17T04:40:35", "name": "[v3,10/11] baseband/fpga_5gnr_fec: add interrupt support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f7bbc14847d2e8999387bc573e22a08e2a1c2407", "submitter": { "id": 1314, "url": "https://patches.dpdk.org/api/people/1314/?format=api", "name": "Chautru, Nicolas", "email": "nicolas.chautru@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1587098436-7493-11-git-send-email-nicolas.chautru@intel.com/mbox/", "series": [ { "id": 9446, "url": "https://patches.dpdk.org/api/series/9446/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9446", "date": "2020-04-17T04:40:25", "name": "drivers/baseband: PMD for FPGA 5GNR FEC", "version": 3, "mbox": "https://patches.dpdk.org/series/9446/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/68724/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/68724/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EBDDAA0588;\n\tFri, 17 Apr 2020 06:43:33 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AD7B41DE96;\n\tFri, 17 Apr 2020 06:41:54 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id E74D51DE26\n for <dev@dpdk.org>; Fri, 17 Apr 2020 06:41:41 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Apr 2020 21:41:42 -0700", "from skx-5gnr-sc12-4.sc.intel.com ([172.25.69.210])\n by orsmga002.jf.intel.com with ESMTP; 16 Apr 2020 21:41:41 -0700" ], "IronPort-SDR": [ "\n r/S/ONvmOddpk0zhOIKg9nfEukZ5SlzRHJBiWK4Vhx8QiNInKLEu29cVdQ1Y87EOR8Yj5BVZjK\n sV0BURQklbow==", "\n UjF59dRVdr6CfZa1tlXMw7Pa94f974uEYPLH0CR7QLmANKuB0AEElQZPYPO2LppR23CN2N9PLX\n VELTI94fYRTw==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,393,1580803200\"; d=\"scan'208\";a=\"272304087\"", "From": "Nicolas Chautru <nicolas.chautru@intel.com>", "To": "dev@dpdk.org,\n\takhil.goyal@nxp.com", "Cc": "bruce.richardson@intel.com,\n\tNicolas Chautru <nicolas.chautru@intel.com>", "Date": "Thu, 16 Apr 2020 21:40:35 -0700", "Message-Id": "<1587098436-7493-11-git-send-email-nicolas.chautru@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1587098436-7493-1-git-send-email-nicolas.chautru@intel.com>", "References": "<1587098436-7493-1-git-send-email-nicolas.chautru@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 10/11] baseband/fpga_5gnr_fec: add interrupt\n\tsupport", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adding support for interrupt capability in the PMD\nand the related operations.\n\nSigned-off-by: Nicolas Chautru <nicolas.chautru@intel.com>\n---\n drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 17 +++\n drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 139 +++++++++++++++++++++\n 2 files changed, 156 insertions(+)", "diff": "diff --git a/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h b/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h\nindex 5f443d7..2587af1 100644\n--- a/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h\n+++ b/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h\n@@ -368,4 +368,21 @@ struct __rte_cache_aligned fpga_queue {\n \n #endif\n \n+/* Read a register of FPGA 5GNR FEC device */\n+static inline uint8_t\n+fpga_reg_read_8(void *mmio_base, uint32_t offset)\n+{\n+\tvoid *reg_addr = RTE_PTR_ADD(mmio_base, offset);\n+\treturn *((volatile uint8_t *)(reg_addr));\n+}\n+\n+/* Read a register of FPGA 5GNR FEC device */\n+static inline uint64_t\n+fpga_reg_read_64(void *mmio_base, uint32_t offset)\n+{\n+\tvoid *reg_addr = RTE_PTR_ADD(mmio_base, offset);\n+\tuint64_t ret = *((volatile uint64_t *)(reg_addr));\n+\treturn rte_le_to_cpu_64(ret);\n+}\n+\n #endif /* _FPGA_5GNR_FEC_H_ */\ndiff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c\nindex 6804fa6..d8812f1 100644\n--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c\n+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c\n@@ -325,6 +325,7 @@\n \t\t\t\tRTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_IN_ENABLE |\n \t\t\t\tRTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_OUT_ENABLE |\n \t\t\t\tRTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_LOOPBACK |\n+\t\t\t\tRTE_BBDEV_LDPC_DEC_INTERRUPTS |\n \t\t\t\tRTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS,\n \t\t\t.llr_size = 6,\n \t\t\t.llr_decimals = 2,\n@@ -636,14 +637,152 @@\n \treturn 0;\n }\n \n+static inline uint16_t\n+get_queue_id(struct rte_bbdev_data *data, uint8_t q_idx)\n+{\n+\tuint16_t queue_id;\n+\n+\tfor (queue_id = 0; queue_id < data->num_queues; ++queue_id) {\n+\t\tstruct fpga_queue *q = data->queues[queue_id].queue_private;\n+\t\tif (q != NULL && q->q_idx == q_idx)\n+\t\t\treturn queue_id;\n+\t}\n+\n+\treturn -1;\n+}\n+\n+/* Interrupt handler triggered by FPGA dev for handling specific interrupt */\n+static void\n+fpga_dev_interrupt_handler(void *cb_arg)\n+{\n+\tstruct rte_bbdev *dev = cb_arg;\n+\tstruct fpga_5gnr_fec_device *fpga_dev = dev->data->dev_private;\n+\tstruct fpga_queue *q;\n+\tuint64_t ring_head;\n+\tuint64_t q_idx;\n+\tuint16_t queue_id;\n+\tuint8_t i;\n+\n+\t/* Scan queue assigned to this device */\n+\tfor (i = 0; i < FPGA_TOTAL_NUM_QUEUES; ++i) {\n+\t\tq_idx = 1ULL << i;\n+\t\tif (fpga_dev->q_bound_bit_map & q_idx) {\n+\t\t\tqueue_id = get_queue_id(dev->data, i);\n+\t\t\tif (queue_id == (uint16_t) -1)\n+\t\t\t\tcontinue;\n+\n+\t\t\t/* Check if completion head was changed */\n+\t\t\tq = dev->data->queues[queue_id].queue_private;\n+\t\t\tring_head = *q->ring_head_addr;\n+\t\t\tif (q->shadow_completion_head != ring_head &&\n+\t\t\t\tq->irq_enable == 1) {\n+\t\t\t\tq->shadow_completion_head = ring_head;\n+\t\t\t\trte_bbdev_pmd_callback_process(\n+\t\t\t\t\t\tdev,\n+\t\t\t\t\t\tRTE_BBDEV_EVENT_DEQUEUE,\n+\t\t\t\t\t\t&queue_id);\n+\t\t\t}\n+\t\t}\n+\t}\n+}\n+\n+static int\n+fpga_queue_intr_enable(struct rte_bbdev *dev, uint16_t queue_id)\n+{\n+\tstruct fpga_queue *q = dev->data->queues[queue_id].queue_private;\n+\n+\tif (!rte_intr_cap_multiple(dev->intr_handle))\n+\t\treturn -ENOTSUP;\n+\n+\tq->irq_enable = 1;\n+\n+\treturn 0;\n+}\n+\n+static int\n+fpga_queue_intr_disable(struct rte_bbdev *dev, uint16_t queue_id)\n+{\n+\tstruct fpga_queue *q = dev->data->queues[queue_id].queue_private;\n+\tq->irq_enable = 0;\n+\n+\treturn 0;\n+}\n+\n+static int\n+fpga_intr_enable(struct rte_bbdev *dev)\n+{\n+\tint ret;\n+\tuint8_t i;\n+\n+\tif (!rte_intr_cap_multiple(dev->intr_handle)) {\n+\t\trte_bbdev_log(ERR, \"Multiple intr vector is not supported by FPGA (%s)\",\n+\t\t\t\tdev->data->name);\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\t/* Create event file descriptors for each of 64 queue. Event fds will be\n+\t * mapped to FPGA IRQs in rte_intr_enable(). This is a 1:1 mapping where\n+\t * the IRQ number is a direct translation to the queue number.\n+\t *\n+\t * 63 (FPGA_NUM_INTR_VEC) event fds are created as rte_intr_enable()\n+\t * mapped the first IRQ to already created interrupt event file\n+\t * descriptor (intr_handle->fd).\n+\t */\n+\tif (rte_intr_efd_enable(dev->intr_handle, FPGA_NUM_INTR_VEC)) {\n+\t\trte_bbdev_log(ERR, \"Failed to create fds for %u queues\",\n+\t\t\t\tdev->data->num_queues);\n+\t\treturn -1;\n+\t}\n+\n+\t/* TODO Each event file descriptor is overwritten by interrupt event\n+\t * file descriptor. That descriptor is added to epoll observed list.\n+\t * It ensures that callback function assigned to that descriptor will\n+\t * invoked when any FPGA queue issues interrupt.\n+\t */\n+\tfor (i = 0; i < FPGA_NUM_INTR_VEC; ++i)\n+\t\tdev->intr_handle->efds[i] = dev->intr_handle->fd;\n+\n+\tif (!dev->intr_handle->intr_vec) {\n+\t\tdev->intr_handle->intr_vec = rte_zmalloc(\"intr_vec\",\n+\t\t\t\tdev->data->num_queues * sizeof(int), 0);\n+\t\tif (!dev->intr_handle->intr_vec) {\n+\t\t\trte_bbdev_log(ERR, \"Failed to allocate %u vectors\",\n+\t\t\t\t\tdev->data->num_queues);\n+\t\t\treturn -ENOMEM;\n+\t\t}\n+\t}\n+\n+\tret = rte_intr_enable(dev->intr_handle);\n+\tif (ret < 0) {\n+\t\trte_bbdev_log(ERR,\n+\t\t\t\t\"Couldn't enable interrupts for device: %s\",\n+\t\t\t\tdev->data->name);\n+\t\treturn ret;\n+\t}\n+\n+\tret = rte_intr_callback_register(dev->intr_handle,\n+\t\t\tfpga_dev_interrupt_handler, dev);\n+\tif (ret < 0) {\n+\t\trte_bbdev_log(ERR,\n+\t\t\t\t\"Couldn't register interrupt callback for device: %s\",\n+\t\t\t\tdev->data->name);\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static const struct rte_bbdev_ops fpga_ops = {\n \t.setup_queues = fpga_setup_queues,\n+\t.intr_enable = fpga_intr_enable,\n \t.close = fpga_dev_close,\n \t.info_get = fpga_dev_info_get,\n \t.queue_setup = fpga_queue_setup,\n \t.queue_stop = fpga_queue_stop,\n \t.queue_start = fpga_queue_start,\n \t.queue_release = fpga_queue_release,\n+\t.queue_intr_enable = fpga_queue_intr_enable,\n+\t.queue_intr_disable = fpga_queue_intr_disable\n };\n \n static inline void\n", "prefixes": [ "v3", "10/11" ] }